--- /dev/null
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 376F2431FB6\r
+ for <notmuch@notmuchmail.org>; Thu, 26 Jan 2012 08:19:01 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id ptKEqi1X7WiE for <notmuch@notmuchmail.org>;\r
+ Thu, 26 Jan 2012 08:19:00 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+ [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 57CEB431FAE\r
+ for <notmuch@notmuchmail.org>; Thu, 26 Jan 2012 08:19:00 -0800 (PST)\r
+Received: by bkbzt19 with SMTP id zt19so692127bkb.26\r
+ for <notmuch@notmuchmail.org>; Thu, 26 Jan 2012 08:18:57 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ bh=4z8jf2u62haylsHcH8JKVLsfENc3bpPEPBtUZXSnIRQ=;\r
+ b=OYqrgeIvJsnwlY52uZNnGR2o/q7R4Z+UBefVhxMhqt/E1GyBaVsFlmIxfuz7TlHNd9\r
+ 0jE1WcO1WtGWggZwbZUr3m7ATHGaLuKOtkiHBOidW6bBqBD6tfrkkCXnN1jASm1cwnjQ\r
+ YrJVM3VzB79Sc3PuIy9FBDFGC3F4+1hdB8O6Y=\r
+Received: by 10.205.132.1 with SMTP id hs1mr939505bkc.45.1327594737597;\r
+ Thu, 26 Jan 2012 08:18:57 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+ by mx.google.com with ESMTPS id ew13sm9999244bkb.1.2012.01.26.08.18.56\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Thu, 26 Jan 2012 08:18:56 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/2] re-enable line wrapping and add some header bling\r
+In-Reply-To: <1327565871-19729-1-git-send-email-dme@dme.org>\r
+References: <1327565871-19729-1-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.11+116~ge6e10b8 (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Thu, 26 Jan 2012 20:17:49 +0400\r
+Message-ID: <87ty3iqvyq.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 26 Jan 2012 16:19:01 -0000\r
+\r
+Hi David.\r
+\r
+On Thu, 26 Jan 2012 08:17:49 +0000, David Edmondson <dme@dme.org> wrote:\r
+> By default, re-enable `visual-line-mode' in `notmuch-show-mode'. Do it\r
+> via a hook so that purists (ahem) can turn it off.\r
+> \r
+> Add some more processing of headers to make them look nice. Do it via\r
+> hooks so that unbelievers can turn it off.\r
+> \r
+\r
+I did not review the code, but here is a general comment for both\r
+patches (but especially for the first one). It would be nice to have a\r
+more detailed documentation for hooks. Docstring like "Enable Visual\r
+Line mode." for a function named `notmuch-show-turn-on-visual-line-mode'\r
+is near useless. It is quite obvious that the function enables\r
+visual-line-mode from it's name. And it does not give any information\r
+on why would someone actually want to use it. I do not remember what\r
+visual-line-mode is exactly, so to understand whether this hook is\r
+actually useful for me, I have to read visual-line-mode docs, think\r
+about how it helps in notmuch-show, read some code, perhaps, etc. I\r
+would argue that since the hook itself is trivial, the main point in\r
+having it is to provide a clearly documented solution for a common\r
+problem for those who do not know how to solve this problem right away.\r
+Currently, those who know what visual-line-mode is do not need this\r
+hook, because they can easily write their own, and those who do not know\r
+what visual-line-mode is can not use this hook, because it says nothing\r
+about why it is actually useful.\r
+\r
+Also, in addition to better docs, I would rename\r
+`notmuch-show-turn-on-visual-line-mode' to something that reflects what\r
+it does from user POV (like the other two hooks).\r
+\r
+Though, the fact that the hook is enabled by default makes the above\r
+arguments less important, I guess.\r
+\r
+Regards,\r
+ Dmitry\r
+\r
+> David Edmondson (2):\r
+> emacs: Re-enable line wrapping in `notmuch-show-mode'.\r
+> emacs: Add more processing of displayed headers.\r
+> \r
+> emacs/notmuch-show.el | 50 +++++++++++++++++++++++++++++++++++++++++-------\r
+> 1 files changed, 42 insertions(+), 8 deletions(-)\r
+> \r
+> -- \r
+> 1.7.8.3\r
+> \r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff