Re: [PATCH 0/5] Move to --with-excluded approach to excludes

diff --git a/a4/0239c3dee3db3ad01c31c162a95765473c8d74 b/a4/0239c3dee3db3ad01c31c162a95765473c8d74
new file mode 100644 (file)
index 0000000..c17cc55
--- /dev/null
+++ b/a4/0239c3dee3db3ad01c31c162a95765473c8d74
@@ -0,0 +1,155 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1FB58431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 10 Mar 2012 17:19:45 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 9k6Oc3oimzQY for <notmuch@notmuchmail.org>;\r
+       Sat, 10 Mar 2012 17:19:43 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 006A1431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 10 Mar 2012 17:19:42 -0800 (PST)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id 1747C66E011C;\r
+       Sat, 10 Mar 2012 17:19:40 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com\r
+       [76.174.137.84]) (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id 4EB6966E00F8;\r
+       Sat, 10 Mar 2012 17:19:36 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id C4646506; Sat, 10 Mar 2012 17:19:35 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/5] Move to --with-excluded approach to excludes\r
+In-Reply-To: <1330779918-28024-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1330779918-28024-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.11.1+266~gadb05cc (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 10 Mar 2012 17:19:33 -0800\r
+Message-ID: <87399g7x3u.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 11 Mar 2012 01:19:45 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Sat,  3 Mar 2012 13:05:13 +0000, Mark Walters <markwalters1009@gmail.com=\r
+> wrote:\r
+> This series implements the proposal in id:"87y5riuz7v.fsf@qmul.ac.uk"\r
+> to move to a consistent --with-excluded approach rather than the\r
+> previous --no-exclude approach. See the message there and its\r
+> descendants for discussion.\r
+>=20\r
+> The main user side change is that notmuch-search no longer defaults to\r
+> showing all the excluded threads with [0/n] but will do so if the user\r
+> says they want all the messages (i.e., by specifying --with-excluded).\r
+>=20\r
+> However, it makes everything consistent throughout the commandline and\r
+> lib interfaces. In all cases a "message" type search only returns the\r
+> non-excluded matches (unless --with-excluded is specified) and a\r
+> "thread" type search returns all messages (including excluded ones) in\r
+> threads that match in a non-excluded message.\r
+\r
+Hi, Mark.  Thanks so much for working on this.  This new solution seems\r
+like a good one.  It keeps the default as expected (excluded are\r
+actually excluded from all output), and the with-excluded option behaves\r
+intuitively.  Looks good to me.\r
+\r
+Unfortunately, as I discussed with you on irc today, there seems to be a\r
+problem with the patch series that is preventing it from working as\r
+expected.  The outputs of the following commands should agree, which\r
+they do:\r
+\r
+servo:~/src/notmuch/git [master] 0$ ./notmuch count --with-excluded tag:inb=\r
+ox\r
+51171\r
+servo:~/src/notmuch/git [master] 0$ ./notmuch search --output=3Dmessages --=\r
+with-excluded tag:inbox | wc -l\r
+51171\r
+servo:~/src/notmuch/git [master] 0$=20\r
+\r
+However, they should also agree in this case, which they don't:\r
+\r
+servo:~/src/notmuch/git [master] 0$ ./notmuch count tag:inbox\r
+115\r
+servo:~/src/notmuch/git [master] 0$ ./notmuch search --output=3Dmessages ta=\r
+g:inbox | wc -l\r
+51169\r
+servo:~/src/notmuch/git [master] 0$=20\r
+\r
+In this last case, notmuch search is outputting (some but not all(!))\r
+excluded messages when it shouldn't be.  However, if I use a more\r
+complicated search term, everything seems to be working fine:\r
+\r
+servo:~/src/notmuch/git [master] 0$ ./notmuch count tag:inbox and tag:unread\r
+0\r
+servo:~/src/notmuch/git [master] 0$ ./notmuch search --output=3Dmessages ta=\r
+g:inbox and tag:unread | wc -l\r
+0\r
+servo:~/src/notmuch/git [master] 0$ ./notmuch count --with-excluded tag:inb=\r
+ox and tag:unread\r
+47245\r
+servo:~/src/notmuch/git [master] 0$ ./notmuch search --output=3Dmessages --=\r
+with-excluded tag:inbox and tag:unread | wc -l\r
+47245\r
+servo:~/src/notmuch/git [master] 0$=20\r
+\r
+It also works if I give a single "from:" search term instead of a single\r
+"tag:" search term.  So it appears to be something about how the\r
+excluded query is constructed.\r
+\r
+I can't figure out where the problem is, although I'm still looking.  If\r
+anyone else can figure it out, please let us know.\r
+\r
+I would really like to get this series applied so that I can get back to\r
+following master!\r
+\r
+Thanks again for all the work.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPW/2lAAoJEO00zqvie6q8miAP/AyFCGUrvf1l2mlDLizt9x8I\r
+h9q+1c6JFDuGU6x18pSgHxEuKqjuIKvz/OC0ikwTocSKRhEXuzLKYa4NXkxVPM3M\r
+e8jxFLc9dJ/X6QSla22ATGnd403xVLGplvWCAOgsQABbuZ4JB5b5NxlG9+vbLP3A\r
+NRDCS4TrYzLi0qbL+C9H268+Bb+GqANnkHDtvVnti0M3Uhdor8w+ZWebChR3/gkA\r
+4rUEcgPEgpBllkpQph/SXIrtEK1uKL20R2rA1CKN8EPShTrCDR1YEW0vJpXAvT6I\r
++ZaNfL4Crn+D899dUhMI2visOJwn+JqmuQBca7z1guv04MsUqQOmrt+VQ3s9odUy\r
+rRqhh0bPEwb1euWwh5oN602AdgmFG90/21Xm2iWWq2c9jmko21OTHBodYGTSCZb5\r
+SDJIkmadIWUpiRm176aC0+VA2izDk4e1Th04gQ1GqjhywCus8NPTZoO9thDYyTUv\r
+fY3eok9ILIz+0M3S/7zUy/NSGKVMYAGizM5txfaONPQO4qn9eu6A0TWsBtO+26f/\r
+UKAcjMlv2+WVK8W8RhxQk188PpTAfYW3r0z1u3lSxfUegOJpcqYYfY7ul+riK1WF\r
+tQ0zly4VgTzBZgpNcc81ap62iUKf+Ph0CUG/rJDao31hrIGoIgonHT+Wd+0dmFcj\r
+Thc65LIQZZETnW8sE0MK\r
+=Fh3j\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r