Re: [PATCH v3 4/5] config: Add 'config list' command

diff --git a/83/4a362fc52e76ca67fea4a08b3994df5be75985 b/83/4a362fc52e76ca67fea4a08b3994df5be75985
new file mode 100644 (file)
index 0000000..29dae60
--- /dev/null
+++ b/83/4a362fc52e76ca67fea4a08b3994df5be75985
@@ -0,0 +1,101 @@
+Return-Path: <novalazy@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 96B58431FAF\r
+       for <notmuch@notmuchmail.org>; Tue, 10 Apr 2012 01:31:04 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id GxfpTsV5B4sn for <notmuch@notmuchmail.org>;\r
+       Tue, 10 Apr 2012 01:31:04 -0700 (PDT)\r
+Received: from mail-pz0-f45.google.com (mail-pz0-f45.google.com\r
+       [209.85.210.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 00859431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 10 Apr 2012 01:31:03 -0700 (PDT)\r
+Received: by dacx6 with SMTP id x6so6483837dac.18\r
+       for <notmuch@notmuchmail.org>; Tue, 10 Apr 2012 01:31:03 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=date:message-id:from:to:cc:subject:in-reply-to:references\r
+       :mime-version:content-type:content-disposition\r
+       :content-transfer-encoding;\r
+       bh=HOSbZa6VqfnX8Bcegk9WGqgfCD8BgV3jKj+jDT/piuQ=;\r
+       b=PmTrwE33WLDuUL1XVstK1KxAyF8WMQXxjXOSJU2z9+uOIHF+35EmrdUMP8hureeNXF\r
+       LRwbt2n/Ya4EHBqNYAeB93stNkOE7hytolm3qIdaMT+xf4eiylqfrsvDEtwTNHN41GWv\r
+       HvDkX/MqDVYRzkokJRO752b58C5DZ1bI9oqKLZ6d7BzV+3nfST8EH9DWgxF/3Z4tYG0f\r
+       ShROAsOJIgNl31S57CQ5jxRBi7/BD8eY4naTeiT3eAwRzr4c/2FSEBAurnJodaoIrQNp\r
+       XDVNFjhob44YFIoqzmM9wlIh7Kf3tEuddQQqpL3jFgOs12u3AB7jG4httFmYyMm2+vhi\r
+       RDDA==\r
+Received: by 10.68.213.104 with SMTP id nr8mr11786726pbc.91.1334046663095;\r
+       Tue, 10 Apr 2012 01:31:03 -0700 (PDT)\r
+Received: from localhost (215.42.233.220.static.exetel.com.au.\r
+       [220.233.42.215])\r
+       by mx.google.com with ESMTPS id r9sm17317748pbi.53.2012.04.10.01.31.00\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Tue, 10 Apr 2012 01:31:02 -0700 (PDT)\r
+Date: Tue, 10 Apr 2012 18:31:00 +1000\r
+Message-ID: <20120410183100.GJ8657@hili.localdomain>\r
+From: Peter Wang <novalazy@gmail.com>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>\r
+Subject: Re: [PATCH v3 4/5] config: Add 'config list' command\r
+In-Reply-To: <87r4vwhx0m.fsf@servo.finestructure.net>\r
+References: <1332282698-7951-1-git-send-email-novalazy@gmail.com>\r
+       <1333676886-9835-1-git-send-email-novalazy@gmail.com>\r
+       <1333676886-9835-5-git-send-email-novalazy@gmail.com>\r
+       <87r4vwhx0m.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: 8bit\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 10 Apr 2012 08:31:04 -0000\r
+\r
+On Tue, 10 Apr 2012 00:22:01 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> On Thu, Apr 05 2012, Peter Wang <novalazy@gmail.com> wrote:\r
+> \r
+> > -    if (strcmp (argv[0], "get") == 0)\r
+> > +    if (strcmp (argv[0], "get") == 0) {\r
+> > +  if (argc < 2) {\r
+> > +      fprintf (stderr, "Error: notmuch config get requires at least "\r
+> > +               "two arguments.\n");\r
+> > +      return 1;\r
+> > +  }\r
+> >    return notmuch_config_command_get (ctx, argv[1]);\r
+> > -    else if (strcmp (argv[0], "set") == 0)\r
+> > +    } else if (strcmp (argv[0], "set") == 0) {\r
+> > +  if (argc < 2) {\r
+> > +      fprintf (stderr, "Error: notmuch config set requires at least "\r
+> > +               "two arguments.\n");\r
+> > +      return 1;\r
+> > +  }\r
+> >    return notmuch_config_command_set (ctx, argv[1], argc - 2, argv + 2);\r
+> \r
+> But then these changes look unrelated to me.  They do look good\r
+> intentioned, though.  It's probably best to submit these changes in a\r
+> separate unrelated patch.\r
+\r
+Well, the only reason to duplicate the arity check is due to the\r
+introduction of the 'list' subcommand.  But I see that the error\r
+messages are wrong anyway, so I will separate out the changes in another\r
+patch series.\r
+\r
+Peter\r