Re: [PATCH] test: Fix HTML rendering test

diff --git a/de/dacb673bb9121473b1ea419d30f4ea674b4039 b/de/dacb673bb9121473b1ea419d30f4ea674b4039
new file mode 100644 (file)
index 0000000..a4cfc5f
--- /dev/null
+++ b/de/dacb673bb9121473b1ea419d30f4ea674b4039
@@ -0,0 +1,98 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 02E01431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Oct 2012 18:59:24 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id wHslWDA5x8fj for <notmuch@notmuchmail.org>;\r
+       Wed, 24 Oct 2012 18:59:23 -0700 (PDT)\r
+Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com\r
+       [209.85.220.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 71ABD431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Oct 2012 18:59:22 -0700 (PDT)\r
+Received: by mail-vc0-f181.google.com with SMTP id n11so1347890vch.26\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Oct 2012 18:59:21 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=7+cyEnxKJXqX4l/3vY/SbPzc0/cDNOfT9ugI75bqGfU=;\r
+       b=RmaQN3VDNniHBkUuhRkUVh7CrKwiTBMaJnbXnbNhDuNUr3otYd7DUFpLskwTpUObgI\r
+       xbExLDP8yNKzs3eR0obc9GsvezNZYdKMEJgmgA0OEozZ4YdKKMyl9AXbwf/Ur8OX/SVo\r
+       owt+xJkG3JjlpRmjsrx5ggkztIaMPFN5hTWX5+Mqi3TKaAB+RTwZI2CGuGERUvs68RR2\r
+       JpDLD1Pdw4B9r6028mrO+ur81bdTbd1RUETpo2bYUmhvRgvIVY0XKC7SGGzVg9UYLEoG\r
+       uNrdiK14rM2AspzAMItHY4VVSCTB0J/2uVAI2zFYzWUtZmOP86Vn/0TJrNQagmsODqOF\r
+       tGhg==\r
+Received: by 10.52.89.35 with SMTP id bl3mr23976701vdb.87.1351130361712;\r
+       Wed, 24 Oct 2012 18:59:21 -0700 (PDT)\r
+Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])\r
+       by mx.google.com with ESMTPS id f10sm17803564vdk.5.2012.10.24.18.59.18\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 24 Oct 2012 18:59:20 -0700 (PDT)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test: Fix HTML rendering test\r
+In-Reply-To: <1351109160-11105-1-git-send-email-amdragon@mit.edu>\r
+References: <1351109160-11105-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 24 Oct 2012 21:59:16 -0400\r
+Message-ID: <873913joqz.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 25 Oct 2012 01:59:25 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> The test designed to exercise Emacs' rendering of HTML emails\r
+> containing images inadvertently assumed w3m was available under Emacs\r
+> 23.  The real point of this test was to exercise Emacs 24's shr\r
+> renderer, so if shr isn't available, we now fall back to html2text,\r
+> which comes with Emacs.\r
+\r
+Hi! I'm eager to apply any patch here that makes this better. But this\r
+one doesn't fix it for me (24.1.1, although it seems to work with\r
+23.4.1). OUTPUT is "*\nsmiley " (no space after the asterisk or before\r
+the word smiley, but after). I see that this sed command is supposed to\r
+normalize things, but at least on my setup, it doesn't. I also see "nil"\r
+written to console, but I have no idea what that's about.\r
+\r
+More generally, I guess I don't understand exactly what this test is\r
+supposed to be exercising. The commit message says "the shr renderer",\r
+but what about it? In\r
+id:"1348941314-8377-4-git-send-email-amdragon@mit.edu" you write that\r
+using shr raised a void-variable error previously, so maybe we're making\r
+sure that error doesn't show up? In that case, even my semi-broken\r
+output is good enough.\r
+\r
+In a perfect world, test probably shouldn't succeed if shr isn't\r
+present, but should note that it wasn't run. Maybe the emacs lisp code\r
+can check for shr, and if it's not present, write "shr not present" to\r
+an output file, and the shell code can grep for that and then call\r
+test_skip if it sees it?\r
+\r
+Still, I'm excited that you're working on this so please let's get it\r
+fixed!\r
+\r
+Ethan\r