Re: [PATCH v5.2 3/7] reply: Add a JSON reply format.

diff --git a/25/df897eea8ef1518502ef9e0c1c7faf029b52de b/25/df897eea8ef1518502ef9e0c1c7faf029b52de
new file mode 100644 (file)
index 0000000..64277e0
--- /dev/null
+++ b/25/df897eea8ef1518502ef9e0c1c7faf029b52de
@@ -0,0 +1,114 @@
+Return-Path: <awg@xvx.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A7567429E42\r
+       for <notmuch@notmuchmail.org>; Fri, 17 Feb 2012 18:06:51 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id jMUUV3Lcb6wP for <notmuch@notmuchmail.org>;\r
+       Fri, 17 Feb 2012 18:06:51 -0800 (PST)\r
+Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com\r
+       [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D7A4E431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 17 Feb 2012 18:06:50 -0800 (PST)\r
+Received: by lahd3 with SMTP id d3so4636363lah.26\r
+       for <notmuch@notmuchmail.org>; Fri, 17 Feb 2012 18:06:47 -0800 (PST)\r
+Received-SPF: pass (google.com: domain of awg@xvx.ca designates 10.112.102.68\r
+       as permitted sender) client-ip=10.112.102.68; \r
+Authentication-Results: mr.google.com;\r
+       spf=pass (google.com: domain of awg@xvx.ca designates\r
+       10.112.102.68 as permitted sender) smtp.mail=awg@xvx.ca\r
+Received: from mr.google.com ([10.112.102.68])\r
+       by 10.112.102.68 with SMTP id fm4mr4145680lbb.7.1329530807982 (num_hops\r
+       = 1); Fri, 17 Feb 2012 18:06:47 -0800 (PST)\r
+MIME-Version: 1.0\r
+Received: by 10.112.102.68 with SMTP id fm4mr3476592lbb.7.1329530807890; Fri,\r
+       17 Feb 2012 18:06:47 -0800 (PST)\r
+Sender: awg@xvx.ca\r
+Received: by 10.112.90.20 with HTTP; Fri, 17 Feb 2012 18:06:47 -0800 (PST)\r
+X-Originating-IP: [96.52.216.56]\r
+In-Reply-To: <20120217170457.GE5991@mit.edu>\r
+References: <1329361957-28493-1-git-send-email-awg+notmuch@xvx.ca>\r
+       <1329361957-28493-4-git-send-email-awg+notmuch@xvx.ca>\r
+       <20120217170457.GE5991@mit.edu>\r
+Date: Fri, 17 Feb 2012 19:06:47 -0700\r
+X-Google-Sender-Auth: ptq-jNVK5uq372Qflo3rlU9g-OA\r
+Message-ID:\r
+ <CAMoJFUt_um9wTVaGEBm+9VmRcb1QZoOnbVCOrBQ7bfhjVQM9zg@mail.gmail.com>\r
+Subject: Re: [PATCH v5.2 3/7] reply: Add a JSON reply format.\r
+From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>\r
+To: Austin Clements <amdragon@mit.edu>\r
+Content-Type: text/plain; charset=ISO-8859-1\r
+Content-Transfer-Encoding: quoted-printable\r
+X-Gm-Message-State:\r
+ ALoCoQkaMo7HnxDrP8TL5I/LdjB6m9F4UbKcxWU9kmtr+vT6Ksq5EHrBqxnpxx3CvJrAngWLrElB\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 18 Feb 2012 02:06:51 -0000\r
+\r
+On Fri, Feb 17, 2012 at 10:04, Austin Clements <amdragon@mit.edu> wrote:\r
+> The first two patches LGTM. =A0A few nits in this one.\r
+\r
+Thanks for the review. A couple of points to discuss below; everything\r
+else I'll change for the next version.\r
+\r
+>> +void\r
+>> +format_part_json (const void *ctx, mime_node_t *node, notmuch_bool_t fi=\r
+rst);\r
+>> +\r
+>\r
+> This is the wrong place for this declaration, since it is not part of\r
+> the MIME node abstraction. =A0It should go somewhere above the /*\r
+> notmuch-config.c */ comment. =A0Above that, it's a bit of a jumble. =A0I'=\r
+d\r
+> probably put it right after notmuch_show_command.\r
+\r
+Agreed. I initially had it earlier in the file (with the other\r
+show-related functions), but moved it down since it requires the\r
+mime_node_t declaration. There are a couple of options: put in a\r
+pre-declaration of mime_node_t early in the file, or move the\r
+mime_node stuff to a separate header file and include it in\r
+notmuch-client.h. I lean toward the latter, since notmuch-client.h is\r
+getting very big as it is. Thoughts?\r
+\r
+>> + =A0 =A0if (notmuch_query_count_messages (query) !=3D 1) {\r
+>> + =A0 =A0 fprintf (stderr, "Error: search term did not match precisely o=\r
+ne message.\n");\r
+>> + =A0 =A0 return 1;\r
+>> + =A0 =A0}\r
+>\r
+> Technically count_messages does not have to be accurate, but since\r
+> this is the same thing notmuch-show does, it's probably fine for now.\r
+\r
+Ah, I didn't realize this. I just followed the show example.\r
+\r
+> Perhaps we should add proper handling of multi-message replies to\r
+> devel/TODO?\r
+\r
+Probably a good idea, although it means defining what proper handling\r
+of multi-message replies in the CLI means. Personally, I don't think\r
+it makes much sense to reply to multiple messages. The only place that\r
+functionality is actually used (AFAIK) is in notmuch-search.el, which,\r
+with my patches, throws an error if you try to reply to a thread\r
+containing multiple messages. In my mind, the correct behavior in that\r
+specific case is to create a reply to the last message in the thread,\r
+which is better handled in the emacs code than the CLI anyway.\r