Re: [PATCH 0/5] Rewrite mbox and raw show formats

diff --git a/57/4b94518db3797ebe0fd0bc65e3589777828fc5 b/57/4b94518db3797ebe0fd0bc65e3589777828fc5
new file mode 100644 (file)
index 0000000..b21d574
--- /dev/null
+++ b/57/4b94518db3797ebe0fd0bc65e3589777828fc5
@@ -0,0 +1,67 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 181B9431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  3 Mar 2012 00:18:54 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id L1i+clO0lxml for <notmuch@notmuchmail.org>;\r
+       Sat,  3 Mar 2012 00:18:52 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6DF9A431FAE\r
+       for <notmuch@notmuchmail.org>; Sat,  3 Mar 2012 00:18:52 -0800 (PST)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id B6E7C68055; Sat,  3 Mar 2012 10:18:50 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/5] Rewrite mbox and raw show formats\r
+In-Reply-To: <1330752025-2542-1-git-send-email-amdragon@mit.edu>\r
+References: <1330752025-2542-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.11.1+263~g4fa77d0 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 03 Mar 2012 10:18:50 +0200\r
+Message-ID: <m2399qrtat.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 03 Mar 2012 08:18:54 -0000\r
+\r
+On Sat,  3 Mar 2012 00:20:20 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> The show (rewrite) must go on.  These are the last two formats in\r
+> notmuch show proper; the only remaining format is the reply format.\r
+> \r
+> One of the ultimate goals of the show rewrite is to make raw actually\r
+> work (and probably to split it into two different formats).  This\r
+> series does not do that; it just ports the existing raw format.  I\r
+> plan to make the new raw formats once the rewrite is done.\r
+\r
+The whole patch series LGTM.\r
+\r
+On somewhat related note: should there be NOTMUCH_STATUS_FAILURE (= 1)\r
+in enum _notmuch_status (indicating unspecified failure). This would make\r
+lines like\r
+   return show_message (ctx, format, message, 0, params) != NOTMUCH_STATUS_SUCCESS;\r
+look better (or were/are all of these failures due to memory exhaustion) ?\r
+\r
+Tomi\r