--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 87319431FCF\r
+ for <notmuch@notmuchmail.org>; Sun, 15 Jul 2012 11:14:51 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id M7fR1RXSanXx for <notmuch@notmuchmail.org>;\r
+ Sun, 15 Jul 2012 11:14:50 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 9CA44431FBC\r
+ for <notmuch@notmuchmail.org>; Sun, 15 Jul 2012 11:14:50 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SqTLD-0002Wd-Ad; Sun, 15 Jul 2012 19:14:47 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SqTLC-000331-Ul; Sun, 15 Jul 2012 19:14:47 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 0/8] emacs: JSON-based search cleanups\r
+In-Reply-To: <87ipdorjja.fsf@awakening.csail.mit.edu>\r
+References: <1342140319-19859-1-git-send-email-amdragon@mit.edu>\r
+ <1342306940-7499-1-git-send-email-amdragon@mit.edu>\r
+ <87a9z1at22.fsf@qmul.ac.uk>\r
+ <87ipdorjja.fsf@awakening.csail.mit.edu>\r
+User-Agent: Notmuch/0.13.2+90~g84fa1ef (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 15 Jul 2012 19:14:44 +0100\r
+Message-ID: <87y5mkuc17.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 7f81cbcee7c29ced1a24c8172869462e (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 15 Jul 2012 18:14:51 -0000\r
+\r
+On Sun, 15 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> On Sun, 15 Jul 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+>> On Sun, 15 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+>>> This version swaps out the notmuch-search-do-results macro for a\r
+>>> higher-order function, notmuch-search-foreach-result. This requires\r
+>>> less squiting to understand and clearly distinguishes the arguments\r
+>>> passed in to the function from the arguments passed to the callback.\r
+>>> This version also updates the docstring for\r
+>>> notmuch-search-result-format to mention that multi-line result formats\r
+>>> work and how to enter them, and it adds a NEWS patch.\r
+>>\r
+>> Hello\r
+>>\r
+>> I am afraid I have found a minor (but reproducible) bug in the line\r
+>> re-drawing even with single line results. Find a search result with a\r
+>> partially elided author field and put the cursor after the ellipsis in\r
+>> that line. Then update the tags. The result gets redrawn with ellipsis\r
+>> written out in full. Re-redrawing with the cursor after the author field\r
+>> redraws the line with the keeping the ellipsis written out in full,\r
+>> whereas re-redrawing the line with cursor before the author field gets\r
+>> it written with the correct ellipsis.\r
+>\r
+> Arrrg, overlays.\r
+>\r
+> I can think of two ways to fix this. We could generate the author\r
+> elision overlays lazily (say, via jit-lock). This would have the added\r
+> benefit of eliminating what I think is the last quadratic factor in\r
+> building search buffers, but there are much easier ways to do that. Or,\r
+> I could scrap the insert-before-markers nonsense and manipulate point\r
+> directly in notmuch-search-update-result, with the caveat that the\r
+> little bit of support it had for doing sane things in some situations\r
+> involving save-excursions would be lost. Given that we never call\r
+> notmuch-search-update-result inside a save-excursion (precisely because\r
+> I couldn't reliably hit the narrow window of situations it could handle\r
+> when there were save-excursions involved), I'd lean toward the latter\r
+> option.\r
+\r
+I think I don't really know enough emacs/lisp to be able to say anything\r
+sensible. I think manipulating point directly seems good because then I\r
+think we can make sure things work in the multiline case too. \r
+\r
+I haven't yet worked out whether multiline is an amusing "oh look it works"\r
+or genuinely useful thing. I am leaning towards the latter as do often\r
+work on laptops with quite small screens and think I would like to see\r
+more about a smaller number of results.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
projects / notmuch-archives.git / commitdiff