RepoConfigLoader: handle ValueError from shlex

This will handle the issue reported in bug #383269, comment #5.

diff --git a/pym/portage/repository/config.py b/pym/portage/repository/config.py
index 5cfe82f4ac35f8bf1543c271c91852df6908ae3d..8b1e641b2c2d12eb06c470296b3934c44b8555b3 100644 (file)
--- a/pym/portage/repository/config.py
+++ b/pym/portage/repository/config.py
@@ -194,7 +194,14 @@ class RepoConfigLoader(object):
                if portdir:
                        portdir = normalize_path(portdir)
                        overlays.append(portdir)
-               port_ov = [normalize_path(i) for i in shlex_split(portdir_overlay)]
+               try:
+                       port_ov = [normalize_path(i) for i in shlex_split(portdir_overlay)]
+               except ValueError as e:
+                       #File "/usr/lib/python3.2/shlex.py", line 168, in read_token
+                       #       raise ValueError("No closing quotation")
+                       writemsg(_("!!! Invalid PORTDIR_OVERLAY:"
+                               " %s: %s\n") % (e, portdir_overlay), noiselevel=-1)
+                       port_ov = []
                overlays.extend(port_ov)
                default_repo_opts = {}
                if prepos['DEFAULT'].aliases is not None: