Re: [PATCH v2 0/2] Replying to HTML-only emails, v2

diff --git a/7a/46bc6d2920f91f50a296b973b35377ee4de5b1 b/7a/46bc6d2920f91f50a296b973b35377ee4de5b1
new file mode 100644 (file)
index 0000000..ddab5ac
--- /dev/null
+++ b/7a/46bc6d2920f91f50a296b973b35377ee4de5b1
@@ -0,0 +1,109 @@
+Return-Path: <awg@xvx.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1C93C431FC4\r
+       for <notmuch@notmuchmail.org>; Sun,  6 May 2012 07:29:41 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id p5LIpKDsHqYH for <notmuch@notmuchmail.org>;\r
+       Sun,  6 May 2012 07:29:40 -0700 (PDT)\r
+Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com\r
+       [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 065D8431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  6 May 2012 07:29:39 -0700 (PDT)\r
+Received: by lbbgk8 with SMTP id gk8so3287765lbb.26\r
+       for <notmuch@notmuchmail.org>; Sun, 06 May 2012 07:29:37 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=mime-version:sender:x-originating-ip:in-reply-to:references:date\r
+       :x-google-sender-auth:message-id:subject:from:to:cc:content-type\r
+       :x-gm-message-state;\r
+       bh=gHpdAv1/xw7S9awNt0lnCiswB7ZpZCqR0uyNFWqL3bA=;\r
+       b=DuBipOQZvKU3Z852JzzpCKGi8mBN/+98VTQg5ay3fnUbnATW67xurHCTivDwebqy3g\r
+       OtMtgCPLPGPgkECTPSpy+xxZQZy6c8HnV9V+NoKFDWD1WGjJ7ivqqvvA3XO1Kdbd/jjW\r
+       lpfCAEG77p9LauoxoKk4tHsx8gZH/U3NIQC7mJcclzhSZ/d4jjGCrS7ACptRAzXDH7v9\r
+       Frw0AIV73zmny+1l+3z+W46Ku5eH6Vc+SBAuLBDmuamaC19WjPIh89gHHWlOqq/aB+yi\r
+       65lQTz6cd650AWdysZvuayLKlvHQw4+q7wlRqPTNKkAnMLFeEKZtWDAl3ZbHJ5y5s5U+\r
+       zIIQ==\r
+MIME-Version: 1.0\r
+Received: by 10.112.29.99 with SMTP id j3mr5797998lbh.47.1336314576992; Sun,\r
+       06 May 2012 07:29:36 -0700 (PDT)\r
+Sender: awg@xvx.ca\r
+Received: by 10.112.82.163 with HTTP; Sun, 6 May 2012 07:29:36 -0700 (PDT)\r
+X-Originating-IP: [96.52.216.56]\r
+In-Reply-To: <878vh5bja3.fsf@zancas.localnet>\r
+References: <1336245869-32699-1-git-send-email-awg+notmuch@xvx.ca>\r
+       <878vh5bja3.fsf@zancas.localnet>\r
+Date: Sun, 6 May 2012 08:29:36 -0600\r
+X-Google-Sender-Auth: 479i6z4X5wRd9ZYNEKXoWGm1h1s\r
+Message-ID:\r
+ <CAMoJFUv6WcFKZVobqLk8tbmZ2GiXHh-fMhhukChBtXVK3brSxQ@mail.gmail.com>\r
+Subject: Re: [PATCH v2 0/2] Replying to HTML-only emails, v2\r
+From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>\r
+To: David Bremner <david@tethera.net>\r
+Content-Type: text/plain; charset=ISO-8859-1\r
+X-Gm-Message-State:\r
+ ALoCoQkn1DqNAdVdKSdY40RB4YZ5tNzzrxUnaKqiurox8yj8rEfNHWAesI0cZj2pmwXoc7GEO7wu\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 06 May 2012 14:29:41 -0000\r
+\r
+On Sun, May 6, 2012 at 6:12 AM, David Bremner <david@tethera.net> wrote:\r
+> I pushed this series, but it seems to have a test failure on the\r
+> buildbot (it's fine on my Debian wheezey box)\r
+>\r
+> http://buildbot.notmuchmail.org/builders/master/builds/198/steps/tests/logs/problems\r
+>\r
+> Maybe you and Tom could try to figure out what is different about his\r
+> environment?\r
+\r
+The failure is on the new HTML reply test, and the difference in the\r
+output is just indentation - the quoted HTML text has an extra three\r
+spaces at the beginning of each line. So, it's almost certainly a\r
+difference in emacs versions or packages. I'm running Ubuntu Oneiric\r
+with emacs 23.3.\r
+\r
+It looks like the relevant variable in mm is\r
+mm-text-html-renderer-alist, which defines various methods of parsing\r
+HTML. For me it's:\r
+\r
+((w3 . mm-inline-text-html-render-with-w3)\r
+ (w3m . mm-inline-text-html-render-with-w3m)\r
+ (w3m-standalone . mm-inline-text-html-render-with-w3m-standalone)\r
+ (links mm-inline-render-with-file mm-links-remove-leading-blank\r
+"links" "-dump" file)\r
+ (lynx mm-inline-render-with-stdin nil "lynx" "-dump" "-force_html"\r
+"-stdin" "-nolist")\r
+ (html2text mm-inline-render-with-function html2text))\r
+\r
+I get the behavior seen on the buildbot if the only option available\r
+on my machine is lynx, so I'm guessing that's what's happening.\r
+\r
+I'm not sure what the best option is for fixing this. A few possible options:\r
+\r
+* Only run the test if links, w3m, or w3m.el is available.\r
+* Make the test accept differences in whitespace.\r
+* Try to produce HTML for the test that renders the same in every method.\r
+\r
+Opinions from anyone?\r
+\r
+-- Adam\r