Re: [PATCH v2 2/3] reply: add message-id header

diff --git a/30/653226c718b413a2c0879f5da9bb9c4977cfee b/30/653226c718b413a2c0879f5da9bb9c4977cfee
new file mode 100644 (file)
index 0000000..cddd3eb
--- /dev/null
+++ b/30/653226c718b413a2c0879f5da9bb9c4977cfee
@@ -0,0 +1,127 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D89DB431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 06:09:57 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id l13iMvlKfhdv for <notmuch@notmuchmail.org>;\r
+       Wed, 18 Apr 2012 06:09:53 -0700 (PDT)\r
+Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com\r
+       [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id CB047431FBC\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 06:09:53 -0700 (PDT)\r
+Received: by qcsk26 with SMTP id k26so5587574qcs.26\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 06:09:53 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type:x-gm-message-state;\r
+       bh=b/jhujKXVpQTQt0isqAId3CzYg046PWF0BcCcgV5xFA=;\r
+       b=ZWPOOQhQi4oZFR6cie+zcStBpVzvj5cLQc4LMegoFEGqWaC/JTSFdYGlqLa42sTrqN\r
+       YGLl/2+TlDfmhU5P0XwuPwBJyq0HxyYXTDG5NSAlyNrLRcAj1YP+cGgMcJWi0+vQDuv3\r
+       xhuL3yLbXsD7mBWPY0D3jfTc1wUJE7u0NzEqXMq96VnOHPVbu/9gucFwTzhMO6aZy1Qt\r
+       vceUhByHowkVBIcz6uLGy3NadjHpy1ybWWJqFccQciun/WWYxZ3ZaM/JNyS531aZ31FE\r
+       f3H9McGRAvQEFtA5qkROUISQMcIVz82LH4PLJorOhTxFH0mdcFzDwLOqr5+08H2icJk8\r
+       gkvw==\r
+Received: by 10.229.136.203 with SMTP id s11mr820410qct.38.1334754593140;\r
+       Wed, 18 Apr 2012 06:09:53 -0700 (PDT)\r
+Received: from localhost (nikula.org. [92.243.24.172])\r
+       by mx.google.com with ESMTPS id gy7sm23801649qab.22.2012.04.18.06.09.51\r
+       (version=SSLv3 cipher=OTHER); Wed, 18 Apr 2012 06:09:52 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 2/3] reply: add message-id header\r
+In-Reply-To: <1334752753-23970-3-git-send-email-felipe.contreras@gmail.com>\r
+References: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com>\r
+       <1334752753-23970-3-git-send-email-felipe.contreras@gmail.com>\r
+User-Agent: Notmuch/0.11.1+222~ga47a98c (http://notmuchmail.org) Emacs/23.1.1\r
+       (i686-pc-linux-gnu)\r
+Date: Wed, 18 Apr 2012 13:09:50 +0000\r
+Message-ID: <87zka9b2zl.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQkaBkIbSXRQRHMKNTOjjiYkzdFGUQ5gpmG1J2tNXWQFzpnkLkOcDPWAUiQtyfZ0zrHDu4mv\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Apr 2012 13:09:58 -0000\r
+\r
+On Wed, 18 Apr 2012 15:39:12 +0300, Felipe Contreras <felipe.contreras@gmail.com> wrote:\r
+> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\r
+> ---\r
+>  notmuch-reply.c |   11 +++++++++++\r
+>  1 file changed, 11 insertions(+)\r
+> \r
+> diff --git a/notmuch-reply.c b/notmuch-reply.c\r
+> index 0949d9f..d796bb2 100644\r
+> --- a/notmuch-reply.c\r
+> +++ b/notmuch-reply.c\r
+> @@ -464,6 +464,8 @@ create_reply_message(void *ctx,\r
+>  {\r
+>      const char *subject, *from_addr = NULL;\r
+>      const char *in_reply_to, *orig_references, *references;\r
+> +    const char *message_id;\r
+> +    char *simple_from;\r
+>  \r
+>      /* The 1 means we want headers in a "pretty" order. */\r
+>      GMimeMessage *reply = g_mime_message_new (1);\r
+> @@ -488,6 +490,8 @@ create_reply_message(void *ctx,\r
+>      if (from_addr == NULL)\r
+>      from_addr = notmuch_config_get_user_primary_email (config);\r
+>  \r
+> +    simple_from = talloc_strdup (ctx, from_addr);\r
+> +\r
+>      from_addr = talloc_asprintf (ctx, "%s <%s>",\r
+>                               notmuch_config_get_user_name (config),\r
+>                               from_addr);\r
+> @@ -508,6 +512,13 @@ create_reply_message(void *ctx,\r
+>      g_mime_object_set_header (GMIME_OBJECT (reply),\r
+>                            "References", references);\r
+>  \r
+> +    message_id = talloc_asprintf (ctx, "<%lu-notmuch-%s>",\r
+> +                              time(NULL),\r
+> +                              simple_from);\r
+\r
+This duplicates the problem in "notmuch compose", hinting that you\r
+should probably have the message-id generation in one place only.\r
+\r
+I do wonder whether the emacs ui / message mode will add a duplicate\r
+message-id rather than override this.\r
+\r
+\r
+BR,\r
+Jani.\r
+\r
+> +    g_mime_object_set_header (GMIME_OBJECT (reply),\r
+> +                          "Message-ID", message_id);\r
+> +    talloc_free (simple_from);\r
+> +\r
+>      return reply;\r
+>  }\r
+>  \r
+> -- \r
+> 1.7.10\r
+> \r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r