--- /dev/null
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id BED4E431FB6\r
+ for <notmuch@notmuchmail.org>; Fri, 10 Feb 2012 02:18:03 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id iC61gopl7lDM for <notmuch@notmuchmail.org>;\r
+ Fri, 10 Feb 2012 02:17:57 -0800 (PST)\r
+Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com\r
+ [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 10B6B431FAE\r
+ for <notmuch@notmuchmail.org>; Fri, 10 Feb 2012 02:17:57 -0800 (PST)\r
+Received: by qcsd17 with SMTP id d17so1764344qcs.26\r
+ for <notmuch@notmuchmail.org>; Fri, 10 Feb 2012 02:17:55 -0800 (PST)\r
+Received: by 10.229.106.221 with SMTP id y29mr3866826qco.88.1328869075300;\r
+ Fri, 10 Feb 2012 02:17:55 -0800 (PST)\r
+Received: from localhost (nikula.org. [92.243.24.172])\r
+ by mx.google.com with ESMTPS id j17sm11969800qaj.9.2012.02.10.02.17.53\r
+ (version=SSLv3 cipher=OTHER); Fri, 10 Feb 2012 02:17:54 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 1/2] emacs: support defining a list of alternative\r
+ parts to show\r
+In-Reply-To: <cunobt7ypdx.fsf@hotblack-desiato.hh.sledj.net>\r
+References: <cover.1328719309.git.jani@nikula.org>\r
+ <ab777cf0fa83778d3399ac52094df9230738819d.1328798471.git.jani@nikula.org>\r
+ <cunobt7ypdx.fsf@hotblack-desiato.hh.sledj.net>\r
+User-Agent: Notmuch/0.11.1+168~g25a7ceb (http://notmuchmail.org) Emacs/23.1.1\r
+ (i686-pc-linux-gnu)\r
+Date: Fri, 10 Feb 2012 10:17:52 +0000\r
+Message-ID: <87ipjff0vj.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQlyn+/0q2IQeatL5U14IgtAMiWagB+XL0SGaZ3OyjMJbp7UMYd6uxZY0iArv/lhPEkiKtFG\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 10 Feb 2012 10:18:03 -0000\r
+\r
+On Fri, 10 Feb 2012 10:05:46 +0000, David Edmondson <dme@dme.org> wrote:\r
+> On Thu, 9 Feb 2012 14:46:02 +0000, Jani Nikula <jani@nikula.org> wrote:\r
+> > Make notmuch-show-all-multipart/alternative-parts accept a list of\r
+> > regexps to match the part types to determine which parts to show in\r
+> > addition to the preferred types. This allows the user to force display\r
+> > some alternative part types while normally showing just the preferred\r
+> > ones.\r
+> > \r
+> > Signed-off-by: Jani Nikula <jani@nikula.org>\r
+> > ---\r
+> > emacs/notmuch-show.el | 23 ++++++++++++++++++-----\r
+> > 1 files changed, 18 insertions(+), 5 deletions(-)\r
+> > \r
+> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> > index 24fde05..5f643f1 100644\r
+> > --- a/emacs/notmuch-show.el\r
+> > +++ b/emacs/notmuch-show.el\r
+> > @@ -94,10 +94,20 @@ any given message."\r
+> > :group 'notmuch-show\r
+> > :group 'notmuch-hooks)\r
+> > \r
+> > -;; Mostly useful for debugging.\r
+> > (defcustom notmuch-show-all-multipart/alternative-parts t\r
+> > - "Should all parts of multipart/alternative parts be shown?"\r
+> > - :type 'boolean\r
+> > + "Which parts of multipart/alternative should be shown?\r
+> > +\r
+> > +This variable determines which parts of multipart/alternative\r
+> > +should be displayed. Set to t (the default) to show all\r
+> > +parts. Set to nil to only show the preferred parts. Set to a list\r
+> > +of regexps to display the preferred parts, and parts matching any\r
+> > +of the regexps, for example:\r
+> \r
+> "If set to `t' (the default), all sub-parts of a\r
+> \"multipart/alternative\" part are shown. If set to `nil', only the\r
+> preferred part is shown. If set to a list of regexps, the preferred part\r
+> and all parts whose type matches one of the regexps will be shown."\r
+\r
+Thank you; this is the best kind of comment on improving documentation.\r
+\r
+> \r
+> > +\r
+> > + (setq notmuch-show-all-multipart/alternative-parts\r
+> > + '(\"text/.*calendar\" \"text/html\"))"\r
+> > + :type '(choice (const :tag "Show all parts" t)\r
+> > + (const :tag "Show preferred parts" nil)\r
+> > + (repeat :tag "Show preferred and parts matching regexps" string))\r
+> > :group 'notmuch-show)\r
+> > \r
+> > (defcustom notmuch-show-indent-messages-width 1\r
+> > @@ -513,8 +523,11 @@ current buffer, if possible."\r
+> > ;; should be chosen if there are more than one that match?\r
+> > (mapc (lambda (inner-part)\r
+> > (let ((inner-type (plist-get inner-part :content-type)))\r
+> > - (if (or notmuch-show-all-multipart/alternative-parts\r
+> > - (string= chosen-type inner-type))\r
+> > + (if (or (equal notmuch-show-all-multipart/alternative-parts t)\r
+> > + (string= chosen-type inner-type)\r
+> > + (and\r
+> > + notmuch-show-all-multipart/alternative-parts\r
+> > + (equal (string-match-p (mapconcat (lambda (s) (format "^%s$" s)) notmuch-show-all-multipart/alternative-parts "\\|") inner-type) 0)))\r
+> \r
+> This is quite messy. How about we add a general helper to "notmuch-lib.el":\r
+> \r
+> (defun notmuch-string-match-list-p (regexps string)\r
+> (loop for regexp in regexps\r
+> if (string-match-p regexp string)\r
+> return t))\r
+> \r
+> and then write:\r
+> \r
+> (if (or (string= chosen-type inner-type)\r
+> (equal notmuch-show-all-multipart/alternative-parts t)\r
+> (notmuch-string-match-list-p notmuch-show-all-multipart/alternative-parts inner-type))\r
+> ...\r
+> \r
+> ?\r
+\r
+*sigh* I was so happy to make that mapconcat work. And I guess soon I'll\r
+have to add "code by dme" in this patch too. ;)\r
+\r
+But you're right, it will be more readable that way. v3 in a few days.\r
+\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+> \r
+> > (notmuch-show-insert-bodypart msg inner-part depth)\r
+> > (notmuch-show-insert-part-header (plist-get inner-part :id) inner-type inner-type nil " (not shown)"))))\r
+> > inner-parts)\r
+> > -- \r
+> > 1.7.1\r
+> > \r
projects / notmuch-archives.git / commitdiff