--- /dev/null
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0A2EB431FAF\r
+ for <notmuch@notmuchmail.org>; Tue, 22 Jan 2013 12:05:20 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id wM3yW1+qhuh1 for <notmuch@notmuchmail.org>;\r
+ Tue, 22 Jan 2013 12:05:19 -0800 (PST)\r
+Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com\r
+ [209.85.217.178]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 2680B431FAE\r
+ for <notmuch@notmuchmail.org>; Tue, 22 Jan 2013 12:05:19 -0800 (PST)\r
+Received: by mail-lb0-f178.google.com with SMTP id n1so3104434lba.23\r
+ for <notmuch@notmuchmail.org>; Tue, 22 Jan 2013 12:05:16 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=google.com; s=20120113;\r
+ h=x-received:from:to:subject:in-reply-to:references:user-agent:date\r
+ :message-id:mime-version:content-type:x-gm-message-state;\r
+ bh=Ly/rtQouJk5D/J3PT7W/8PdqNdFYTdbAu6XHhb7Jseo=;\r
+ b=X5mLXYHzjBKC3t/mk+kJELvnjJQ5YPE495ysXEdNFJ42QIj9ara8snb6z/hfwtsW6Y\r
+ aP2myNEDWPxZKyK2l3lAVwwqK2NJNVRENhs0KVFq1Ag4Cp5+wtCPE6Jb+IKU4eC2vmUA\r
+ XnmXm2dCUEbwHHeHdMqpeSiQnTGfocO6ZoPQmUz/7rrGqZX7ncd51qiTPPA0jgK0evTM\r
+ cxFaWi8yhXKo1oys3jbqA8dPze70gB78WX/UfOrRbr2gFjNshlKRVwhpCyzFSyALX50W\r
+ RRhg07mcsn/1CGrvLLw5FMBnRYWtiOtGp0C+3D99yV3zZbfglFRuoKnir0LH8Ht1hGva\r
+ jZVA==\r
+X-Received: by 10.112.82.202 with SMTP id k10mr9881137lby.22.1358885116256;\r
+ Tue, 22 Jan 2013 12:05:16 -0800 (PST)\r
+Received: from localhost (dsl-hkibrasgw4-50df51-27.dhcp.inet.fi.\r
+ [80.223.81.27])\r
+ by mx.google.com with ESMTPS id hc20sm7441096lab.11.2013.01.22.12.05.14\r
+ (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+ Tue, 22 Jan 2013 12:05:15 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 00/20] insert command\r
+In-Reply-To: <1358643004-14522-1-git-send-email-novalazy@gmail.com>\r
+References: <1358643004-14522-1-git-send-email-novalazy@gmail.com>\r
+User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/24.2.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 22 Jan 2013 22:05:15 +0200\r
+Message-ID: <87zk01htl0.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Gm-Message-State:\r
+ ALoCoQlD3lFI8b0vG66zA/9T1/QLU73qrqSP7WBQUUR7ejDZKg0v7nuifgNkXJuds2fUl/v4WJmU\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 22 Jan 2013 20:05:20 -0000\r
+\r
+On Sun, 20 Jan 2013, Peter Wang <novalazy@gmail.com> wrote:\r
+> This mainly addresses review comments from v2\r
+> and rebases on top of tag-util.c.\r
+\r
+Hi Peter, I have some interest in seeing this get merged. To get that\r
+done in a timely manner, my suggestion is to do this in two steps. Drop\r
+the --folder and --create-folder options and the related code for now,\r
+and submit them as another series once the first part has been\r
+merged. It will be faster to iterate the first part, and we can dodge\r
+some of the issues in the --folder and --create-folder options for now.\r
+\r
+This is just my personal opinion, and it's up to you whether you do this\r
+or not. Let's just call it a hunch saying it'll be faster this way. ;)\r
+\r
+The patches would be rearranged as follows:\r
+\r
+> Peter Wang (20):\r
+> tag-util: do not reset list in parse_tag_command_line\r
+> tag-util: move out 'tag' command-line checks\r
+\r
+Keep the above separate, and make them the first preparatory patches.\r
+\r
+> cli: add stub for insert command\r
+> insert: open Maildir tmp file\r
+> insert: copy stdin to Maildir tmp file\r
+> insert: move file from Maildir tmp to new\r
+> insert: add new message to database\r
+> insert: apply default tags to new message\r
+> insert: parse and apply command-line tag operations\r
+> insert: fsync after writing tmp file\r
+> insert: trap SIGINT and clean up\r
+> insert: add copyright line from notmuch-deliver\r
+\r
+Squash all of the above together into one patch. I will send a review of\r
+these based on this version of the series.\r
+\r
+> insert: support --folder option\r
+> insert: prevent writes outside Maildir hierarchy\r
+> insert: add --create-folder option\r
+> insert: fsync new directory after rename\r
+> insert: fsync parent directory after mkdir\r
+\r
+Drop these for now.\r
+\r
+> man: document 'insert' command\r
+> man: reference notmuch-insert.1\r
+> test: add tests for insert\r
+\r
+Keep these separate as they are, but update to reflect the above.\r
+\r
+Thoughts?\r
+\r
+\r
+BR,\r
+Jani.\r
+\r
+>\r
+> Makefile.local | 1 +\r
+> man/Makefile.local | 1 +\r
+> man/man1/notmuch-config.1 | 4 +-\r
+> man/man1/notmuch-count.1 | 4 +-\r
+> man/man1/notmuch-dump.1 | 4 +-\r
+> man/man1/notmuch-insert.1 | 59 +++++\r
+> man/man1/notmuch-new.1 | 4 +-\r
+> man/man1/notmuch-reply.1 | 3 +-\r
+> man/man1/notmuch-restore.1 | 3 +-\r
+> man/man1/notmuch-search.1 | 3 +-\r
+> man/man1/notmuch-show.1 | 3 +-\r
+> man/man1/notmuch-tag.1 | 3 +-\r
+> man/man1/notmuch.1 | 3 +-\r
+> man/man5/notmuch-hooks.5 | 4 +-\r
+> man/man7/notmuch-search-terms.7 | 3 +-\r
+> notmuch-client.h | 3 +\r
+> notmuch-insert.c | 482 ++++++++++++++++++++++++++++++++++++++++\r
+> notmuch-tag.c | 10 +\r
+> notmuch.c | 3 +\r
+> tag-util.c | 12 -\r
+> tag-util.h | 2 +\r
+> test/insert | 106 +++++++++\r
+> test/notmuch-test | 1 +\r
+> 23 files changed, 692 insertions(+), 29 deletions(-)\r
+> create mode 100644 man/man1/notmuch-insert.1\r
+> create mode 100644 notmuch-insert.c\r
+> create mode 100755 test/insert\r
+>\r
+> -- \r
+> 1.7.12.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff