readme.gentoo-r1.eclass: Do not inherit eutils.
authorUlrich Müller <ulm@gentoo.org>
Sat, 19 Dec 2015 14:15:05 +0000 (15:15 +0100)
committerUlrich Müller <ulm@gentoo.org>
Mon, 21 Dec 2015 07:52:26 +0000 (08:52 +0100)
This was only needed in readme.gentoo_create_doc() for a single call
of eshopts_{push,pop}. Replace it by saving the set of options in a
variable. Die if writing the temp file in readme.gentoo_create_doc()
fails.

eclass/readme.gentoo-r1.eclass

index c07665072c2ba864f8f6c73705cf7a584766a53b..07320c0e08bd8309425fd4437219c36a50127bb2 100644 (file)
@@ -21,8 +21,6 @@
 if [[ -z ${_README_GENTOO_ECLASS} ]]; then
 _README_GENTOO_ECLASS=1
 
-inherit eutils
-
 case "${EAPI:-0}" in
        0|1|2|3)
                die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}"
@@ -61,15 +59,16 @@ readme.gentoo_create_doc() {
        debug-print-function ${FUNCNAME} "${@}"
 
        if [[ -n "${DOC_CONTENTS}" ]]; then
-               eshopts_push
-               set -f
                if [[ -n "${DISABLE_AUTOFORMATTING}" ]]; then
-                       echo "${DOC_CONTENTS}" > "${T}"/README.gentoo
+                       echo "${DOC_CONTENTS}" > "${T}"/README.gentoo || die
                else
+                       local saved_flags=$-
+                       set -f                          # disable filename expansion in echo arguments
                        echo -e ${DOC_CONTENTS} | fold -s -w 70 \
                                | sed 's/[[:space:]]*$//' > "${T}"/README.gentoo
+                       assert
+                       set +f -${saved_flags}
                fi
-               eshopts_pop
        elif [[ -f "${FILESDIR}/README.gentoo-${SLOT%/*}" ]]; then
                cp "${FILESDIR}/README.gentoo-${SLOT%/*}" "${T}"/README.gentoo || die
        elif [[ -f "${FILESDIR}/README.gentoo${README_GENTOO_SUFFIX}" ]]; then