--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 589CC431FAF\r
+ for <notmuch@notmuchmail.org>; Wed, 24 Oct 2012 19:11:15 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id QZNcilWodVP3 for <notmuch@notmuchmail.org>;\r
+ Wed, 24 Oct 2012 19:11:14 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU\r
+ [18.7.68.36])\r
+ by olra.theworths.org (Postfix) with ESMTP id A5B24431FAE\r
+ for <notmuch@notmuchmail.org>; Wed, 24 Oct 2012 19:11:14 -0700 (PDT)\r
+X-AuditID: 12074424-b7fce6d000000925-f3-50889fc11f25\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+ by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 83.4F.02341.1CF98805; Wed, 24 Oct 2012 22:11:14 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q9P2BDtN031262; \r
+ Wed, 24 Oct 2012 22:11:13 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q9P2BBxi001864\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Wed, 24 Oct 2012 22:11:12 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1TRCud-0007Oe-Iy; Wed, 24 Oct 2012 22:11:11 -0400\r
+Date: Wed, 24 Oct 2012 22:11:11 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+Subject: Re: [PATCH] test: Fix HTML rendering test\r
+Message-ID: <20121025021111.GW14861@mit.edu>\r
+References: <1351109160-11105-1-git-send-email-amdragon@mit.edu>\r
+ <873913joqz.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <873913joqz.fsf@betacantrips.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42IRYrdT1z00vyPA4OQ+Jos7PbtYLK7fnMns\r
+ wOSxc9Zddo9nq24xBzBFcdmkpOZklqUW6dslcGUcP7aUteCuUMW0k7PYGxh/8XUxcnJICJhI\r
+ 3PpwihXCFpO4cG89WxcjF4eQwD5Gid/vfjJDOBsYJX52fGSEcE4ySTy7vI8JwlnCKHH/13Kg\r
+ Hg4OFgFVic7+FJBRbAIaEtv2L2cECYsImEr8PagOEmYWkJb49ruZCcQWFjCSuHT+GJjNK6Aj\r
+ 8XbaI3aQciGBFIkr/QUQYUGJkzOfsEC0aknc+PeSCaQEZMzyfxwgYU4BPYlzj5+zgdiiAioS\r
+ U05uY5vAKDQLSfcsJN2zELoXMDKvYpRNya3SzU3MzClOTdYtTk7My0st0jXXy80s0UtNKd3E\r
+ CA5pF5UdjM2HlA4xCnAwKvHwHvDoCBBiTSwrrsw9xCjJwaQkyrt0DlCILyk/pTIjsTgjvqg0\r
+ J7X4EKMEB7OSCO/kB+0BQrwpiZVVqUX5MClpDhYlcd7rKTf9hQTSE0tSs1NTC1KLYLIyHBxK\r
+ ErxT5gENFSxKTU+tSMvMKUFIM3FwggznARpuD1LDW1yQmFucmQ6RP8Woy3H0zdyHjEIsefl5\r
+ qVLivNNBigRAijJK8+DmwFLRK0ZxoLeEeetBqniAaQxu0iugJUxAS8x5WkGWlCQipKQaGFk2\r
+ 8VvtOVVlVxBj1zdZRu5Xen7Yi4lfAiMfLXm9MaY/MmIxa/7je92dEbN8X37zE74z4zKz5F7V\r
+ SSEpcya9jhfbzd9r68pSrNiffic+5pBMs+uJ4If8E6s3hp4O9ihubZZw/RQuvSBAyURsdlyd\r
+ ctDBnJUv9pZPOb9yZqVvr5fHp7fNK0UDlViKMxINtZiLihMBZ+bQTSADAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 25 Oct 2012 02:11:15 -0000\r
+\r
+Quoth Ethan Glasser-Camp on Oct 24 at 9:59 pm:\r
+> Austin Clements <amdragon@MIT.EDU> writes:\r
+> \r
+> > The test designed to exercise Emacs' rendering of HTML emails\r
+> > containing images inadvertently assumed w3m was available under Emacs\r
+> > 23. The real point of this test was to exercise Emacs 24's shr\r
+> > renderer, so if shr isn't available, we now fall back to html2text,\r
+> > which comes with Emacs.\r
+> \r
+> Hi! I'm eager to apply any patch here that makes this better. But this\r
+> one doesn't fix it for me (24.1.1, although it seems to work with\r
+> 23.4.1). OUTPUT is "*\nsmiley " (no space after the asterisk or before\r
+> the word smiley, but after). I see that this sed command is supposed to\r
+> normalize things, but at least on my setup, it doesn't. I also see "nil"\r
+> written to console, but I have no idea what that's about.\r
+\r
+Emacs seems to have as many ways to convert HTML to text as there are\r
+people trying to run this test. What's the value of\r
+mm-text-html-renderer for you in Emacs 24?\r
+\r
+> More generally, I guess I don't understand exactly what this test is\r
+> supposed to be exercising. The commit message says "the shr renderer",\r
+> but what about it? In\r
+> id:"1348941314-8377-4-git-send-email-amdragon@mit.edu" you write that\r
+> using shr raised a void-variable error previously, so maybe we're making\r
+> sure that error doesn't show up? In that case, even my semi-broken\r
+> output is good enough.\r
+\r
+Yes; this is essentially a regression test. I would prefer not to\r
+catch exceptions in this test because I think we'll eventually start\r
+eating exceptions in body renderers to prevent them from breaking the\r
+rest of the show buffer. We could check that the output contains the\r
+word "smiley" somewhere as evidence that it probably didn't crash.\r
+\r
+> In a perfect world, test probably shouldn't succeed if shr isn't\r
+> present, but should note that it wasn't run. Maybe the emacs lisp code\r
+> can check for shr, and if it's not present, write "shr not present" to\r
+> an output file, and the shell code can grep for that and then call\r
+> test_skip if it sees it?\r
+\r
+That's another possibility. Unfortunately, skipped tests seem rather\r
+heavyweight in the test infrastructure and get reported loudly, which\r
+would affect anyone running the tests under Emacs 23.\r
+\r
+> Still, I'm excited that you're working on this so please let's get it\r
+> fixed!\r
+> \r
+> Ethan\r
projects / notmuch-archives.git / commitdiff