Re: [PATCH 1/7] Split notmuch_database_close into two functions

diff --git a/e0/82c9279fba0c1110d87b9fe5b2fcf4cb9422d5 b/e0/82c9279fba0c1110d87b9fe5b2fcf4cb9422d5
new file mode 100644 (file)
index 0000000..954dc09
--- /dev/null
+++ b/e0/82c9279fba0c1110d87b9fe5b2fcf4cb9422d5
@@ -0,0 +1,72 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 682DA431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 31 Mar 2012 10:29:11 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id u-Iw8Pkm4bpu for <notmuch@notmuchmail.org>;\r
+       Sat, 31 Mar 2012 10:29:09 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 48DA6431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 31 Mar 2012 10:29:09 -0700 (PDT)\r
+Received: from fctnnbsc30w-142166230117.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([142.166.230.117] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)\r
+       (Exim 4.72) (envelope-from <bremner@unb.ca>)\r
+       id 1SE26s-0004J5-Gy; Sat, 31 Mar 2012 14:29:06 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.77)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1SE26n-0002RS-6i; Sat, 31 Mar 2012 14:29:01 -0300\r
+From: David Bremner <bremner@unb.ca>\r
+To: Mark Walters <markwalters1009@gmail.com>,\r
+       Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/7] Split notmuch_database_close into two functions\r
+In-Reply-To: <87fwcopu5g.fsf@qmul.ac.uk>\r
+References:\r
+ <1332291311-28954-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <1332291311-28954-2-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <87fwcopu5g.fsf@qmul.ac.uk>User-Agent: Notmuch/0.12+70~g46e73fe\r
+       (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu)\r
+Date: Sat, 31 Mar 2012 14:29:01 -0300\r
+Message-ID: <87sjgo1xya.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 31 Mar 2012 17:29:11 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> The first is a concern that if we change the library functions we should\r
+> update the library version otherwise out of tree users won't know which\r
+> to call. \r
+\r
+This is not such a big deal. We can update the SONAME of the library so\r
+that old code will continute to dynamically link to the old version of\r
+the library. Nothing [1] will magically make the old code work with the\r
+new library if we change the API; that is just the way things go,\r
+occasionally APIs and/or ABIs change.\r
+\r
+[1] Well maybe symbol versioning. I don't fully understand that, but I\r
+suspect it is more trouble than it is worth.\r