Re: [PATCH v3 0/8] emacs: JSON-based search cleanups

diff --git a/a2/465ed8dbd70638b6e47f180088fecf311b4c89 b/a2/465ed8dbd70638b6e47f180088fecf311b4c89
new file mode 100644 (file)
index 0000000..301c7c3
--- /dev/null
+++ b/a2/465ed8dbd70638b6e47f180088fecf311b4c89
@@ -0,0 +1,116 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A6380431FBF\r
+       for <notmuch@notmuchmail.org>; Sun, 15 Jul 2012 14:14:50 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id hFov3JDKzCAU for <notmuch@notmuchmail.org>;\r
+       Sun, 15 Jul 2012 14:14:50 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1B900431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 15 Jul 2012 14:14:50 -0700 (PDT)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id 9B3D32E50BAA;\r
+       Sun, 15 Jul 2012 14:14:47 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (rrcs-24-199-56-74.west.biz.rr.com\r
+       [24.199.56.74]) (Authenticated sender: jrollins)\r
+       by fire-doxen-submit (Postfix) with ESMTP id C982F2E50485;\r
+       Sun, 15 Jul 2012 14:14:43 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 746F6688; Sun, 15 Jul 2012 14:14:42 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Mark Walters <markwalters1009@gmail.com>,\r
+       Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 0/8] emacs: JSON-based search cleanups\r
+In-Reply-To: <87fw8ttob9.fsf@qmul.ac.uk>\r
+References: <1342140319-19859-1-git-send-email-amdragon@mit.edu>\r
+       <1342306940-7499-1-git-send-email-amdragon@mit.edu>\r
+       <87fw8ttob9.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.13.2+89~g9ab91ad (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 15 Jul 2012 14:14:40 -0700\r
+Message-ID: <87a9z0zpz3.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 15 Jul 2012 21:14:50 -0000\r
+\r
+--=-=-=\r
+\r
+On Sun, Jul 15 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> However, there are some problems with multiline search results (see\r
+> below) so I think we should either fix these or just downplay this new\r
+> functionality by, for example, removing the comments on newlines from\r
+> the defcustom and saying in NEWS that the feature is experimental/not\r
+> complete or similar. (NEWS could say how to enter newlines in the\r
+> defcustom)\r
+>\r
+> With this minor comment on the documentation my criticisms should not\r
+> hold up this excellent series.\r
+\r
+I agree that multi-line support needs a little bit more work before it's\r
+ready for prime time.  I'll keep experimenting with it as well and see\r
+if I can uncover any other issues.\r
+\r
+But I definitely also agree that that work should *not* hold up this\r
+patch series, as it adds plenty of other benefits.\r
+\r
+> Examples of "incompleteness": these are rather more personal but it\r
+> seems odd to me to highlight one line rather than one result in the\r
+> buffer. Similarly I would expect <up> <down> to scroll up or down by\r
+> one result rather than one line.\r
+\r
+Highlighting the entire entry should definitely be fixed, since\r
+otherwise it can be hard to see which of the other lines is associated\r
+with the current entry.\r
+\r
+I also notice that the author field munging causes some weird behaviors.\r
+Certain formatter strings can cause it to break.  If we can get that\r
+fixed it might be nice to have a similar functionality for the subject\r
+field, which can also be really long.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJQAzLAAAoJEO00zqvie6q8DPcP/2jLHR37CHVl0n8FUlvw1I+0\r
+ASrtz2PnytHP5LtEWFFYCdY3lCeCdI728SbcX0cqr9eb+zFyUW/F07RZ01/exCn3\r
+2QC+lUwHT7F4WlCqNTnvG1zAPgHcTmi+twZKibo/u8U20wDxBh+UO78My/dVUQoa\r
+TYesodWSVOrPnMptXc12V7fS/lk6t4G6hLK3qGvH4hWtrk3eUzcGXt3kKiSioQio\r
+hBBdNnQPa64jXy/kUS7y+wFWnb4N5Zsgg/pRgdtF1LEG8ECXifHRHt3OFdTKihd+\r
+x5V0CeqxmQFsXtHaqpEgQTaTl6EQaYvfvGdk0Lwhqk1Rd+rtKZhtU6JSy+3PhZ+N\r
+lfNibIRBwhVoT9ZSWjaniYzooJ0IMDLmISLB8NmmsO59br2Lw+98Tz53JFCHXCHY\r
+L7+hL23/AgqjRFTBGuw1gt32rcn+W1mQ+oMqYGGRd4nG0wruiu+eOFTu+dzKqLCa\r
+YsVeKWVIXfnIUftr2uHf9NLSd3nsa8E97EgVoOGGC7kOOJvYB7oXatpYZtuFxWcg\r
+4JL7vsJLVi9/nXBOqijYi9qbRgGbBOihEoKqqbfSVe6W/l9aXV4B+gM51zqibh7l\r
+W2ofo8E4gbYPHHaKvjnnGfsVh2XRNRWA4+eqF8HR7XkEcTd3xO/7cinkAbj0n7Hi\r
+mxMO9vxS2vYP7AKpJy1C\r
+=EQ+5\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r