app-emulation/wine-vanilla: QA, use failglob

Addresses some of the issues in #615218

Package-Manager: Portage-2.3.3, Repoman-2.3.1

diff --git a/app-emulation/wine-vanilla/wine-vanilla-2.0.ebuild b/app-emulation/wine-vanilla/wine-vanilla-2.0.ebuild
index 2798232a3dc469acdda1434a49b5c1fcf805c661..534dc09280413ac6467fbfded8910946de1f4fdb 100644 (file)
--- a/app-emulation/wine-vanilla/wine-vanilla-2.0.ebuild
+++ b/app-emulation/wine-vanilla/wine-vanilla-2.0.ebuild
@@ -418,7 +418,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
        local DOCS=( ANNOUNCE AUTHORS README )
-       local l
        add_locale_docs() {
                local locale_doc="documentation/README.$1"
                [[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -451,22 +450,31 @@ multilib_src_install_all() {
                dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
        fi
 
+       # Failglob for bin and man loops
+       local glob_state=$(shopt -p failglob)
+       shopt -s failglob
+
        # Make wrappers for binaries for handling multiple variants
        # Note: wrappers instead of symlinks because some are shell which use basename
+       local b
        for b in "${D%/}${MY_PREFIX}"/bin/*; do
-               make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+               make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
        done
 
        # respect LINGUAS when installing man pages, #469418
+       local l
        for l in de fr pl; do
                use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
        done
 
+       local m
        for m in "${D%/}${MY_MANDIR}"/*/*; do
-               new_man=${m##*/}
-               new_man=${new_man%%.1}
-               newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+               new_man="${m##*/}"
+               new_man="${new_man%%.1}"
+               newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
        done
+
+       eval "${glob_state}"
 }
 
 pkg_postinst() {

diff --git a/app-emulation/wine-vanilla/wine-vanilla-2.1.ebuild b/app-emulation/wine-vanilla/wine-vanilla-2.1.ebuild
index 51cffe1c602282f5d66cc95a18c8c7a0c5b6b01e..7692f07caf912d55500e914c52e231046af42eff 100644 (file)
--- a/app-emulation/wine-vanilla/wine-vanilla-2.1.ebuild
+++ b/app-emulation/wine-vanilla/wine-vanilla-2.1.ebuild
@@ -418,7 +418,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
        local DOCS=( ANNOUNCE AUTHORS README )
-       local l
        add_locale_docs() {
                local locale_doc="documentation/README.$1"
                [[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -451,22 +450,31 @@ multilib_src_install_all() {
                dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
        fi
 
+       # Failglob for bin and man loops
+       local glob_state=$(shopt -p failglob)
+       shopt -s failglob
+
        # Make wrappers for binaries for handling multiple variants
        # Note: wrappers instead of symlinks because some are shell which use basename
+       local b
        for b in "${D%/}${MY_PREFIX}"/bin/*; do
-               make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+               make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
        done
 
        # respect LINGUAS when installing man pages, #469418
+       local l
        for l in de fr pl; do
                use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
        done
 
+       local m
        for m in "${D%/}${MY_MANDIR}"/*/*; do
-               new_man=${m##*/}
-               new_man=${new_man%%.1}
-               newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+               new_man="${m##*/}"
+               new_man="${new_man%%.1}"
+               newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
        done
+
+       eval "${glob_state}"
 }
 
 pkg_postinst() {

diff --git a/app-emulation/wine-vanilla/wine-vanilla-2.2.ebuild b/app-emulation/wine-vanilla/wine-vanilla-2.2.ebuild
index 51cffe1c602282f5d66cc95a18c8c7a0c5b6b01e..7692f07caf912d55500e914c52e231046af42eff 100644 (file)
--- a/app-emulation/wine-vanilla/wine-vanilla-2.2.ebuild
+++ b/app-emulation/wine-vanilla/wine-vanilla-2.2.ebuild
@@ -418,7 +418,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
        local DOCS=( ANNOUNCE AUTHORS README )
-       local l
        add_locale_docs() {
                local locale_doc="documentation/README.$1"
                [[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -451,22 +450,31 @@ multilib_src_install_all() {
                dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
        fi
 
+       # Failglob for bin and man loops
+       local glob_state=$(shopt -p failglob)
+       shopt -s failglob
+
        # Make wrappers for binaries for handling multiple variants
        # Note: wrappers instead of symlinks because some are shell which use basename
+       local b
        for b in "${D%/}${MY_PREFIX}"/bin/*; do
-               make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+               make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
        done
 
        # respect LINGUAS when installing man pages, #469418
+       local l
        for l in de fr pl; do
                use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
        done
 
+       local m
        for m in "${D%/}${MY_MANDIR}"/*/*; do
-               new_man=${m##*/}
-               new_man=${new_man%%.1}
-               newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+               new_man="${m##*/}"
+               new_man="${new_man%%.1}"
+               newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
        done
+
+       eval "${glob_state}"
 }
 
 pkg_postinst() {

diff --git a/app-emulation/wine-vanilla/wine-vanilla-2.3.ebuild b/app-emulation/wine-vanilla/wine-vanilla-2.3.ebuild
index 51cffe1c602282f5d66cc95a18c8c7a0c5b6b01e..7692f07caf912d55500e914c52e231046af42eff 100644 (file)
--- a/app-emulation/wine-vanilla/wine-vanilla-2.3.ebuild
+++ b/app-emulation/wine-vanilla/wine-vanilla-2.3.ebuild
@@ -418,7 +418,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
        local DOCS=( ANNOUNCE AUTHORS README )
-       local l
        add_locale_docs() {
                local locale_doc="documentation/README.$1"
                [[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -451,22 +450,31 @@ multilib_src_install_all() {
                dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
        fi
 
+       # Failglob for bin and man loops
+       local glob_state=$(shopt -p failglob)
+       shopt -s failglob
+
        # Make wrappers for binaries for handling multiple variants
        # Note: wrappers instead of symlinks because some are shell which use basename
+       local b
        for b in "${D%/}${MY_PREFIX}"/bin/*; do
-               make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+               make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
        done
 
        # respect LINGUAS when installing man pages, #469418
+       local l
        for l in de fr pl; do
                use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
        done
 
+       local m
        for m in "${D%/}${MY_MANDIR}"/*/*; do
-               new_man=${m##*/}
-               new_man=${new_man%%.1}
-               newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+               new_man="${m##*/}"
+               new_man="${new_man%%.1}"
+               newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
        done
+
+       eval "${glob_state}"
 }
 
 pkg_postinst() {

diff --git a/app-emulation/wine-vanilla/wine-vanilla-2.4.ebuild b/app-emulation/wine-vanilla/wine-vanilla-2.4.ebuild
index c21891ba8212b268bf4b988184040db8355d3b2e..a0e73034ed1a23e5a6636fcd8c8821cb309126d3 100644 (file)
--- a/app-emulation/wine-vanilla/wine-vanilla-2.4.ebuild
+++ b/app-emulation/wine-vanilla/wine-vanilla-2.4.ebuild
@@ -418,7 +418,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
        local DOCS=( ANNOUNCE AUTHORS README )
-       local l
        add_locale_docs() {
                local locale_doc="documentation/README.$1"
                [[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -451,22 +450,31 @@ multilib_src_install_all() {
                dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
        fi
 
+       # Failglob for bin and man loops
+       local glob_state=$(shopt -p failglob)
+       shopt -s failglob
+
        # Make wrappers for binaries for handling multiple variants
        # Note: wrappers instead of symlinks because some are shell which use basename
+       local b
        for b in "${D%/}${MY_PREFIX}"/bin/*; do
-               make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+               make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
        done
 
        # respect LINGUAS when installing man pages, #469418
+       local l
        for l in de fr pl; do
                use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
        done
 
+       local m
        for m in "${D%/}${MY_MANDIR}"/*/*; do
-               new_man=${m##*/}
-               new_man=${new_man%%.1}
-               newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+               new_man="${m##*/}"
+               new_man="${new_man%%.1}"
+               newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
        done
+
+       eval "${glob_state}"
 }
 
 pkg_postinst() {

diff --git a/app-emulation/wine-vanilla/wine-vanilla-2.5.ebuild b/app-emulation/wine-vanilla/wine-vanilla-2.5.ebuild
index c21891ba8212b268bf4b988184040db8355d3b2e..a0e73034ed1a23e5a6636fcd8c8821cb309126d3 100644 (file)
--- a/app-emulation/wine-vanilla/wine-vanilla-2.5.ebuild
+++ b/app-emulation/wine-vanilla/wine-vanilla-2.5.ebuild
@@ -418,7 +418,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
        local DOCS=( ANNOUNCE AUTHORS README )
-       local l
        add_locale_docs() {
                local locale_doc="documentation/README.$1"
                [[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -451,22 +450,31 @@ multilib_src_install_all() {
                dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
        fi
 
+       # Failglob for bin and man loops
+       local glob_state=$(shopt -p failglob)
+       shopt -s failglob
+
        # Make wrappers for binaries for handling multiple variants
        # Note: wrappers instead of symlinks because some are shell which use basename
+       local b
        for b in "${D%/}${MY_PREFIX}"/bin/*; do
-               make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+               make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
        done
 
        # respect LINGUAS when installing man pages, #469418
+       local l
        for l in de fr pl; do
                use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
        done
 
+       local m
        for m in "${D%/}${MY_MANDIR}"/*/*; do
-               new_man=${m##*/}
-               new_man=${new_man%%.1}
-               newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+               new_man="${m##*/}"
+               new_man="${new_man%%.1}"
+               newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
        done
+
+       eval "${glob_state}"
 }
 
 pkg_postinst() {

diff --git a/app-emulation/wine-vanilla/wine-vanilla-9999.ebuild b/app-emulation/wine-vanilla/wine-vanilla-9999.ebuild
index c21891ba8212b268bf4b988184040db8355d3b2e..a0e73034ed1a23e5a6636fcd8c8821cb309126d3 100644 (file)
--- a/app-emulation/wine-vanilla/wine-vanilla-9999.ebuild
+++ b/app-emulation/wine-vanilla/wine-vanilla-9999.ebuild
@@ -418,7 +418,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
        local DOCS=( ANNOUNCE AUTHORS README )
-       local l
        add_locale_docs() {
                local locale_doc="documentation/README.$1"
                [[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -451,22 +450,31 @@ multilib_src_install_all() {
                dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
        fi
 
+       # Failglob for bin and man loops
+       local glob_state=$(shopt -p failglob)
+       shopt -s failglob
+
        # Make wrappers for binaries for handling multiple variants
        # Note: wrappers instead of symlinks because some are shell which use basename
+       local b
        for b in "${D%/}${MY_PREFIX}"/bin/*; do
-               make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+               make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
        done
 
        # respect LINGUAS when installing man pages, #469418
+       local l
        for l in de fr pl; do
                use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
        done
 
+       local m
        for m in "${D%/}${MY_MANDIR}"/*/*; do
-               new_man=${m##*/}
-               new_man=${new_man%%.1}
-               newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+               new_man="${m##*/}"
+               new_man="${new_man%%.1}"
+               newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
        done
+
+       eval "${glob_state}"
 }
 
 pkg_postinst() {