Re: [PATCH v2] emacs: Add customization group for replying

diff --git a/7c/fb197aef7c2d4e09e6a3fafb17623d8722d0a6 b/7c/fb197aef7c2d4e09e6a3fafb17623d8722d0a6
new file mode 100644 (file)
index 0000000..38f4389
--- /dev/null
+++ b/7c/fb197aef7c2d4e09e6a3fafb17623d8722d0a6
@@ -0,0 +1,129 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B5826431FAF\r
+       for <notmuch@notmuchmail.org>; Thu,  6 Sep 2012 01:56:56 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id IOigcepbM0-o for <notmuch@notmuchmail.org>;\r
+       Thu,  6 Sep 2012 01:56:56 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id DBFCE431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  6 Sep 2012 01:56:55 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id BEBDB1000E5;\r
+       Thu,  6 Sep 2012 11:57:01 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: Add customization group for replying\r
+In-Reply-To: <1346919815-20397-1-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1346919815-20397-1-git-send-email-sojkam1@fel.cvut.cz>\r
+User-Agent: Notmuch/0.14+11~gd9bf007 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 06 Sep 2012 11:57:01 +0300\r
+Message-ID: <m2wr07fs0y.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 06 Sep 2012 08:56:56 -0000\r
+\r
+On Thu, Sep 06 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+\r
+> When one wants to customize the format of reply message, there is nothing\r
+> to tell the user how to do it.  Without knowing that construction of\r
+> reply buffer is actually implemented in the message package, it seems\r
+> that replying cannot be customized.\r
+>\r
+> Because I was getting annoyed by the empty line the between the citation\r
+> line and the quoted message, I figured out that changing this is fairly\r
+> easy when one knows what to customize.\r
+>\r
+> This patch adds notmuch-reply customization group that contains\r
+> references to the relevant customization options. The new group is easy\r
+> to find as it is shown as a result of running "M-x customize-group RET\r
+> notmuch RET".\r
+> ---\r
+\r
+So far good, but...\r
+\r
+You forgot to handle the current group setting for \r
+notmuch-message-replied-tags -- currently notmuch-message.el has this:\r
+\r
+(defcustom notmuch-message-replied-tags '("replied")\r
+  "Tags to be automatically added to or removed from a message when it is\r
+  replied to.\r
+Any tag in the list will be added to a replied message or,\r
+if it is prefaced with a \"-\", removed.\r
+\r
+For example, if you wanted to add a \"replied\" tag and remove\r
+the \"inbox\" and \"todo\", you would set\r
+    (\"replied\" \"-inbox\" \"-todo\"\)"\r
+  :type 'list\r
+  :group 'notmuch-send)\r
+\r
+If the above was changed to 'normuch-send, (require 'notmuch-lib)\r
+was added to the beginning of notmuch-message.el and the defgroup\r
+below was written as\r
+\r
+(defgroup notmuch-reply\r
+  '((message-insertion custom-group)))\r
+   "Replying to messages.\r
+    ...\r
+\r
+would that work as expected ?\r
+\r
+Tomi\r
+\r
+\r
+>  emacs/notmuch-lib.el |   10 ++++++++++\r
+>  1 file changed, 10 insertions(+)\r
+>\r
+> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el\r
+> index 900235b..c045a32 100644\r
+> --- a/emacs/notmuch-lib.el\r
+> +++ b/emacs/notmuch-lib.el\r
+> @@ -45,6 +45,16 @@\r
+>    "Showing messages and threads."\r
+>    :group 'notmuch)\r
+>  \r
+> +(defgroup notmuch-reply\r
+> +  '((message-insertion custom-group)\r
+> +    (notmuch-message-replied-tags custom-variable))\r
+> +  "Replying to messages.\r
+> +\r
+> +Most of the reply customization settings can be found in `Message\r
+> +insertion' group. Notmuch specific settings is included directly\r
+> +here."\r
+> +  :group 'notmuch)\r
+> +\r
+>  (defgroup notmuch-send nil\r
+>    "Sending messages from Notmuch."\r
+>    :group 'notmuch)\r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r