Re: [PATCH] emacs-show: open excluded matches if no other matches

diff --git a/d0/561015e98ae877e79396baad671295e9ea0a49 b/d0/561015e98ae877e79396baad671295e9ea0a49
new file mode 100644 (file)
index 0000000..6321fe1
--- /dev/null
+++ b/d0/561015e98ae877e79396baad671295e9ea0a49
@@ -0,0 +1,80 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 717C0431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 12 Apr 2012 12:20:57 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id EZlQa-lbc8o2 for <notmuch@notmuchmail.org>;\r
+       Thu, 12 Apr 2012 12:20:55 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 542E2431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 12 Apr 2012 12:20:55 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 911E568055; Thu, 12 Apr 2012 22:20:52 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs-show: open excluded matches if no other matches\r
+In-Reply-To: <8762d44vkv.fsf@servo.finestructure.net>\r
+References: <1331836090-30560-1-git-send-email-markwalters1009@gmail.com>\r
+       <8762d44vkv.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.12+104~gf9ad237 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 12 Apr 2012 22:20:52 +0300\r
+Message-ID: <m2ty0odaej.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 12 Apr 2012 19:20:57 -0000\r
+\r
+On Thu, Apr 12 2012, Jameson Graef Rollins wrote:\r
+\r
+> On Thu, Mar 15 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+>> Currently emacs show does not open matching but excluded\r
+>> messages. This is normally the desired behaviour but is probably not\r
+>> ideal if only excluded messages match. This patch opens all the\r
+>> matching (necessarily excluded) messages in this case and goes to the\r
+>> first one.\r
+>\r
+> Hi, Mark.  I have tested this patch and it LGTM.  I think this is the\r
+> behavior we want, since it's no fun to open up a show buffer and have\r
+> all messages in the thread closed.  That doesn't make much sense.\r
+\r
+I disagree: If I open up a show buffer I'd like to have all messages\r
+in the thread closed if search terms do not match. But that is my\r
+opinion and inconsistent with current behaviour.\r
+\r
+(Therefore I already +1:d this patch)\r
+\r
+An example: I have thread of 100 messages and 1 of those is unread.\r
+Search terms is tag:unread. I enter the thread: 99 messages closed\r
+and this one open. Now unread is automatically removed. If I go back\r
+to search view (by pressing q) and re-choose the same thread,\r
+current behaviour is to open all 100 messages. I'd like to see all\r
+100 messages closed.\r
+\r
+> jamie.\r
+\r
+Tomi\r