Re: [PATCH 7/6] emacs: relax tag syntax check in `notmuch-tag' function

diff --git a/af/d5061879d5ed6433aefdd7fed165ce8af7b5bb b/af/d5061879d5ed6433aefdd7fed165ce8af7b5bb
new file mode 100644 (file)
index 0000000..d38bc90
--- /dev/null
+++ b/af/d5061879d5ed6433aefdd7fed165ce8af7b5bb
@@ -0,0 +1,126 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8AD17431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 12:55:31 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id DHDygNhRxF8G for <notmuch@notmuchmail.org>;\r
+       Sun, 19 Feb 2012 12:55:31 -0800 (PST)\r
+Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com\r
+       [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id C5FBB431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 12:55:30 -0800 (PST)\r
+Received: by wibhi8 with SMTP id hi8so3112374wib.26\r
+       for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 12:55:29 -0800 (PST)\r
+Received-SPF: pass (google.com: domain of pieter@praet.org designates\r
+       10.180.86.105 as permitted sender) client-ip=10.180.86.105; \r
+Authentication-Results: mr.google.com;\r
+       spf=pass (google.com: domain of pieter@praet.org\r
+       designates 10.180.86.105 as permitted sender)\r
+       smtp.mail=pieter@praet.org\r
+Received: from mr.google.com ([10.180.86.105])\r
+       by 10.180.86.105 with SMTP id o9mr12082813wiz.4.1329684929715 (num_hops\r
+       = 1); Sun, 19 Feb 2012 12:55:29 -0800 (PST)\r
+Received: by 10.180.86.105 with SMTP id o9mr10108269wiz.4.1329684929632;\r
+       Sun, 19 Feb 2012 12:55:29 -0800 (PST)\r
+Received: from localhost (104.218-242-81.adsl-dyn.isp.belgacom.be.\r
+       [81.242.218.104])\r
+       by mx.google.com with ESMTPS id dr5sm29418049wib.0.2012.02.19.12.55.28\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sun, 19 Feb 2012 12:55:29 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: Jani Nikula <jani@nikula.org>,\r
+       Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+Subject: Re: [PATCH 7/6] emacs: relax tag syntax check in `notmuch-tag'\r
+       function\r
+In-Reply-To:\r
+ <CAB+hUn834oJ+XGx-YyYSGxSnzrBYCMvcu4Vd73ws28qTS2riuA@mail.gmail.com>\r
+References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1327727143-24455-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <CAB+hUn834oJ+XGx-YyYSGxSnzrBYCMvcu4Vd73ws28qTS2riuA@mail.gmail.com>\r
+User-Agent: Notmuch/0.11.1+210~g6afc43e (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Sun, 19 Feb 2012 21:53:19 +0100\r
+Message-ID: <87fwe6sfy8.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQnoIY1DpczZU7ThbuWQE897pegR8aoH61aYbblMMqce+8I9ooSe1PoeKExtNU6ovHRQVjAN\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 19 Feb 2012 20:55:31 -0000\r
+\r
+On Sat, 28 Jan 2012 10:56:21 +0200, Jani Nikula <jani@nikula.org> wrote:\r
+> On Jan 28, 2012 7:06 AM, "Dmitry Kurochkin" <dmitry.kurochkin@gmail.com>\r
+> wrote:\r
+> >\r
+> > The tag syntax check in `notmuch-tag' function was too strict and did\r
+> > not allow nmbug tags with "::".  Since the check is done for all\r
+> > tagging operations in Emacs UI, this basically means that no nmbug\r
+> > tags can be changed.  The patch relaxes the tag syntax check to allow\r
+> > any tag names that do not include whitespace characters.\r
+> \r
+> Imho the syntax check should be in cli, or lib even. I posted a patch to\r
+> cli some time ago when I realized it's possible to add tag "-" but you\r
+> can't remove it with the current cli. (On the road, can't find the message\r
+> id now.)\r
+>\r
+\r
+Here you go:\r
+  id:"3da260c7687fafe2cbc17bad129a8b1edb05c6d0.1320958534.git.jani@nikula.org"\r
+\r
+> > ---\r
+> >  emacs/notmuch.el |    2 +-\r
+> >  1 files changed, 1 insertions(+), 1 deletions(-)\r
+> >\r
+> > diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> > index 9813e0a..0de6123 100644\r
+> > --- a/emacs/notmuch.el\r
+> > +++ b/emacs/notmuch.el\r
+> > @@ -555,7 +555,7 @@ notmuch-after-tag-hook will be run."\r
+> >   ;; Perform some validation\r
+> >   (when (null tags) (error "No tags given"))\r
+> >   (mapc (lambda (tag)\r
+> > -         (unless (string-match-p "^[-+][-+_.[:word:]]+$" tag)\r
+> > +         (unless (string-match-p "^[-+]\\S-+$" tag)\r
+> >            (error "Tag must be of the form `+this_tag' or `-that_tag'")))\r
+> >        tags)\r
+> >   (run-hooks 'notmuch-before-tag-hook)\r
+> > --\r
+> > 1.7.8.3\r
+> >\r
+> > _______________________________________________\r
+> > notmuch mailing list\r
+> > notmuch@notmuchmail.org\r
+> > http://notmuchmail.org/mailman/listinfo/notmuch\r
+Non-text part: text/html\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r