Re: [PATCH 4/6] cli: intialize crypto structure in show and reply

diff --git a/24/91aa9f408ef5eac1d7d6fbea6ba50da3f50791 b/24/91aa9f408ef5eac1d7d6fbea6ba50da3f50791
new file mode 100644 (file)
index 0000000..dc2bf42
--- /dev/null
+++ b/24/91aa9f408ef5eac1d7d6fbea6ba50da3f50791
@@ -0,0 +1,99 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 05E34431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 17 May 2012 07:26:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id XnQYg95OrMkj for <notmuch@notmuchmail.org>;\r
+       Thu, 17 May 2012 07:26:43 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4F528431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 17 May 2012 07:26:43 -0700 (PDT)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id B6A362E50D4C;\r
+       Thu, 17 May 2012 07:26:38 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (cpe-98-14-81-93.nyc.res.rr.com\r
+ [98.14.81.93])        (Authenticated sender: jrollins)        by fire-doxen-submit\r
+ (Postfix) with ESMTP id D977A2E50CC1; Thu, 17 May 2012 07:26:35 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id D03404FD; Thu, 17 May 2012 07:26:32 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Jani Nikula <jani@nikula.org>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 4/6] cli: intialize crypto structure in show and reply\r
+In-Reply-To: <8762bvi70k.fsf@nikula.org>\r
+References: <1337205359-2444-1-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-2-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-3-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-4-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-5-git-send-email-jrollins@finestructure.net>\r
+       <8762bvi70k.fsf@nikula.org>\r
+User-Agent: Notmuch/0.12+183~g9d5ff3c (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 17 May 2012 07:26:30 -0700\r
+Message-ID: <877gwaeve1.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 17 May 2012 14:26:45 -0000\r
+\r
+--=-=-=\r
+\r
+On Thu, May 17 2012, Jani Nikula <jani@nikula.org> wrote:\r
+> On Thu, 17 May 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+>> This makes sure it has proper initialization values when it's created.\r
+>\r
+> Please don't do this. It's unnecessary; if one field is initialized with\r
+> a designated initializer, the rest are initialized to zero (or NULL).\r
+\r
+It may be technically unnecessary, but why is that a reason to not do\r
+it?  I intentionally did this to make it clear what the defaults are.\r
+Otherwise the defaults are essentially undefined, which is not good.\r
+Maybe the structure initializes to the correct defaults, but why count\r
+on that when we can set them to the correct default, and have it clear\r
+to readers of the code?\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPtQqWAAoJEO00zqvie6q87lMP/1dNXTVFfvyNJVT65AVie7bj\r
+rinWFVmi2qY/biIM2JUtAa9HDgD8CdVgG+oA/DNrlgpm72Ommexgl8CvvW2StZVX\r
+IMnFGMXiwjmToLPJq0jL8b0Bq2IVNUi7K7yLDhh04Fv64EMWCYF58aYj5tJ9dA8N\r
+HkKEyuYZoNc3xNqgjDTVSSKI0tjmGUFNaEQAvFvucdXJ4Ca8dHsYrpg7HD35d/0J\r
+Q1sRj6wlEkmTgmxbkNBx6NRnSCGVv/QhnK2aRpjIk0EL7vdE4ZA1IzuY73OQWLvn\r
+QMQRacmAAHZkyVmJlaKmTdUx4Z7AdeGrYLTvf/LDNME9bfJmIbykDTRMqZ7k+KZ6\r
+vqqfvvP2HZJePWSAhTnB7Rb9Fl0lDylgRqdq6wtu/L12rmwhOGVvAQqUmTerKe1E\r
+ugEnb/rhZ/KcNYXFS4G9dV6I4SD4sIyW14380ZiKur6vwpcA3rPDwrFNeX+C6bEH\r
+Jmob8Q9WfqjhPUDuG6ngSOSx0+D1pABPALCimSdalKtGj/hhas/L8kkj8MMHCN00\r
+S98fwle+fo8uJFAMjeaE3XQ0WJPD8AdH/nBGL6EzNb9liUlH2cygTs0zD8wRutUv\r
+Z717CXKeoolz0ls8hm3a7Poab1DIw6Oi5OzYxXNy6TmOmoI7dJXUemSfUTiR77mk\r
+BbH8yDE64UlYFNYyExkF\r
+=hE/w\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r