Re: [PATCH 1/1] devel/release-checks.sh: added check that 1st NEWS header is tidy

diff --git a/2c/73ebc8d4dbf93845e07f8e0f242f90f6bc23a0 b/2c/73ebc8d4dbf93845e07f8e0f242f90f6bc23a0
new file mode 100644 (file)
index 0000000..91af211
--- /dev/null
+++ b/2c/73ebc8d4dbf93845e07f8e0f242f90f6bc23a0
@@ -0,0 +1,75 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4C0E1431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 18 Feb 2013 08:25:40 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id cEtLCRe14QAU for <notmuch@notmuchmail.org>;\r
+       Mon, 18 Feb 2013 08:25:39 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id A2B45431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 18 Feb 2013 08:25:39 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id EE66410014F;\r
+       Mon, 18 Feb 2013 18:25:27 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/1] devel/release-checks.sh: added check that 1st NEWS\r
+       header is tidy\r
+In-Reply-To: <87ehgg7aar.fsf@zancas.localnet>\r
+References: <1359558095-22923-1-git-send-email-tomi.ollila@iki.fi>\r
+       <87ehgg7aar.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.15+20~g7e29ae9 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 18 Feb 2013 18:25:27 +0200\r
+Message-ID: <m24nh9si6g.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 18 Feb 2013 16:25:40 -0000\r
+\r
+On Sat, Feb 16 2013, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>> +echo -n "Checking that NEWS header is tidy... "\r
+>> +if [ "`exec sed 's/./=/g; 1q' NEWS`" = "`exec sed '1d; 2q' NEWS`" ]\r
+>\r
+> This patch seems OK to me, although the execs might be a bit overkill\r
+> for a script that is run once ever few months.\r
+\r
+You're right. The 2 extra fork(2):s(*) here doesn't matter...\r
+\r
+In case you don't amend my patch in following weeks I'll send\r
+a new patch :)\r
+\r
+> d\r
+\r
+(*) FYI: It is only bash(1) which forks process to execute the external\r
+command in such a trivial cases. Most (if not all) other shells have\r
+(conservative) heuristics to avoid the "extra" fork there. If you're\r
+interested, my simple way to test this is 'strace -ff -o pidc cmd args...'\r
+\r
+Tomi\r