dev-lang/squirrel: declare used CMake variables, bug #659880

portage's QA check complains:
> One or more CMake variables were not used by the project:
>  DISABLE_STATIC
>  LONG_OUTPUT_NAMES

The warning is misleading. Variables are used but not declared
as 'options()'s. This change tweaks the declaration.

Reported-by: Toralf Förster
Closes: https://bugs.gentoo.org/659880
Package-Manager: Portage-2.3.41, Repoman-2.3.9

diff --git a/dev-lang/squirrel/files/squirrel-3.1-declare-options.patch b/dev-lang/squirrel/files/squirrel-3.1-declare-options.patch
new file mode 100644 (file)
index 0000000..11bdbf1
--- /dev/null
+++ b/dev-lang/squirrel/files/squirrel-3.1-declare-options.patch
@@ -0,0 +1,10 @@
+Explicitly declare used CMake options
+
+Bug: https://bugs.gentoo.org/659880
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -1 +1,4 @@
++option(DISABLE_STATIC "Avoid building/installing static libraries.")
++option(LONG_OUTPUT_NAMES "Use longer names for binaries and libraries: squirrel3 (not sq).")
++
+ if(MSVC)

diff --git a/dev-lang/squirrel/squirrel-3.1.ebuild b/dev-lang/squirrel/squirrel-3.1.ebuild
index 4a149398eb44c54b8efd3c6abbd990f9546610ec..761fd5c1da2599fe4dca231bc4afe5d8c8bde014 100644 (file)
--- a/dev-lang/squirrel/squirrel-3.1.ebuild
+++ b/dev-lang/squirrel/squirrel-3.1.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2017 Gentoo Foundation
+# Copyright 1999-2018 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=6
@@ -17,6 +17,10 @@ IUSE="examples static-libs"
 RDEPEND=""
 DEPEND="${RDEPEND}"
 
+PATCHES=(
+       "${FILESDIR}"/${P}-declare-options.patch
+)
+
 src_configure() {
        local mycmakeargs=(
                -DINSTALL_LIB_DIR="$(get_libdir)" \