--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id BB3A0431FAF\r
+ for <notmuch@notmuchmail.org>; Mon, 6 Aug 2012 09:47:14 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 9Ml6I0dPifku for <notmuch@notmuchmail.org>;\r
+ Mon, 6 Aug 2012 09:47:12 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU\r
+ [18.9.25.15])\r
+ by olra.theworths.org (Postfix) with ESMTP id C4E72431FAE\r
+ for <notmuch@notmuchmail.org>; Mon, 6 Aug 2012 09:47:12 -0700 (PDT)\r
+X-AuditID: 1209190f-b7f306d0000008b4-f7-501ff5109266\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+ by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id B5.37.02228.015FF105; Mon, 6 Aug 2012 12:47:12 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q76GlBka016635; \r
+ Mon, 6 Aug 2012 12:47:12 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q76GlAQo018537\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Mon, 6 Aug 2012 12:47:11 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1SyQSU-00035Y-CK; Mon, 06 Aug 2012 12:47:10 -0400\r
+Date: Mon, 6 Aug 2012 12:47:10 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Peter Wang <novalazy@gmail.com>\r
+Subject: Re: [PATCH 1/4] show: indicate length of omitted body content (json)\r
+Message-ID: <20120806164710.GK22601@mit.edu>\r
+References: <1344151345-25411-1-git-send-email-novalazy@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1344151345-25411-1-git-send-email-novalazy@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42IRYrdT1xX4Kh9g0LlY3OL6zZnMFs9b9zI5\r
+ MHnsnHWX3ePZqlvMAUxRXDYpqTmZZalF+nYJXBnLju5gLDgkUrFxxzbWBsYmgS5GTg4JAROJ\r
+ vYvXsEDYYhIX7q1nA7GFBPYxSrx9odTFyAVkr2eU6FtwiBXCOcEk8fjnJKiqJYwSC1blgNgs\r
+ AioSlxdPYQSx2QQ0JLbtXw5miwgoS/z59QysnllAWuLb72amLkYODmEBX4nLl8tAwrwCOhLN\r
+ X04wg4SFBJwkJj+1gwgLSpyc+YQFolNL4sa/l2CdIFOW/+MACXMKOEvM3NQPViIKdMCUk9vY\r
+ JjAKzULSPQtJ9yyE7gWMzKsYZVNyq3RzEzNzilOTdYuTE/PyUot0TfRyM0v0UlNKNzGCAppT\r
+ kn8H47eDSocYBTgYlXh4nXrkA4RYE8uKK3MPMUpyMCmJ8sa+AwrxJeWnVGYkFmfEF5XmpBYf\r
+ YpTgYFYS4a1ZCJTjTUmsrEotyodJSXOwKInzXk256S8kkJ5YkpqdmlqQWgSTleHgUJLgVf4C\r
+ 1ChYlJqeWpGWmVOCkGbi4AQZzgM0/NdnkOHFBYm5xZnpEPlTjIpS4rxiIM0CIImM0jy4XljC\r
+ ecUoDvSKMEQVDzBZwXW/AhrMBDTYW14OZHBJIkJKCphkfjUar+A+k5nIP1FG5yPTLUn/grdy\r
+ C/YqnfVJudTx4WLJ2T2neybIc2m+czhaWcT3RGBy1rpD/k0rlj94Hvxtuib3mRfrfYslNq9K\r
+ WX6rbCLz1qVbeLxcBSQlPlVvS23pKZyaZ798jrHVfG8Ro9VzW67w/eziWPP9re0dvuN3Juw/\r
+ ebGj4GCJEktxRqKhFnNRcSIAWwXwSxMDAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 06 Aug 2012 16:47:14 -0000\r
+\r
+What's the overall goal of adding this? Are you planning to add size\r
+information to one of the frontends?\r
+\r
+Quoth Peter Wang on Aug 05 at 5:22 pm:\r
+> If a leaf part's body content is omitted, return the content length in\r
+> --format=json output. This information may be used by the consumer,\r
+> e.g. to decide whether to download a large attachment over a slow link.\r
+> ---\r
+> devel/schemata | 5 ++++-\r
+> notmuch-show.c | 8 ++++++++\r
+> 2 files changed, 12 insertions(+), 1 deletions(-)\r
+> \r
+> diff --git a/devel/schemata b/devel/schemata\r
+> index 9cb25f5..3df2764 100644\r
+> --- a/devel/schemata\r
+> +++ b/devel/schemata\r
+> @@ -69,7 +69,10 @@ part = {\r
+> # A leaf part's body content is optional, but may be included if\r
+> # it can be correctly encoded as a string. Consumers should use\r
+> # this in preference to fetching the part content separately.\r
+> - content?: string\r
+> + content?: string,\r
+> + # If a leaf part's body content is not included, the content-length\r
+> + # may be included instead.\r
+\r
+You mentioned elsewhere that the content-length returned is an\r
+estimate. If that's the case, this comment should say as much. Is it\r
+actually the case, though? g_mime_part_get_content_object is\r
+remarkably poorly documented for such an important function, but based\r
+on format_part_raw, it seems like the content-length your code returns\r
+will be exactly the number of bytes returned by the raw format for a\r
+leaf part.\r
+\r
+> + content-length?: int\r
+> }\r
+> \r
+> # The headers of a message or part (format_headers_json with reply = FALSE)\r
+> diff --git a/notmuch-show.c b/notmuch-show.c\r
+> index 3556293..5c54257 100644\r
+> --- a/notmuch-show.c\r
+> +++ b/notmuch-show.c\r
+> @@ -664,6 +664,14 @@ format_part_json (const void *ctx, sprinter_t *sp, mime_node_t *node,\r
+> sp->map_key (sp, "content");\r
+> sp->string_len (sp, (char *) part_content->data, part_content->len);\r
+> g_object_unref (stream_memory);\r
+> + } else {\r
+> + GMimeDataWrapper *wrapper = g_mime_part_get_content_object (GMIME_PART (node->part));\r
+> + GMimeStream *stream = g_mime_data_wrapper_get_stream (wrapper);\r
+> + ssize_t length = g_mime_stream_length (stream);\r
+> + if (length >= 0) {\r
+> + sp->map_key (sp, "content-length");\r
+> + sp->integer (sp, length);\r
+> + }\r
+\r
+Do wrapper or stream need to be g_object_unref'd?\r
+\r
+Any idea what the performance overhead of this is? I'm just curious.\r
+It might be approximately nothing, since GMime's parser is eager.\r
+\r
+> }\r
+> } else if (GMIME_IS_MULTIPART (node->part)) {\r
+> sp->map_key (sp, "content");\r
projects / notmuch-archives.git / commitdiff