dev-libs/libdbusmenu: Fix building w/ USE=-test
authorMichał Górny <mgorny@gentoo.org>
Sun, 6 Aug 2017 16:08:30 +0000 (18:08 +0200)
committerMichał Górny <mgorny@gentoo.org>
Sun, 6 Aug 2017 16:09:28 +0000 (18:09 +0200)
dev-libs/libdbusmenu/files/libdbusmenu-16.04.0-configure-fix.patch [new file with mode: 0644]
dev-libs/libdbusmenu/libdbusmenu-16.04.0.ebuild

diff --git a/dev-libs/libdbusmenu/files/libdbusmenu-16.04.0-configure-fix.patch b/dev-libs/libdbusmenu/files/libdbusmenu-16.04.0-configure-fix.patch
new file mode 100644 (file)
index 0000000..a578778
--- /dev/null
@@ -0,0 +1,35 @@
+From 4b79b41a25cc1e2c4355738b4bed6c73b919ffee Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= <mgorny@gentoo.org>
+Date: Sun, 6 Aug 2017 17:55:45 +0200
+Subject: [PATCH] configure: Fix HAVE_VALGRIND not being defined when tests are
+ disabled
+
+If --disable-tests is used, configure fails with the following error:
+
+  configure: error: conditional "HAVE_VALGRIND" was never defined.
+  Usually this means the macro was only invoked conditionally.
+
+This is because AM_CONDITIONAL for it is called inside the 'if' for
+tests being enabled. Move it just below that block to ensure that it's
+defined unconditionally.
+---
+ configure.ac | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure.ac b/configure.ac
+index ace54d1..cbd38a6 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -120,8 +120,8 @@ PKG_CHECK_MODULES(DBUSMENUTESTS,  json-glib-1.0 >= $JSON_GLIB_REQUIRED_VERSION
+                                   [have_tests=yes]
+ )
+ PKG_CHECK_MODULES(DBUSMENUTESTSVALGRIND, valgrind, have_valgrind=yes, have_valgrind=no)
+-AM_CONDITIONAL([HAVE_VALGRIND], [test "x$have_valgrind" = "xyes"])
+ ])
++AM_CONDITIONAL([HAVE_VALGRIND], [test "x$have_valgrind" = "xyes"])
+ AC_SUBST(DBUSMENUTESTS_CFLAGS)
+ AC_SUBST(DBUSMENUTESTS_LIBS)
+-- 
+2.14.0
+
index 5b4dc1f1df452437fbf91b879510c1eaf4a690b1..131d663ca80022b82270bb033167e35b734431f9 100644 (file)
@@ -8,8 +8,8 @@ VALA_USE_DEPEND=vapigen
 PYTHON_COMPAT=( python2_7 )
 VIRTUALX_REQUIRED=manual
 
-inherit flag-o-matic multilib-minimal python-single-r1 vala virtualx \
-       xdg-utils
+inherit autotools flag-o-matic multilib-minimal python-single-r1 vala \
+       virtualx xdg-utils
 
 DESCRIPTION="Library to pass menu structure across DBus"
 HOMEPAGE="https://launchpad.net/dbusmenu"
@@ -57,7 +57,9 @@ src_prepare() {
        fi
        python_fix_shebang tools
 
+       eapply "${FILESDIR}/${P}-configure-fix.patch"
        eapply_user
+       eautoreconf
 }
 
 multilib_src_configure() {