Re: [PATCH] STYLE: Initial draft of coding style document

diff --git a/34/03514781c036f8dcddc56baf04e0bc853ac420 b/34/03514781c036f8dcddc56baf04e0bc853ac420
new file mode 100644 (file)
index 0000000..27b1432
--- /dev/null
+++ b/34/03514781c036f8dcddc56baf04e0bc853ac420
@@ -0,0 +1,82 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C4953431FAF\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Feb 2012 21:20:19 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.224\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.224 tagged_above=-999 required=5\r
+       tests=[DATE_IN_PAST_03_06=1.076, RCVD_IN_DNSWL_MED=-2.3]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Zl+MHEr5h7zU for <notmuch@notmuchmail.org>;\r
+       Fri,  3 Feb 2012 21:20:17 -0800 (PST)\r
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id BC39D431FAE\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Feb 2012 21:20:17 -0800 (PST)\r
+Received: from rocinante.cs.unb.ca ([209.104.169.194]) (authenticated bits=0)\r
+       by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id q145K5fb012702\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);\r
+       Sat, 4 Feb 2012 01:20:08 -0400\r
+Received: from bremner by rocinante.cs.unb.ca with local (Exim 4.77)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1RtTq7-0002nA-CI; Fri, 03 Feb 2012 20:50:51 -0400\r
+From: David Bremner <bremner@debian.org>\r
+To: Jani Nikula <jani@nikula.org>, Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH] STYLE: Initial draft of coding style document\r
+In-Reply-To:\r
+ <CAB+hUn-o8JyWPqS+1e37m171cR04=LNOCBxFLyUiRK1vWjbe3g@mail.gmail.com>\r
+References: <1327708018-1107-1-git-send-email-david@tethera.net>\r
+       <m2ehuhdzls.fsf@guru.guru-group.fi>\r
+       <CAB+hUn-o8JyWPqS+1e37m171cR04=LNOCBxFLyUiRK1vWjbe3g@mail.gmail.com>\r
+User-Agent: Notmuch/0.11+7~gf38bc44 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 03 Feb 2012 20:50:51 -0400\r
+Message-ID: <87vcnnjuac.fsf@rocinante.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 Feb 2012 05:20:19 -0000\r
+\r
+On Mon, 30 Jan 2012 18:01:15 +0200, Jani Nikula <jani@nikula.org> wrote:\r
+> On Jan 30, 2012 4:38 PM, "Tomi Ollila" <tomi.ollila@iki.fi> wrote:\r
+> >\r
+> > > +\r
+> > > +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8.\r
+> > > +  Tabs should be only at the beginning of the line.\r
+> >\r
+> > So, after initial indentation (with tabs) there should not be further\r
+> > tabs? We'll be using the former instead of the latter in these 2 below?\r
+\r
+Ah, I only meant to explain what whitespace-mode complains about, namely\r
+\r
+<space><space><space><space><tab>x=1;\r
+\r
+as opposed to \r
+\r
+<tab<space><space><space><space><tab>x=1;\r
+\r
+I'm not sure it's that important, but apparently if it stays in the\r
+style guide it needs rewording.\r
+\r
+d\r
+\r
+\r