Re: [PATCH 1/3] cli: refactor "notmuch tag" data structures for tagging operations

diff --git a/5b/ddb9156c021b84edb8f1dfd5f3c07cc45b82af b/5b/ddb9156c021b84edb8f1dfd5f3c07cc45b82af
new file mode 100644 (file)
index 0000000..f0d5221
--- /dev/null
+++ b/5b/ddb9156c021b84edb8f1dfd5f3c07cc45b82af
@@ -0,0 +1,71 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 872D8431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 25 Mar 2012 04:24:56 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 52NXYDfd5G5d for <notmuch@notmuchmail.org>;\r
+       Sun, 25 Mar 2012 04:24:55 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D9BDB431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 25 Mar 2012 04:24:55 -0700 (PDT)\r
+Received: from fctnnbsc30w-142166230117.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([142.166.230.117] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)\r
+       (Exim 4.72) (envelope-from <bremner@unb.ca>)\r
+       id 1SBlZ1-0007Is-An; Sun, 25 Mar 2012 08:24:51 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.77)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1SBlYw-0004lX-28; Sun, 25 Mar 2012 08:24:42 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] cli: refactor "notmuch tag" data structures for\r
+       tagging operations\r
+In-Reply-To:\r
+ <992ada5cb2fa5f89d4f38b10d62f1c178b3174e2.1332604895.git.jani@nikula.org>\r
+References: <cover.1332604895.git.jani@nikula.org>\r
+       <992ada5cb2fa5f89d4f38b10d62f1c178b3174e2.1332604895.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.12 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 25 Mar 2012 08:24:42 -0300\r
+Message-ID: <87wr68zzwl.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 25 Mar 2012 11:24:56 -0000\r
+\r
+On Sat, 24 Mar 2012 18:14:35 +0200, Jani Nikula <jani@nikula.org> wrote:\r
+> To simplify code, keep all tagging operations in a single array\r
+> instead of separate add and remove arrays. Apply tag changes in the\r
+> order specified on the command line, instead of first removing and\r
+> then adding the tags.\r
+\r
+Like I said on IRC, my only minor reservation with this patch is that\r
+the use of C99 struct assignment is maybe not a good tradeoff here,\r
+since it makes the code a bit more mysterious (for the great unwashed\r
+masses that don't know C99 as well as C89). Still, if you think extra\r
+initialization features are worth it, I can live with it. \r
+\r
+d\r