--- /dev/null
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id D9A1E431FBC\r
+ for <notmuch@notmuchmail.org>; Mon, 5 Mar 2012 07:43:44 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id F5g7lJ6HWL6V for <notmuch@notmuchmail.org>;\r
+ Mon, 5 Mar 2012 07:43:44 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+ [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 1A93F431FAE\r
+ for <notmuch@notmuchmail.org>; Mon, 5 Mar 2012 07:43:43 -0800 (PST)\r
+Received: by bkwj4 with SMTP id j4so3784591bkw.26\r
+ for <notmuch@notmuchmail.org>; Mon, 05 Mar 2012 07:43:41 -0800 (PST)\r
+Received-SPF: pass (google.com: domain of dmitry.kurochkin@gmail.com\r
+ designates 10.204.156.70 as permitted sender)\r
+ client-ip=10.204.156.70; \r
+Authentication-Results: mr.google.com; spf=pass (google.com: domain of\r
+ dmitry.kurochkin@gmail.com designates 10.204.156.70 as\r
+ permitted sender) smtp.mail=dmitry.kurochkin@gmail.com;\r
+ dkim=pass header.i=dmitry.kurochkin@gmail.com\r
+Received: from mr.google.com ([10.204.156.70])\r
+ by 10.204.156.70 with SMTP id v6mr1449625bkw.124.1330962221503\r
+ (num_hops = 1); Mon, 05 Mar 2012 07:43:41 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ bh=2sUSidYx47yR3QYGrOCC1jvFwtvz0Jj0LM1iuFa4dKE=;\r
+ b=Z1eUK7+e3M80W5ZzkeYT/ty9mV+x16tB9wlNB80cJtj5k7kYxvOVQS9EBFLj+0EYpY\r
+ RVGbmLmzJPHrQrv/2jNl6PrjE2bBl/6vnDkXY4Me3VK/gez7zYB06aSRnaSJRYM/I6MN\r
+ 7r+Mvo/tC9ipBql+7Bx6phkh84F919rLauVCWkgwBmThNjRdbDOagp5HXHuEsj2Ik+hZ\r
+ +LCKYRrOA/id5m3SysbggsdV9cXX8d/srRz90dMgaw1rOIRHHBL37ZveAPHECSxWJoP3\r
+ RzJTaGzN+boqnzoAi3k6g3jp0cNpWU2lN64sHI39+RMluuovRT0DCJVsv8racPn7hDut\r
+ S04g==\r
+Received: by 10.204.156.70 with SMTP id v6mr1094790bkw.124.1330962221373;\r
+ Mon, 05 Mar 2012 07:43:41 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+ by mx.google.com with ESMTPS id d5sm26371937bkb.3.2012.03.05.07.43.39\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Mon, 05 Mar 2012 07:43:40 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Daniel Schoepe <daniel@schoepe.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: Pass a copy to\r
+ notmuch-saved-search-sort-function\r
+In-Reply-To: <87399n2t60.fsf@schoepe.localhost>\r
+References: <1330613059-5130-1-git-send-email-daniel@schoepe.org>\r
+ <1330633478-1974-1-git-send-email-daniel@schoepe.org>\r
+ <1330633478-1974-2-git-send-email-daniel@schoepe.org>\r
+ <87booblrcv.fsf@gmail.com> <87399n2t60.fsf@schoepe.localhost>\r
+User-Agent: Notmuch/0.11.1+288~g4b3af0e (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 05 Mar 2012 19:42:12 +0400\r
+Message-ID: <878vjfkqaz.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 05 Mar 2012 15:43:45 -0000\r
+\r
+On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe <daniel@schoepe.org> wrote:\r
+> On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe <daniel@schoepe.org> wrote:\r
+> > > notmuch-saved-search-sort-function might destructively modify its\r
+> > > input (`sort' does that, for instance), so it should not be given\r
+> > > notmuch-saved-searches directly.\r
+> > > ---\r
+> > \r
+> > -1\r
+> > \r
+> > I think we should require `notmuch-saved-search-sort-function' not to\r
+> > have side effects. Current documentation should be more clear about\r
+> > this. We need to fix `notmuch-sort-saved-searches' to copy the list\r
+> > before calling `sort'. But we should not do it in\r
+> > `notmuch-hello-insert-saved-searches' for any sorting function (which\r
+> > may not need this copying).\r
+> \r
+> My reasoning was that since sort is such a common function, many users\r
+> will probably use sort for their own sorting functions, not realizing\r
+> that it has side effects. This will lead to confusing behavior that's\r
+> not so easy to track down.\r
+> \r
+> Copying the list of saved searches when running notmuch-hello does not\r
+> seem be relevant to performance to me, since it's a) not called that\r
+> often and b) the list of saved searches will rarely exceed 30 elements.\r
+> \r
+> Hence, this way we can avoid some headaches for users who define their\r
+> own sorting functions at a negligible (performance) cost. Incidentally,\r
+> this is also how notmuch-hello did it before the user-defined sections\r
+> patches.\r
+> \r
+\r
+I do not buy the argument that we should help users who implement their\r
+own sorting functions but do not read documentation for functions they\r
+use. Apparently, those who implemented the `sort' function had similar\r
+ideas. And I do not think it is our job to add workarounds for it.\r
+\r
+An alternative (and IMO better) solution would be to allow customization\r
+of compare function used for sorting instead of the sorting function\r
+itself.\r
+\r
+Regards,\r
+ Dmitry\r
+\r
+> Cheers,\r
+> Daniel\r
projects / notmuch-archives.git / commitdiff