Re: [PATCH 1/3] contrib: add notmuch-pick.el file itself

diff --git a/6b/28185a2f13192c63747a4992cbf4df4a186baf b/6b/28185a2f13192c63747a4992cbf4df4a186baf
new file mode 100644 (file)
index 0000000..772d3ef
--- /dev/null
+++ b/6b/28185a2f13192c63747a4992cbf4df4a186baf
@@ -0,0 +1,99 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7A594431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 10:39:08 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id NnCwQm6MT1Hq for <notmuch@notmuchmail.org>;\r
+       Sat, 27 Oct 2012 10:39:08 -0700 (PDT)\r
+Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com\r
+       [209.85.220.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 10735431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 10:39:08 -0700 (PDT)\r
+Received: by mail-vc0-f181.google.com with SMTP id n11so4236943vch.26\r
+       for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 10:39:07 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=DZg7TkyvLZKeAc8oufVXtPwWk+cHtC5wwBcXIkbt6JE=;\r
+       b=OBXrOCpvZ1tvMOClNuiY0dTaTlYzvBIDab2qpq3hAiBCMFkETWVuq9WRsY2dUeNFUA\r
+       eizfB/FTPCb0U065mE10sM1L+OHAfL22Y4JNqlFVsxIBDJqkItkama21lK9kwCGTc8ra\r
+       Z9nQXcyDVrxEGhmMMmEjw29u/KKXESYkr3jbSpI5OKuDFKPnj+8vFT8uis6nn9amQhe8\r
+       4eeoxMyKPApud6hqMjQ6tU/59qc/xDWAnYqP3X65HFx/lZeUxRgFO51ayltBX68Kez2Y\r
+       CBWpyRWgmxy5egv997YyZZyN42Ps4vp0lC/YRodYsqnLy/aVQvUDT8FKZ9RFlL3ao2bI\r
+       4iFA==\r
+Received: by 10.52.23.199 with SMTP id o7mr33951020vdf.129.1351359547468;\r
+       Sat, 27 Oct 2012 10:39:07 -0700 (PDT)\r
+Received: from smtp.gmail.com (cpe-74-70-7-64.nycap.res.rr.com. [74.70.7.64])\r
+       by mx.google.com with ESMTPS id\r
+       l15sm2773841vdt.14.2012.10.27.10.39.05\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sat, 27 Oct 2012 10:39:05 -0700 (PDT)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] contrib: add notmuch-pick.el file itself\r
+In-Reply-To: <1351337200-18050-2-git-send-email-markwalters1009@gmail.com>\r
+References: <1351337200-18050-1-git-send-email-markwalters1009@gmail.com>\r
+       <1351337200-18050-2-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 27 Oct 2012 13:39:04 -0400\r
+Message-ID: <87txtfhl1j.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 27 Oct 2012 17:39:08 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> +(defvar notmuch-pick-json-parser nil\r
+> +  "Incremental JSON parser for the search process filter.")\r
+> +\r
+> +(defun notmuch-pick-process-filter (proc string)\r
+> +  "Process and filter the output of \"notmuch show\" (for pick)"\r
+> +  (let ((results-buf (process-buffer proc))\r
+> +        (parse-buf (process-get proc 'parse-buf))\r
+> +        (inhibit-read-only t)\r
+> +        done)\r
+> +    (if (not (buffer-live-p results-buf))\r
+> +        (delete-process proc)\r
+> +      (with-current-buffer parse-buf\r
+> +        ;; Insert new data\r
+> +        (save-excursion\r
+> +          (goto-char (point-max))\r
+> +          (insert string)))\r
+> +      (with-current-buffer results-buf\r
+> +    (save-excursion\r
+> +      (goto-char (point-max))\r
+> +      (while (not done)\r
+> +        (condition-case nil\r
+> +            (case notmuch-pick-process-state\r
+\r
+This looks awfully familiar. Not looking too close, but why can't this\r
+re-use the JSON parser from your other patch? Just not to rely on the\r
+other patch series?\r
+\r
+Still, let's get this pushed.\r
+\r
+Ethan\r