Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

diff --git a/ee/5a04b5005249ddc5642a4a6933758fdd9d7959 b/ee/5a04b5005249ddc5642a4a6933758fdd9d7959
new file mode 100644 (file)
index 0000000..31aff96
--- /dev/null
+++ b/ee/5a04b5005249ddc5642a4a6933758fdd9d7959
@@ -0,0 +1,127 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 23421429E3B\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 12:07:05 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 2Pxw8bvMBQhj for <notmuch@notmuchmail.org>;\r
+       Sun, 29 Jan 2012 12:07:04 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7B988429E34\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 12:07:04 -0800 (PST)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id 24B4F66E0125;\r
+       Sun, 29 Jan 2012 12:07:04 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com\r
+       [76.174.137.84]) (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id 4BD1866E011F;\r
+       Sun, 29 Jan 2012 12:07:01 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id E2A8D35A; Sun, 29 Jan 2012 12:07:00 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other\r
+ toggles\r
+In-Reply-To: <1327486729-18052-1-git-send-email-dme@dme.org>\r
+References: <1327486729-18052-1-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.11+131~g7337d96 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 29 Jan 2012 12:06:57 -0800\r
+Message-ID: <87ehuiz31a.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 29 Jan 2012 20:07:05 -0000\r
+\r
+--=-=-=\r
+\r
+On Wed, 25 Jan 2012 10:18:46 +0000, David Edmondson <dme@dme.org> wrote:\r
+> The crypto toggle previously worked using an argument to\r
+> `notmuch-show' and various other functions and relied on killing and\r
+> re-creating the notmuch-show-mode buffer. Various other\r
+> pseudo-buffer-local variables were present based on an ad-hoc scheme.\r
+>\r
+> Replace the ad-hoc scheme with real buffer-local variables and then\r
+> update `notmuch-show-refresh-view' to erase and re-paint rather than\r
+> kill and re-create. Update the crypto switch accordingly.\r
+\r
+Hey, David.  Thank you so much for this!  I was really hoping someone\r
+would eventually pick this up, and your solution is great!  This new\r
+behavior is *much* nicer.  I really like it.\r
+\r
+I haven't done a full code review, though, just tested it out.  I may\r
+not be able to get to it for a while, so please don't hold this patch up\r
+on my account).\r
+\r
+> Add two other toggles:\r
+>     - whether non-matching messages are available,\r
+>     - the indentation of message contents.\r
+> Both of these default to the current behaviour.\r
+\r
+These new features enabled by this are very cool!  I love them both.  I\r
+bet there are other interesting toggle features that could be enabled by\r
+this.\r
+\r
+> My inclination is to remove `notmuch-crypto-process-mime' altogether\r
+> (declared it an obsolete variable) and allow users to set a default\r
+> for `notmuch-show-process-crypto' directly, but that is not done in\r
+> this patchset while awaiting feedback.\r
+\r
+I'm not sure I understand this.  `notmuch-show-process-crypto' *is* what\r
+sets the default for the `notmuch-show-process-crypto' buffer-local\r
+variable.  How would you change the current behavior or settings (beyond\r
+just a variable rename)?\r
+\r
+> `notmuch-crypto-process-mime' is used only in notmuch-show.el, so the\r
+> setting really belongs there with an appropriate name.\r
+\r
+I intentionally put this in a separate section in case there were\r
+eventually other needs for this setting beyond just show mode.  I\r
+personally think we should just leave it where it is, particularly since\r
+it's been there for a while.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPJabhAAoJEO00zqvie6q8+TQQAIqrSKxjk+j6XQVfw7ZKg6eo\r
+UHLy5BCh3I3NLwwSIf5lZR5OSUBOQQZ9qZ1dP8j4IwTWr88uq2OKR15HDqXr3453\r
+/OCu9HooirzBQN1THjOTusLsPz1gVlO3aEocNGEbFLHk5Ms9C3EcHdjrL4lqtv2s\r
+mSUBHKfUXSsnZSwqVqsUjRkgluKYZOP7o+aM3OEiSNt4lMIsBNsQdxv55vDcfhqS\r
+TsWXpH1ZsD8T6kNFteRA6MjVjYbEgFqstPx3x6GJ6rJroTYSI2+7O25FanFLG9to\r
+3/A7r/53f5R5WJOPvGCEnw3Uv4Df5wP5kJpDWXKzzk9gJAK6s8lxBoSSheQZwdIJ\r
+RqMy9cImoFotOsDYmKCXdpMUxna45IN8t+zeE7Zpo2e6WU/TZnYKPGDJTi1g04Fq\r
+xx2gdHbL5by451EHKrGUhAG6yc/sSfOWScbF3PgS/5+2r3qinSiMpnDvBSr7PUO1\r
+cRNCQOsu7WHeBwCd0vjAMrSzaWYFtjObDue/EPaBN5qC9KAvVzk06NorJcKi4GwE\r
+T9ZlF1SKpNhE3wq92agsM4L+KERpAXeYpxFIJdTAIICLcVMEBScnJ6eG4kmp8ROZ\r
+ADt1mn/Cyp2OPsjpituhAeynSCtshNreoJbpEvyvkXrU19HXv3AGDi92sz/UWVEA\r
+FB0eVmzZW8IwGN41g6W+\r
+=FTt5\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r