xdg*.eclass: move phase related logic to xdg.eclass
authorGilles Dartiguelongue <eva@gentoo.org>
Tue, 24 Nov 2015 17:42:27 +0000 (18:42 +0100)
committerGilles Dartiguelongue <eva@gentoo.org>
Tue, 24 Nov 2015 21:57:19 +0000 (22:57 +0100)
eclass/xdg-utils.eclass
eclass/xdg.eclass

index 112cce7795c71c59ec94de4f770926634d618fc5..5c765578f925595ae38baff1b8cc7bdf688e8ace 100644 (file)
@@ -62,17 +62,6 @@ xdg_environment_reset() {
        unset DBUS_SESSION_BUS_ADDRESS
 }
 
-# @FUNCTION: xdg_desktopfiles_savelist
-# @DESCRIPTION:
-# Find the .desktop files about to be installed and save their location
-# in the XDG_ECLASS_DESKTOPFILES environment variable.
-# This function should be called from pkg_preinst.
-xdg_desktopfiles_savelist() {
-       pushd "${D}" > /dev/null || die
-       export XDG_ECLASS_DESKTOPFILES=$(find 'usr/share/applications' -type f 2> /dev/null)
-       popd > /dev/null || die
-}
-
 # @FUNCTION: fdo-xdg_desktop_database_update
 # @DESCRIPTION:
 # Updates the .desktop files database.
@@ -85,27 +74,11 @@ xdg_desktop_database_update() {
                return
        fi
 
-       if [[ -z "${XDG_ECLASS_DESKTOPFILES}" ]]; then
-               debug-print "No .desktop files to add to database"
-               return
-       fi
-
        ebegin "Updating .desktop files database"
        "${updater}" -q "${EROOT}${DESKTOP_DATABASE_DIR}"
        eend $?
 }
 
-# @FUNCTION: xdg_mimeinfo_savelist
-# @DESCRIPTION:
-# Find the mime information files about to be installed and save their location
-# in the XDG_ECLASS_MIMEINFOFILES environment variable.
-# This function should be called from pkg_preinst.
-xdg_mimeinfo_savelist() {
-       pushd "${D}" > /dev/null || die
-       export XDG_ECLASS_MIMEINFOFILES=$(find 'usr/share/mime' -type f 2> /dev/null)
-       popd > /dev/null || die
-}
-
 # @FUNCTION: xdg_mimeinfo_database_update
 # @DESCRIPTION:
 # Update the mime database.
@@ -118,11 +91,6 @@ xdg_mimeinfo_database_update() {
                return
        fi
 
-       if [[ -z "${XDG_ECLASS_MIMEINFOFILES}" ]]; then
-               debug-print "No mime info files to add to database"
-               return
-       fi
-
        ebegin "Updating shared mime info database"
        "${updater}" "${EROOT}${MIMEINFO_DATABASE_DIR}"
        eend $?
index 799d6a2076ad1cd8739291da11b7c6060c63da9c..18138587b1433b0910e531711a7d0671f75833fd 100644 (file)
@@ -37,25 +37,45 @@ xdg_src_prepare() {
 
 # @FUNCTION: xdg_pkg_preinst
 # @DESCRIPTION:
-# Finds .desktop and mime info files for later handling in pkg_postinst
+# Finds .desktop and mime info files for later handling in pkg_postinst.
+# Locations are stored in XDG_ECLASS_DESKTOPFILES and XDG_ECLASS_MIMEINFOFILES
+# respectively.
 xdg_pkg_preinst() {
-       xdg_desktopfiles_savelist
-       xdg_mimeinfo_savelist
+       export XDG_ECLASS_DESKTOPFILES=( $(cd "${D}" && find 'usr/share/applications' -type f -print0 2> /dev/null) )
+       export XDG_ECLASS_MIMEINFOFILES=( $(cd "${D}" && find 'usr/share/mime' -type f -print0 2> /dev/null) )
 }
 
 # @FUNCTION: xdg_pkg_postinst
 # @DESCRIPTION:
 # Handle desktop and mime info database updates.
 xdg_pkg_postinst() {
-       xdg_desktop_database_update
-       xdg_mimeinfo_database_update
+       if [[ -n "${XDG_ECLASS_DESKTOPFILES}" ]]; then
+               xdg_desktop_database_update
+       else
+               debug-print "No .desktop files to add to database"
+       fi
+
+       if [[ -n "${XDG_ECLASS_MIMEINFOFILES}" ]]; then
+               xdg_mimeinfo_database_update
+       else
+               debug-print "No mime info files to add to database"
+       fi
 }
 
 # @FUNCTION: xdg_pkg_postrm
 # @DESCRIPTION:
 # Handle desktop and mime info database updates.
 xdg_pkg_postrm() {
-       xdg_desktop_database_update
-       xdg_mimeinfo_database_update
+       if [[ -n "${XDG_ECLASS_DESKTOPFILES}" ]]; then
+               xdg_desktop_database_update
+       else
+               debug-print "No .desktop files to add to database"
+       fi
+
+       if [[ -n "${XDG_ECLASS_MIMEINFOFILES}" ]]; then
+               xdg_mimeinfo_database_update
+       else
+               debug-print "No mime info files to add to database"
+       fi
 }