Re: [PATCH v4 1/6] config: Fix free in 'config get' implementation.

diff --git a/ff/84b6a3228448937063f92057e2b1dbd6a53a00 b/ff/84b6a3228448937063f92057e2b1dbd6a53a00
new file mode 100644 (file)
index 0000000..400aa4e
--- /dev/null
+++ b/ff/84b6a3228448937063f92057e2b1dbd6a53a00
@@ -0,0 +1,65 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 170BD431FC2\r
+       for <notmuch@notmuchmail.org>; Tue, 24 Apr 2012 19:29:36 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Cd3Ulvb6Idd9 for <notmuch@notmuchmail.org>;\r
+       Tue, 24 Apr 2012 19:29:35 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A1A72431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 24 Apr 2012 19:29:35 -0700 (PDT)\r
+Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.89.108] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)\r
+       (Exim 4.72) (envelope-from <bremner@unb.ca>)\r
+       id 1SMrz4-0000DE-Da; Tue, 24 Apr 2012 23:29:34 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.77)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1SMryx-00059p-Vc; Tue, 24 Apr 2012 23:29:27 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4 1/6] config: Fix free in 'config get' implementation.\r
+In-Reply-To: <1334367666-10954-2-git-send-email-novalazy@gmail.com>\r
+References: <1332282698-7951-1-git-send-email-novalazy@gmail.com>\r
+       <1334367666-10954-1-git-send-email-novalazy@gmail.com>\r
+       <1334367666-10954-2-git-send-email-novalazy@gmail.com>\r
+User-Agent: Notmuch/0.12+113~gde05574 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 24 Apr 2012 23:29:27 -0300\r
+Message-ID: <87haw8wnlk.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 25 Apr 2012 02:29:36 -0000\r
+\r
+Peter Wang <novalazy@gmail.com> writes:\r
+\r
+> The array returned by g_key_file_get_string_list() should be freed with\r
+> g_strfreev(), not free().\r
+\r
+Pushed this one patch from the series.\r
+\r
+d\r