--- /dev/null
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 56572431FBD\r
+ for <notmuch@notmuchmail.org>; Sun, 18 Nov 2012 13:55:56 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id b-ajqx+NimOc for <notmuch@notmuchmail.org>;\r
+ Sun, 18 Nov 2012 13:55:55 -0800 (PST)\r
+Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com\r
+ [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id D4136431FB6\r
+ for <notmuch@notmuchmail.org>; Sun, 18 Nov 2012 13:55:55 -0800 (PST)\r
+Received: by mail-qc0-f181.google.com with SMTP id x40so3164203qcp.26\r
+ for <notmuch@notmuchmail.org>; Sun, 18 Nov 2012 13:55:55 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ bh=/HKZfC1QBOVEMSc2efm5FR5i/r0NXl+pmoj8vWTLgao=;\r
+ b=LOc3d6RSpqZJ4t2Zkkv1Uxv2ZBuYppevQZKYWuodFLLDv8t46pciltDQhUxri388BI\r
+ Smo67Zn6QZ6clsS5RZba0WbeOvAL+Qv7hFq9KQYJ8rFGakvMmStlIKfjHu/Wiyq8U4p3\r
+ A+GbGQ5aOQqqxlgr+NylCDlCP05R38uVYDhFDZeID4oEDjFFb8k/3OpUDxIf0Lho4VWB\r
+ 6MpxNzU2K9pwvho2pPg6AHu+Fsbse0Yziy838J7du+5cn/Wfa+cNGLYJutnguyrACJrk\r
+ shzzBb5CVRreMBdNqbhGbjEkxYqpOhEQ05X4lJW3DSrhkqZ5l89ssJr7mXOV4i9cLdGK\r
+ xKTg==\r
+Received: by 10.49.2.74 with SMTP id 10mr11599665qes.10.1353275755225;\r
+ Sun, 18 Nov 2012 13:55:55 -0800 (PST)\r
+Received: from smtp.gmail.com ([66.114.71.21])\r
+ by mx.google.com with ESMTPS id la6sm4366443qeb.8.2012.11.18.13.55.45\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Sun, 18 Nov 2012 13:55:46 -0800 (PST)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: Add new dump/restore format and batch tagging.\r
+In-Reply-To: <1353265498-3839-1-git-send-email-david@tethera.net>\r
+References: <1353265498-3839-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/24.1.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 18 Nov 2012 16:55:43 -0500\r
+Message-ID: <87obiu1sps.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 18 Nov 2012 21:55:56 -0000\r
+\r
+david@tethera.net writes:\r
+\r
+> which was revied by Tomi and Ethan. I think I implemented their\r
+> suggestions.\r
+\r
+Actually, I don't think you implemented all of mine.\r
+\r
+- Patch 4 still has a subject line that ends in a period. I don't think\r
+ this is mandatory for everyone but some people consider it best\r
+ practice. You still have the spelling "seperate" (also, patch 7 has\r
+ "seperated").\r
+\r
+- In patch 4, I still think this would look better if you switched the\r
+ branches.\r
+\r
++ if (private_status == NOTMUCH_PRIVATE_STATUS_NO_DOCUMENT_FOUND) {\r
++ _notmuch_message_add_term (message, "type", "mail");\r
++ } else {\r
++ return NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID;\r
++ }\r
+\r
+- In patch 5, I still think this looks funny:\r
+\r
++ int num_tags = random () % (max_tags + 1);\r
++ int this_mid_len = random () % message_id_len + 1;\r
+\r
+Additionally, I would like a check that message_id_len is reasonable\r
+(more than 1, say).\r
+\r
+- Patch 8:\r
+\r
++int\r
++parse_tag_stream (void *ctx,\r
++ notmuch_database_t *notmuch,\r
++ FILE *input,\r
++ tag_callback_t callback,\r
++ tag_op_flag_t flags,\r
++ volatile sig_atomic_t *interrupted);\r
+\r
+Am I going crazy, or does this function not get implemented?\r
+\r
+- Patch 11: DUMP_FORMAT can change from DUMP_FORMAT_BATCH_TAG to\r
+ DUMP_FORMAT_SUP if a paren is anywhere on the first line. I'd prefer\r
+ this only happens if we have DUMP_FORMAT_AUTO.\r
+\r
+You probably want to move the comment "Dump output is..." closer to the\r
+regex.\r
+\r
+I don't see why it's necessary to have this:\r
+\r
++ query_string = query_string + 3;\r
+\r
+- Patch 13:\r
+\r
++ cp /dev/null EXPECTED.$test_count\r
++ notmuch dump --format=batch-tag -- from:cworth |\\r
++ awk "{ print \"+$enc1 +$enc2 +$enc3 -- \" \$5 }" > EXPECTED.$test_count\r
+\r
+What's the purpose of the CP here? It just creates an empty file. You\r
+could do it with touch. Why even bother since you're going to fill it\r
+with stuff in a second? Actually, care to explain the dump and sed call?\r
+It looks like you're using this dump to encode the message IDs. If\r
+format=batch-tag skips a message for some reason or terminates early,\r
+the test won't fail.\r
+\r
+- Patch 16:\r
+\r
++message-ids may contained arbitrary non-null characters. Note also\r
+\r
+I think this should be "may contain", or something else entirely if\r
+you're trying to describe past behavior of sup?\r
+\r
+Ethan\r
projects / notmuch-archives.git / commitdiff