--- /dev/null
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id F2A77431FBC\r
+ for <notmuch@notmuchmail.org>; Mon, 12 Mar 2012 13:03:20 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id UMCuxtBlz4hi for <notmuch@notmuchmail.org>;\r
+ Mon, 12 Mar 2012 13:03:18 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+ [131.215.239.19])\r
+ by olra.theworths.org (Postfix) with ESMTP id A5F72431FAF\r
+ for <notmuch@notmuchmail.org>; Mon, 12 Mar 2012 13:03:18 -0700 (PDT)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+ by fire-doxen-postvirus (Postfix) with ESMTP id 0EAD02E50D4F;\r
+ Mon, 12 Mar 2012 13:03:18 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (gwave-92.ligo.caltech.edu [131.215.114.92])\r
+ (Authenticated sender: jrollins)\r
+ by fire-doxen-submit (Postfix) with ESMTP id 443232E50BEE;\r
+ Mon, 12 Mar 2012 13:03:15 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+ id 29765762; Mon, 12 Mar 2012 13:03:15 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/2] A bug in the exclude code\r
+In-Reply-To: <1331551914-28323-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1331551914-28323-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.11.1+266~gadb05cc (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 12 Mar 2012 13:03:12 -0700\r
+Message-ID: <87r4wx7fjz.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+ micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 12 Mar 2012 20:03:21 -0000\r
+\r
+--=-=-=\r
+\r
+On Mon, 12 Mar 2012 11:31:52 +0000, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> There is a bug in the exclude code (found by jrollins in the\r
+> --with-excluded series) but also present in master. None of the\r
+> current tests were finding it so the first patch adds two tests.\r
+\r
+Hey, Mark. Thanks so much for looking in to this. It look like this\r
+patch fixes the issue for me too! Very excited to see this all coming\r
+together.\r
+\r
+> The bug (and test failure) do not appear in all configuations: on my\r
+> main test machine (an oldish debian testing 32bit userspace with a\r
+> 64bit kernel and xapian 1.2.7) all tests pass. On my laptop (a recent\r
+> debian testing 64bit userspace and xapian 1.2.8) one of the new tests\r
+> fails.\r
+\r
+It was failing for me too, but looking closer at the test I actually\r
+found a bug: you accidentally used the old style --no-exclude option,\r
+instead of the new --with-excludes. When you fix the call all the tests\r
+pass fine.\r
+\r
+> The second patch fixes the behaviour for me but I don't see why it\r
+> should make a difference: searches for A and not B should give the\r
+> same results as A and not (A and B). It could be a bug in xapian, it\r
+> could be that I am not allowed to reuse queries as I do (is query1 =\r
+> query1 and query2 allowed?) or it could be some memory use bug on my\r
+> part.\r
+\r
+I can't explain it either, but there's certainly a lot about xapian that\r
+I don't understand. Maybe one of the xapian gurus will have some ideas\r
+(Olly? Austin?).\r
+\r
+Anyway, thanks again for pushing on all of this, Mark.\r
+\r
+jamie.\r
+\r
+PS. Not a big deal, but it would have been nice for this patch set to\r
+have been sent in-reply-to the original series it fixes, just to keep\r
+everything together.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPXlaAAAoJEO00zqvie6q898EQAJLAYwv2+PhThqNL1vhEsw1f\r
+xlxagA1g1UID0dnBJ+ft7fAgM81ieVdn5y6SHaLcgAgaWCTbPlClVcJSFeSAYi6P\r
+F2bylBVxVi3vh6E2D63tQSwWTktNeBDv8tkjbsknbfVbWuSIHRc0+MM1caG1CMmS\r
+r2FVkRijCqcW3MurZf03YTQDiWveKKbuH80kwgiV/s+iQI9BpXeu+i4p17/5Yur+\r
+Zjz6jXR5kEmnB8pbxe/PuHbN78Epq2Yl0c8Mzov7/L6ctMv59NbLaVtn1bpC+BNJ\r
+9b4n43lcZ99fd7WUiVlu0VCR1zPSKaFN8aThS9NwVdId98MfwFugwmiZTGlG3T5J\r
+YtkcWOkAWyi16+FLHphafAmUhBJCzzyk+UXzqy0l6mi9X1ehPNxocNejM4XjJPTR\r
+mY7EsXk4ZP31gMXPjuW9DLPlNLYILAsR8MUylrD3jJ5pqBeGsMgLFrKzpV7Hz9QU\r
+2k5gqgGx/Zzfsock0Ft76CUdwk5jIQ9Fi8EysHOr4hmpmA/DFBdAe7k3dR21zXzK\r
+c8KIQ+r4IfEoO7zVAQHxY/hbDC282d3ZdwQOTKQbJhYFoRrBcUFv3s1ew/8FK9TA\r
+4SXcNz3YkU58ott6EQv29fHjWzFVyW92LVks4b9sqs4XNdePgseYSqbTP9hJpsgv\r
+Op/xZ5hxU4gs7m0H24wr\r
+=lL1+\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r
projects / notmuch-archives.git / commitdiff