Re: [PATCH] emacs: Fix "not defined at runtime" warning

diff --git a/8a/296db0828c5e31509b062c74df05fdbb839e2d b/8a/296db0828c5e31509b062c74df05fdbb839e2d
new file mode 100644 (file)
index 0000000..342c54a
--- /dev/null
+++ b/8a/296db0828c5e31509b062c74df05fdbb839e2d
@@ -0,0 +1,113 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 75454431FAF\r
+       for <notmuch@notmuchmail.org>; Thu,  9 Aug 2012 07:13:51 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id EMXdIqB+-vpR for <notmuch@notmuchmail.org>;\r
+       Thu,  9 Aug 2012 07:13:51 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU\r
+       [18.9.25.12])\r
+       by olra.theworths.org (Postfix) with ESMTP id D34FC431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  9 Aug 2012 07:13:50 -0700 (PDT)\r
+X-AuditID: 1209190c-b7f806d000006b87-a4-5023c59eb429\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+       by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 4D.07.27527.E95C3205; Thu,  9 Aug 2012 10:13:50 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q79EDnHw025112; \r
+       Thu, 9 Aug 2012 10:13:50 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q79EDl5B023933\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Thu, 9 Aug 2012 10:13:49 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SzTUg-0001bF-SU; Thu, 09 Aug 2012 10:13:46 -0400\r
+Date: Thu, 9 Aug 2012 10:13:46 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>\r
+Subject: Re: [PATCH] emacs: Fix "not defined at runtime" warning\r
+Message-ID: <20120809141346.GH11179@mit.edu>\r
+References: <1344462010-5349-1-git-send-email-amdragon@mit.edu>\r
+       <87628sa4a8.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87628sa4a8.fsf@servo.finestructure.net>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hTV1p13VDnA4NU7aYs9+7wsrt+cyezA\r
+       5HH3NJfHs1W3mAOYorhsUlJzMstSi/TtErgylj6ZwVxwmKvi3PLfLA2MKzm6GDk5JARMJLpX\r
+       PGCBsMUkLtxbz9bFyMUhJLCPUWLHnUZ2CGc9o8TcI9+YIZwTTBINZ9cxQjhLGCU2HNrABNLP\r
+       IqAi0bh1BZjNJqAhsW3/ckYQW0TATKLnyx8wm1lAWuLb72awGmEBB4mDW5ezgti8AjoSGxc0\r
+       s4PYQgJZElfvb2eDiAtKnJz5hAWiV0vixr+XQL0cYHOW/wN7gVPAVKJp+TawVlGgE6ac3MY2\r
+       gVFoFpLuWUi6ZyF0L2BkXsUom5JbpZubmJlTnJqsW5ycmJeXWqRrqJebWaKXmlK6iREc1JI8\r
+       OxjfHFQ6xCjAwajEw3tprVKAEGtiWXFl7iFGSQ4mJVFetv3KAUJ8SfkplRmJxRnxRaU5qcWH\r
+       GCU4mJVEeO/0AeV4UxIrq1KL8mFS0hwsSuK8l1Nu+gsJpCeWpGanphakFsFkZTg4lCR41x0B\r
+       ahQsSk1PrUjLzClBSDNxcIIM5wEafgmkhre4IDG3ODMdIn+KUVFKnDcLJCEAksgozYPrhSWd\r
+       V4ziQK8I8+4FqeIBJiy47ldAg5mABh8WVQIZXJKIkJJqYJR5WX36DN/x3rIVr/d/fzih7lB1\r
+       cHvRRm4muXq33o0Lar4fyPVI2qKz5O/jWFE54Swew3Zt04ViTHxMAWGqHKHGVy9PXep+fvvk\r
+       Z2ozJKQ6nv2tb54ettNAZJvRKu8onvpwm8Nv/92oi6h6l7PWKO8uT1Sgz47Qk5L33k/9PZPR\r
+       y95/CbvCXyWW4oxEQy3mouJEAGP8D/0VAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 09 Aug 2012 14:13:51 -0000\r
+\r
+Quoth Jameson Graef Rollins on Aug 09 at 12:54 am:\r
+> On Wed, Aug 08 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > Previously, the Emacs byte compiler produced the warning\r
+> >\r
+> >     the function `remove-if-not' might not be defined at runtime.\r
+> >\r
+> > because we only required cl at compile-time (not runtime).  This fixes\r
+> > this warning by requiring cl at runtime, ensuring that the definition\r
+> > of remove-if-not is available.\r
+> > ---\r
+> >  emacs/notmuch-lib.el |    2 +-\r
+> >  1 file changed, 1 insertion(+), 1 deletion(-)\r
+> >\r
+> > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el\r
+> > index 30db58f..900235b 100644\r
+> > --- a/emacs/notmuch-lib.el\r
+> > +++ b/emacs/notmuch-lib.el\r
+> > @@ -24,7 +24,7 @@\r
+> >  (require 'mm-view)\r
+> >  (require 'mm-decode)\r
+> >  (require 'json)\r
+> > -(eval-when-compile (require 'cl))\r
+> > +(require 'cl)\r
+> >  \r
+> >  (defvar notmuch-command "notmuch"\r
+> >    "Command to run the notmuch binary.")\r
+> \r
+> LGTM.  I think it would be good to finally just give in a require cl, so\r
+> we can finally put to rest the long standing schizophrenia we've had in\r
+> regards to using it, and maybe finally kill the compile warnings that\r
+> keep popping up.\r
+\r
+I think we already gave in [0], we just weren't very thorough about\r
+it.\r
+\r
+[0] id:"m262g864dz.fsf@wal122.wireless-pennnet.upenn.edu"\r