Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch

diff --git a/05/2721f350b6c469ae60da96a709a0f0ecd15ddf b/05/2721f350b6c469ae60da96a709a0f0ecd15ddf
new file mode 100644 (file)
index 0000000..241f001
--- /dev/null
+++ b/05/2721f350b6c469ae60da96a709a0f0ecd15ddf
@@ -0,0 +1,102 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0D2A2431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 13 Sep 2012 05:48:19 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id QHhGANjtu+wA for <notmuch@notmuchmail.org>;\r
+       Thu, 13 Sep 2012 05:48:17 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id BF299431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 13 Sep 2012 05:48:17 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id A114510036F;\r
+       Thu, 13 Sep 2012 15:48:24 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Michal Nazarewicz <mina86@mina86.com>, Jani Nikula <jani@nikula.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to\r
+       notmuch\r
+In-Reply-To: <xa1tvcfidvpe.fsf@mina86.com>\r
+References: <cover.1347484177.git.jani@nikula.org>\r
+       <89741ec9a9687fca8b30aa1a4877392d355dd3ce.1347484177.git.jani@nikula.org>\r
+       <xa1tvcfidvpe.fsf@mina86.com>\r
+User-Agent: Notmuch/0.13.2+162~ged38330 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 13 Sep 2012 15:48:24 +0300\r
+Message-ID: <m2oblajdgn.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 13 Sep 2012 12:48:19 -0000\r
+\r
+On Thu, Sep 13 2012, Michal Nazarewicz <mina86@mina86.com> wrote:\r
+\r
+> On Wed, Sep 12 2012, Jani Nikula <jani@nikula.org> wrote:\r
+>> Add a date/time parser to notmuch, to be used for adding date range\r
+>> query support for notmuch lib later on. Add the parser to a directory\r
+>> of its own to make it independent of the rest of the notmuch code\r
+>> base.\r
+>>\r
+>> Signed-off-by: Jani Nikula <jani@nikula.org>\r
+>\r
+> Have you consider doing the same in bison?  I consider the code totally\r
+> unreadable and unmaintainable.\r
+\r
+Well, I don't find this code 'unreadable', perhaps it depends how you\r
+define it ;)\r
+\r
+This functionality has been in 'work-in-progress' for a long time. I think\r
+the interface how this (separate library) is hooked to notmuch is sane.\r
+Also, my 'hunch' is that this is maintainable enough (and Jani will do\r
+all expected 'zero' maintenaince issues that will appear). If, in the\r
+future, there is enough desire for internationalization then Someone(TM)\r
+may see the way to do it.\r
+\r
+But, for the time being I applause the hard work Jani has put into=20\r
+this library and as it is much better what we have now (i.e. nothing)\r
+I am going to start testing this (and drop my current wrapper which\r
+I've been using to search using relative times)...\r
+\r
+It might be interesting to see this implemented in Bison but just for\r
+the sake of it I don't think it is worth of it. Maybe, someday...,\r
+Someone Else(tm) does that. The interface should allow to make drop-in\r
+replacement for this parser...\r
+\r
+Tomi\r
+\r
+\r
+>\r
+> --=20\r
+> Best regards,                                         _     _\r
+> .o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o\r
+> ..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz =\r
+   (o o)\r
+> ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--_______=\r
+________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r