--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id C274C431FC0\r
+ for <notmuch@notmuchmail.org>; Tue, 20 Mar 2012 18:33:15 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 24H-d0Z9a8gS for <notmuch@notmuchmail.org>;\r
+ Tue, 20 Mar 2012 18:33:13 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 56EBD431FAF\r
+ for <notmuch@notmuchmail.org>; Tue, 20 Mar 2012 18:33:13 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SAAQJ-0007xD-DF; Wed, 21 Mar 2012 01:33:11 +0000\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SAAQJ-0001h1-2n; Wed, 21 Mar 2012 01:33:11 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>,\r
+ Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+Subject: Re: [PATCH v2 4/6] emacs: add optional predicate arg to\r
+ `notmuch-show-mapc'\r
+In-Reply-To: <1330122640-18895-5-git-send-email-pieter@praet.org>\r
+References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca>\r
+ <1330122640-18895-1-git-send-email-pieter@praet.org>\r
+ <1330122640-18895-5-git-send-email-pieter@praet.org>\r
+User-Agent: Notmuch/0.12+67~g3bd579a (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 21 Mar 2012 01:33:23 +0000\r
+Message-ID: <87vclywxek.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 6534a7ea8e0a3ce3bc264c37708c922b (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 21 Mar 2012 01:33:15 -0000\r
+\r
+On Fri, 24 Feb 2012 23:30:38 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> * emacs/notmuch-show.el (notmuch-show-mapc):\r
+> \r
+> If provided with optional argument PREDICATE, only call\r
+> FUNCTION if calling PREDICATE returns non-nil.\r
+> \r
+> Also correct original docstring: 's/thread/buffer/'.\r
+> ---\r
+> emacs/notmuch-show.el | 14 ++++++++++----\r
+> 1 files changed, 10 insertions(+), 4 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index aa9ccee..6adbdc0 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1272,13 +1272,19 @@ (defun notmuch-show-goto-message-previous ()\r
+> (notmuch-show-move-to-message-top)\r
+> t))\r
+> \r
+> -(defun notmuch-show-mapc (function)\r
+> - "Iterate through all messages in the current thread with\r
+> +(defun notmuch-show-mapc (function &optional predicate)\r
+> + "Iterate through all messages in the current buffer with\r
+> `notmuch-show-goto-message-next' and call FUNCTION for side\r
+> -effects."\r
+> +effects.\r
+> +\r
+> +If provided with optional argument PREDICATE, only call\r
+> +FUNCTION if calling PREDICATE returns non-nil."\r
+> (save-excursion\r
+> (goto-char (point-min))\r
+> - (loop do (funcall function)\r
+> + (loop do (if predicate\r
+> + (if (funcall predicate)\r
+> + (funcall function))\r
+> + (funcall function))\r
+> while (notmuch-show-goto-message-next))))\r
+> \r
+> ;; Functions relating to the visibility of messages and their\r
+\r
+The change looks fine.\r
+\r
+The original function feels a little fragile to me as to what happens if\r
+predicate or function move point. Eg what happens if function collapses\r
+the message: where does point go, and so where does\r
+notmuch-show-goto-message-next go. Is this just my naivete as a lisp\r
+beginner? Is there someway of writing it so the user doesn't need to\r
+worry about such things?\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+(sorry for the duplicate mail: I sent the first message from the wrong address)\r
+\r
projects / notmuch-archives.git / commitdiff