Re: [PATCH v2] contrib: pick: bugfix when trying to show a non-message

diff --git a/72/ea2d962f50463bdcaa4d279cb8e88abd079913 b/72/ea2d962f50463bdcaa4d279cb8e88abd079913
new file mode 100644 (file)
index 0000000..1aafec2
--- /dev/null
+++ b/72/ea2d962f50463bdcaa4d279cb8e88abd079913
@@ -0,0 +1,78 @@
+Return-Path: <kimminh.kaplan+nomuch@afnic.fr>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 323C1431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 12 Nov 2012 23:46:53 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Yo8eos0ID-Zt for <notmuch@notmuchmail.org>;\r
+       Mon, 12 Nov 2012 23:46:52 -0800 (PST)\r
+Received: from mx4.nic.fr (mx4.nic.fr [192.134.4.12])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6EAE1431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 12 Nov 2012 23:46:52 -0800 (PST)\r
+Received: from mx4.nic.fr (localhost [127.0.0.1])\r
+       by mx4.nic.fr (Postfix) with SMTP id B38A82802BD;\r
+       Tue, 13 Nov 2012 08:46:48 +0100 (CET)\r
+Received: from relay2.nic.fr (relay2.nic.fr [192.134.4.163])\r
+       by mx4.nic.fr (Postfix) with ESMTP id AE9FA280136;\r
+       Tue, 13 Nov 2012 08:46:48 +0100 (CET)\r
+Received: from kaki.tech.prive.nic.fr (kaki.tech.prive.sqy.nic.fr\r
+       [10.10.86.114]) by relay2.nic.fr (Postfix) with ESMTP id AD28CB38004;\r
+       Tue, 13 Nov 2012 08:46:18 +0100 (CET)\r
+Received: by kaki.tech.prive.nic.fr (Postfix, from userid 1000)\r
+       id 860DC3F8225; Tue, 13 Nov 2012 07:46:18 +0000 (UTC)\r
+From: Kim Minh Kaplan <kimminh.kaplan+nomuch@afnic.fr>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH v2] contrib: pick: bugfix when trying to show a\r
+ non-message\r
+References: <1352562350-8219-1-git-send-email-markwalters1009@gmail.com>\r
+Date: Tue, 13 Nov 2012 07:46:18 +0000\r
+In-Reply-To: <1352562350-8219-1-git-send-email-markwalters1009@gmail.com>\r
+       (Mark Walters's message of "Sat, 10 Nov 2012 15:45:50 +0000")\r
+Message-ID: <87haou54j9.fsf@kaki.tech.prive.nic.fr>\r
+User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 13 Nov 2012 07:46:53 -0000\r
+\r
+Mark Walters writes:\r
+\r
+David Bremner writes:\r
+\r
+> Mark Walters <markwalters1009@gmail.com> writes:\r
+>\r
+>> This version changes the `when' to and `if' and adds the fix for the\r
+>> quoting.\r
+>>\r
+>> +    (if id\r
+>> +      (notmuch-id-to-query id))\r
+\r
+> Sorry to be such a pedant about this. Is it obvious to other people that \r
+> (if nil 'something) evaluates to nil?\r
+\r
+The obvious would be:\r
+\r
+    (and id\r
+         (notmuch-id-to-query id))\r
+\r
+Kim Minh.\r