Re: [PATCH v2 1/3] cli: refactor "notmuch tag" data structures for tagging operations

diff --git a/cf/2e18d9f48300ce523d688c69b4d4de1e511132 b/cf/2e18d9f48300ce523d688c69b4d4de1e511132
new file mode 100644 (file)
index 0000000..554e50b
--- /dev/null
+++ b/cf/2e18d9f48300ce523d688c69b4d4de1e511132
@@ -0,0 +1,99 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C944F431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 26 Mar 2012 08:14:46 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id H1D9Yy6JYpWV for <notmuch@notmuchmail.org>;\r
+       Mon, 26 Mar 2012 08:14:44 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4B6BB431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 26 Mar 2012 08:14:44 -0700 (PDT)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id DF01066E0131;\r
+       Mon, 26 Mar 2012 08:14:43 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (pool-108-27-62-184.nycmny.fios.verizon.net\r
+       [108.27.62.184]) (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id 17F0D66E012B;\r
+       Mon, 26 Mar 2012 08:14:38 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 63951573; Mon, 26 Mar 2012 08:14:36 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 1/3] cli: refactor "notmuch tag" data structures for\r
+       tagging operations\r
+In-Reply-To:\r
+ <0862d8a5424d6d0da188db84340b027fdede4245.1332702915.git.jani@nikula.org>\r
+References: <cover.1332702915.git.jani@nikula.org>\r
+       <0862d8a5424d6d0da188db84340b027fdede4245.1332702915.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.11.1+335~gf868783 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 26 Mar 2012 08:14:33 -0700\r
+Message-ID: <878vinl7hi.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 26 Mar 2012 15:14:46 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Sun, 25 Mar 2012 22:18:43 +0300, Jani Nikula <jani@nikula.org> wrote:\r
+> To simplify code, keep all tagging operations in a single array\r
+> instead of separate add and remove arrays. Apply tag changes in the\r
+> order specified on the command line, instead of first removing and\r
+> then adding the tags.\r
+>=20\r
+> This results in a minor functional change: If a tag is both added and\r
+> removed, the last specified operation is now used. Previously the tag\r
+> was always added.\r
+\r
+If this changes the behavior of notmuch then I think there should be a\r
+test for it.  We should probably see a test for the current behavior,\r
+and a modification of it to reflect whatever behavior is changing.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPcIfaAAoJEO00zqvie6q8DUoP/i09AJTQPYa85aSwIJs0vHbv\r
+KSzDyzVrHGq6rsr46UraziOFKZEJ+Gv+IFY2Ah70qsuU+1SG+I2zmwUhGgwM1whq\r
+KqIeBjfNbOOYt4A8r78qic3GdFSpex9WG5Yacb6Svud5ZA9oWcdk+6aGMSvihWDo\r
+jdz1ItDWZpBCHPeouaIqley2kgxgOKVY2Nb0TyUfpyFBjN63GN5rFaBwAnalB9d4\r
+DvMwqfrc3+AjGlm0jcpSNcZ7Li9419kvBIQ1pRCk/rA1jzhkCEZsRBofnYMEuKH8\r
+pEXZw+Ur7wLSaiaChGKUrJXDa7KIdV+UR0jBrgjs763a3y6F9mH3So4sad1bQKCn\r
+8xT6iObYTA/PUevUpJw0AHRViOGVZIUvgF6ydGQT6RyYerjlW+lBMGUb8bSBtHFP\r
+bpKan2tu6s2E5TPksbC4UxXfB0E5uo1o4M5barsLRNYDu3Ws1i3Z6sFnxbge56fE\r
+0SxDHriTAhjejtcecEOr2gd8066LpkQBZZVy0/l5fTvJnmw94+djYqy1XjZilbXP\r
+tJ4NmQDvSeM6w/daQBGGx2s1F2v59j4/nOxzjM7P+DrvW9PzPfDrUjPEvlcOKjDA\r
+IaDxFfelfmK6M+nQ9bNxJEiCZsmHSjSxRK4XWzx2T8p+fS8nO2YFI4u0OOsQEQwv\r
+heb48oqFSMS6pcZF/zvY\r
+=ecVs\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r