--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 5D1A0403E4E\r
+ for <notmuch@notmuchmail.org>; Mon, 9 Apr 2012 11:39:31 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 6CKnPaw9dCg2 for <notmuch@notmuchmail.org>;\r
+ Mon, 9 Apr 2012 11:39:30 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 64752429E44\r
+ for <notmuch@notmuchmail.org>; Mon, 9 Apr 2012 11:39:30 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SHJUs-0007KL-84; Mon, 09 Apr 2012 19:39:28 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SHJUr-00049j-Rx; Mon, 09 Apr 2012 19:39:26 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 5/8] emacs: modify search tag functions to use new\r
+ notmuch-tag interface\r
+In-Reply-To: <1333845338-22960-6-git-send-email-jrollins@finestructure.net>\r
+References: <1333354853-25729-1-git-send-email-jrollins@finestructure.net>\r
+ <1333845338-22960-1-git-send-email-jrollins@finestructure.net>\r
+ <1333845338-22960-2-git-send-email-jrollins@finestructure.net>\r
+ <1333845338-22960-3-git-send-email-jrollins@finestructure.net>\r
+ <1333845338-22960-4-git-send-email-jrollins@finestructure.net>\r
+ <1333845338-22960-5-git-send-email-jrollins@finestructure.net>\r
+ <1333845338-22960-6-git-send-email-jrollins@finestructure.net>\r
+User-Agent: Notmuch/0.12+111~g5c30f66 (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 09 Apr 2012 19:39:43 +0100\r
+Message-ID: <871unwn40g.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 34e9d1bb4f60377bf589deafabb2a391 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 09 Apr 2012 18:39:31 -0000\r
+\r
+On Sun, 08 Apr 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> The main change here is to modify argument parsing so as to not force\r
+> tag-changes to be a list, and to let notmuch-tag handle prompting the\r
+> user when required. doc strings are also updated and cleaned up.\r
+> ---\r
+> emacs/notmuch.el | 36 +++++++++++++-----------------------\r
+> 1 files changed, 13 insertions(+), 23 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index 9aec96d..a03a526 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -523,13 +523,10 @@ and will also appear in a buffer named \"*Notmuch errors*\"."\r
+> See `notmuch-search-tag-region' for details."\r
+> (apply 'notmuch-search-tag-region (point) (point) tag-changes))\r
+> \r
+> -(defun notmuch-search-tag-region (beg end &rest tag-changes)\r
+> - "Change tags for threads in the given region.\r
+> -\r
+> -TAGS is a list of tag operations for `notmuch-tag'. The tags are\r
+> -added or removed for all threads in the region from BEG to END."\r
+> +(defun notmuch-search-tag-region (beg end &optional tag-changes)\r
+> + "Change tags for threads in the given region."\r
+> (let ((search-string (notmuch-search-find-thread-id-region-search beg end)))\r
+> - (apply 'notmuch-tag search-string tag-changes)\r
+> + (setq tag-changes (funcall 'notmuch-tag search-string tag-changes))\r
+> (save-excursion\r
+> (let ((last-line (line-number-at-pos end))\r
+> (max-line (- (line-number-at-pos (point-max)) 2)))\r
+> @@ -539,14 +536,14 @@ added or removed for all threads in the region from BEG to END."\r
+> (notmuch-update-tags (notmuch-search-get-tags) tag-changes))\r
+> (forward-line))))))\r
+> \r
+> -(defun notmuch-search-tag (&optional initial-input)\r
+> - "Change tags for the currently selected thread or region."\r
+> +(defun notmuch-search-tag (&optional tag-changes)\r
+> + "Change tags for the currently selected thread or region.\r
+> +\r
+> +See `notmuch-tag' for information on the format of TAG-CHANGES."\r
+> (interactive)\r
+> (let* ((beg (if (region-active-p) (region-beginning) (point)))\r
+> - (end (if (region-active-p) (region-end) (point)))\r
+> - (search-string (notmuch-search-find-thread-id-region-search beg end))\r
+> - (tags (notmuch-read-tag-changes initial-input search-string)))\r
+> - (apply 'notmuch-search-tag-region beg end tags)))\r
+> + (end (if (region-active-p) (region-end) (point))))\r
+> + (funcall 'notmuch-search-tag-region beg end tag-changes)))\r
+> \r
+> (defun notmuch-search-add-tag ()\r
+> "Same as `notmuch-search-tag' but sets initial input to '+'."\r
+> @@ -790,18 +787,11 @@ non-authors is found, assume that all of the authors match."\r
+> (goto-char found-target)))\r
+> (delete-process proc))))\r
+> \r
+> -(defun notmuch-search-tag-all (&rest tag-changes)\r
+> - "Add/remove tags from all matching messages.\r
+> +(defun notmuch-search-tag-all (&optional tag-changes)\r
+> + "Add/remove tags from all messages in current search buffer.\r
+> \r
+> -This command adds or removes tags from all messages matching the\r
+> -current search terms. When called interactively, this command\r
+> -will prompt for tags to be added or removed. Tags prefixed with\r
+> -'+' will be added and tags prefixed with '-' will be removed.\r
+> -\r
+> -Each character of the tag name may consist of alphanumeric\r
+> -characters as well as `_.+-'.\r
+> -"\r
+> - (interactive (notmuch-read-tag-changes))\r
+> +See `notmuch-tag' for information on the format of TAG-CHANGES."\r
+> + (interactive)\r
+> (apply 'notmuch-tag notmuch-search-query-string tag-changes))\r
+\r
+My only comment here is that I wonder about the tag-all command. I can\r
+see that this is a performance win over applying tag region to the whole\r
+buffer but is it another place where we have a race with incoming mail\r
+(ie we tag everything that now matches rather than everything in the\r
+buffer).\r
+\r
+A second advantage with the tag-region form is that it automatically\r
+does excludes. Currently notmuch-tag does not do excludes as it looked\r
+very hairy to implement correctly: thus the tag-all command could spend\r
+a lot of time tagging excluded messages.\r
+\r
+OTOH this seems to be a "feature" of the existing code so a "fix" is not\r
+required for this series.\r
+\r
+(Note I would not consider this a full review as my lisp is not good\r
+enough; eg I am unsure why the change from apply to funcall was\r
+needed).\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+> \r
+> (defun notmuch-search-buffer-title (query)\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff