Re: [PATCH v4 0/7] cli: improved crypto internals

diff --git a/77/ec978de1e85e06018fb8accbf087bc1e64aa3b b/77/ec978de1e85e06018fb8accbf087bc1e64aa3b
new file mode 100644 (file)
index 0000000..99afdd6
--- /dev/null
+++ b/77/ec978de1e85e06018fb8accbf087bc1e64aa3b
@@ -0,0 +1,88 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B56FF431FBC\r
+       for <notmuch@notmuchmail.org>; Fri, 25 May 2012 07:44:06 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id GJnmCLKTejrU for <notmuch@notmuchmail.org>;\r
+       Fri, 25 May 2012 07:44:06 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU\r
+       [18.7.68.37])\r
+       by olra.theworths.org (Postfix) with ESMTP id 462B3431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 25 May 2012 07:44:06 -0700 (PDT)\r
+X-AuditID: 12074425-b7f966d0000008b6-ff-4fbf9ab52f5f\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+       by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 9D.D5.02230.5BA9FBF4; Fri, 25 May 2012 10:44:05 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q4PEi56u015057; \r
+       Fri, 25 May 2012 10:44:05 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q4PEi3ZS007933\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Fri, 25 May 2012 10:44:04 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SXvkJ-0000dw-Ol; Fri, 25 May 2012 10:44:03 -0400\r
+Date: Fri, 25 May 2012 10:44:03 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>\r
+Subject: Re: [PATCH v4 0/7] cli: improved crypto internals\r
+Message-ID: <20120525144403.GD11804@mit.edu>\r
+References: <1337812843-14986-1-git-send-email-jrollins@finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1337812843-14986-1-git-send-email-jrollins@finestructure.net>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IRYrdT1906a7+/Qd9uY4s9+7wsrt+cyezA\r
+       5HH3NJfHs1W3mAOYorhsUlJzMstSi/TtErgyfv5Zz1RwkKXiw8FvzA2MJ5i7GDk5JARMJPa/\r
+       P8YOYYtJXLi3nq2LkYtDSGAfo8T0pzeZIJwNjBKz17awQzgnmSQ2H1rPCuEsYZQ419HMCNLP\r
+       IqAq8enYQTCbTUBDYtv+5WC2iICZRM+XP2A2s4CWxNaNH8BsYQEricWrpjCB2LwCOhJ/j00E\r
+       u0lIwEti2uEjbBBxQYmTM5+wwPTe+PcSqJ4DyJaWWP6PAyTMKeAt8e9LH9gYUQEViSknt7FN\r
+       YBSahaR7FpLuWQjdCxiZVzHKpuRW6eYmZuYUpybrFicn5uWlFula6OVmluilppRuYgQHtYvq\r
+       DsYJh5QOMQpwMCrx8DJF7/MXYk0sK67MPcQoycGkJMp7ZuZ+fyG+pPyUyozE4oz4otKc1OJD\r
+       jBIczEoivCxpQDnelMTKqtSifJiUNAeLkjjvOs3d/kIC6YklqdmpqQWpRTBZGQ4OJQleHmD0\r
+       CgkWpaanVqRl5pQgpJk4OEGG8wANvwiymLe4IDG3ODMdIn+KUVFKnPcySEIAJJFRmgfXC0s6\r
+       rxjFgV4R5p0JUsUDTFhw3a+ABjMBDd7yeC/I4JJEhJRUA6OISNlzbXaLf4KsZ7RvaCbPP2/O\r
+       7Lj9x9V7gbu8gkpCf82ZUN53RDrF+p9PlezelxGuORnZwhk+1y+87+veuvwV38eX9hNnfnZW\r
+       zv7yY8Ify0v3QpKvRW3PzDpy0PeOnvYTo1ubdGsnet3pyOG2NCzWe9b582pmc2xz8LS+RXWO\r
+       rT3tLiu2uyqxFGckGmoxFxUnAgA7Jc6vFQMAAA==\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 25 May 2012 14:44:06 -0000\r
+\r
+Quoth Jameson Graef Rollins on May 23 at  3:40 pm:\r
+> Ok, hopefully last version.  This addresses Jani's latest comments.\r
+> \r
+> The first patch uses a typedef to handle the incompatibility between\r
+> the crypto context between GMIME 2.4 and 2.6.  We probably should have\r
+> done this originally, as it gets rid of a bunch of #ifdefs, and should\r
+> help reduce confusion.\r
+> \r
+> I also move to use strcasecmp for the crypto protocol, with a comment\r
+> that points to the relevant RFCs for justification.\r
+\r
+This series LGTM other than the one and a half comments I just sent.\r