Re: FreeBSD Support Patches

diff --git a/66/cd0e05979e5f8ccbe84770d77945f65bd1b753 b/66/cd0e05979e5f8ccbe84770d77945f65bd1b753
new file mode 100644 (file)
index 0000000..aff9d2b
--- /dev/null
+++ b/66/cd0e05979e5f8ccbe84770d77945f65bd1b753
@@ -0,0 +1,98 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B5228431FBC\r
+       for <notmuch@notmuchmail.org>; Fri, 25 May 2012 13:53:13 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id NETJrnVIqgml for <notmuch@notmuchmail.org>;\r
+       Fri, 25 May 2012 13:53:10 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id C5DB2431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 25 May 2012 13:53:10 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 387BE100641; Fri, 25 May 2012 23:53:20 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mike Kelly <pioto@pioto.org>, notmuch@notmuchmail.org\r
+Subject: Re: FreeBSD Support Patches\r
+In-Reply-To: <1337953411-21000-1-git-send-email-pioto@pioto.org>\r
+References: <1337953411-21000-1-git-send-email-pioto@pioto.org>\r
+User-Agent: Notmuch/0.13+38~g944a859 (http://notmuchmail.org) Emacs/23.1.1\r
+       (x86_64-redhat-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Fri, 25 May 2012 23:53:20 +0300\r
+Message-ID: <m2k400geyn.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 25 May 2012 20:53:13 -0000\r
+\r
+On Fri, May 25 2012, Mike Kelly <pioto@pioto.org> wrote:\r
+\r
+> Hi,\r
+>\r
+> These patches add some changes necessary for a clean build on FreeBSD,\r
+> and for most of the tests to pass.\r
+>\r
+> Also mixed in are a few patches to disable emacs tests when you don't\r
+> have emacs, along with tests that depend upon emacs. I could split those\r
+> off onto a separate branch if required.\r
+\r
+Yes...\r
+\r
+Thank you for your efforts to make notmuch better; some general\r
+comments on this patch series:\r
+\r
+\r
+Commit messages are somewhat terse\r
+check what http://notmuchmail.org/patchformatting/\r
+has to say about this.\r
+\r
+MANPATH setting has hit me too -- but that shold be set\r
+in the same place where PATH is adjusted to find notmuch\r
+command instead of hardcoding '../../man'.\r
+\r
+s/executable/+111/ (and following sed (which could be combined\r
+into next sed but that's another matter)) is good (that hit me\r
+once too) -- This particular patch has the worst commit message,\r
+though (Make test/basic more portable) ;/\r
+\r
+in 6/10 there is missing space before sed in '...wc -l |sed...'.\r
+\r
+-p overrides -n in perl, so perl -pe... (-npe confuses, at least\r
+me...)\r
+\r
+The patch series is supposed to add FreeBSD support; \r
+prereq additions to take care missing emacs should\r
+be in separate series.\r
+\r
+Some of the patches could be marked as 'trivial', putting those\r
+to 'maybe ready' section in http://nmbug.tethera.net/status/\r
+-- just if those had more comprehensive commit messages.\r
+\r
+> You can find the latest version of these patches on my github repo's\r
+> fbsd-support branch:\r
+>\r
+>   https://github.com/pioto/notmuch/compare/master...fbsd-support \r
+\r
+Tomi\r