Re: [PATCH 1/5] go: reorganize the go bindings

diff --git a/e2/77ab24be59217226ebe3d476f7c846b0a7cabe b/e2/77ab24be59217226ebe3d476f7c846b0a7cabe
new file mode 100644 (file)
index 0000000..a1eff31
--- /dev/null
+++ b/e2/77ab24be59217226ebe3d476f7c846b0a7cabe
@@ -0,0 +1,93 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 55D9E431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  4 May 2012 11:38:27 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id T7kMg6Sq7jRc for <notmuch@notmuchmail.org>;\r
+       Fri,  4 May 2012 11:38:26 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
+       [18.9.25.13])\r
+       by olra.theworths.org (Postfix) with ESMTP id B051B431FAE\r
+       for <notmuch@notmuchmail.org>; Fri,  4 May 2012 11:38:26 -0700 (PDT)\r
+X-AuditID: 1209190d-b7fbf6d0000008ba-72-4fa42221b4d0\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+       by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 18.47.02234.12224AF4; Fri,  4 May 2012 14:38:25 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q44IcOep024226; \r
+       Fri, 4 May 2012 14:38:25 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q44IcNZh007947\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Fri, 4 May 2012 14:38:24 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SQNOY-0005I4-Vn; Fri, 04 May 2012 14:38:23 -0400\r
+Date: Fri, 4 May 2012 14:38:22 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+Subject: Re: [PATCH 1/5] go: reorganize the go bindings\r
+Message-ID: <20120504183822.GN2704@mit.edu>\r
+References: <20120430195420.2528.48612@thinkbox.jade-hamburg.de>\r
+       <1335815744-15258-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To:\r
+ <1335815744-15258-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hTV1lVUWuJvcGWnlcXs1h9MFtdvzmR2\r
+       YPKYeP40m8ezVbeYA5iiuGxSUnMyy1KL9O0SuDI6Pl1kL3jFWnH/733GBsZrLF2MHBwSAiYS\r
+       nyfHdjFyApliEhfurWfrYuTiEBLYxyjx4tAPFghnPaNE+/sXUM4JJomZW+cyQjhLGCVmP7zM\r
+       BjKKRUBF4v8MZZBRbAIaEtv2L2cEsUUETCU2PHjADmIzC0hLfPvdzARiCwuYS8ye8pINxOYV\r
+       0JboX/4danUHo8TPs01MEAlBiZMzn7BANGtJ3Pj3kglkF8ig5f84QExOgSCJs69zQCpEgS6Y\r
+       cnIb2wRGoVlImmchaZ6F0LyAkXkVo2xKbpVubmJmTnFqsm5xcmJeXmqRrpFebmaJXmpK6SZG\r
+       cFBL8u5gfHdQ6RCjAAejEg9vJu8SfyHWxLLiytxDjJIcTEqivAHyQCG+pPyUyozE4oz4otKc\r
+       1OJDjBIczEoivElfF/sL8aYkVlalFuXDpKQ5WJTEeVW13vkJCaQnlqRmp6YWpBbBZGU4OJQk\r
+       ePMVgYYKFqWmp1akZeaUIKSZODhBhvMADRcGqeEtLkjMLc5Mh8ifYtTlmDdl61VGIZa8/LxU\r
+       KXHecpAiAZCijNI8uDmwZPSKURzoLWHeOJAqHmAig5v0CmgJE9ASaYNFIEtKEhFSUg2M11+5\r
+       xzm2Fr6acv1i+V+59SYVa8O2zanquv9dj/OzhJbruwNL79rPe640hXvZoa9b5/kWsLX99DU7\r
+       l97erB80mZff8dzC1sviCX+6hexbLJVaVlyWWFx3Unu96KM4/pCyyfFm9V1va08s5DhhvPAY\r
+       91Qf1wdt95utj7K/fSEwrfyuytKV032blFiKMxINtZiLihMBv5H5XyEDAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 04 May 2012 18:38:27 -0000\r
+\r
+Quoth Justus Winter on Apr 30 at  9:55 pm:\r
+> Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+\r
+Whole series LGTM (and yay gofmt!).  I have only two minor comments.\r
+\r
+It would be nice to have a little more log message for some of these.\r
+Mostly the first one could use some explanation of why you're\r
+rearranging the source tree and a mention that there are no changes to\r
+the files (since this is hard to get from the diff).\r
+\r
+It would also be nice if this could optionally be built using the\r
+libnotmuch and notmuch.h directly from the source tree containing the\r
+Go bindings, rather than requiring them to be installed system-wide.\r
+I don't know Go 1's build system well enough to know if there's an\r
+easy way to do this.\r