Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

diff --git a/f7/42234714c769bd4c5a57761aa077c022aefaae b/f7/42234714c769bd4c5a57761aa077c022aefaae
new file mode 100644 (file)
index 0000000..0feea38
--- /dev/null
+++ b/f7/42234714c769bd4c5a57761aa077c022aefaae
@@ -0,0 +1,133 @@
+Return-Path: <dme@dme.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 347E7431E64\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 01:37:22 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ksgvtrKO9+7U for <notmuch@notmuchmail.org>;\r
+       Mon, 30 Jan 2012 01:37:21 -0800 (PST)\r
+Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com\r
+ [74.125.82.45])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 82426431FBC   for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 01:37:21 -0800\r
+ (PST)\r
+Received: by wgbdt12 with SMTP id dt12so3768569wgb.2\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 01:37:20 -0800 (PST)\r
+Received: by 10.180.89.71 with SMTP id bm7mr21879002wib.20.1327916240206;\r
+       Mon, 30 Jan 2012 01:37:20 -0800 (PST)\r
+Received: from hotblack-desiato.hh.sledj.net\r
+       (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])\r
+       by mx.google.com with ESMTPS id bj10sm28851646wib.9.2012.01.30.01.37.18\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Mon, 30 Jan 2012 01:37:19 -0800 (PST)\r
+Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)\r
+       id 4B04CA05FB; Mon, 30 Jan 2012 09:37:17 +0000 (GMT)\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other\r
+ toggles\r
+In-Reply-To: <87ehuiz31a.fsf@servo.finestructure.net>\r
+References: <1327486729-18052-1-git-send-email-dme@dme.org>\r
+       <87ehuiz31a.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.11+122~g97bdcf6 (http://notmuchmail.org) Emacs/24.0.92.1\r
+       (x86_64-pc-linux-gnu)\r
+From: David Edmondson <dme@dme.org>\r
+Date: Mon, 30 Jan 2012 09:37:17 +0000\r
+Message-ID: <cun7h09il9u.fsf@hotblack-desiato.hh.sledj.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="==-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 09:37:22 -0000\r
+\r
+--==-=-=\r
+Content-Type: multipart/mixed; boundary="=-=-="\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Sun, 29 Jan 2012 12:06:57 -0800, Jameson Graef Rollins <jrollins@finestr=\r
+ucture.net> wrote:\r
+> > My inclination is to remove `notmuch-crypto-process-mime' altogether\r
+> > (declared it an obsolete variable) and allow users to set a default\r
+> > for `notmuch-show-process-crypto' directly, but that is not done in\r
+> > this patchset while awaiting feedback.\r
+>=20\r
+> I'm not sure I understand this.  `notmuch-show-process-crypto' *is* what\r
+> sets the default for the `notmuch-show-process-crypto' buffer-local\r
+> variable.  How would you change the current behavior or settings (beyond\r
+> just a variable rename)?\r
+\r
+The problem with the code as I posted can be seen if you imagine the\r
+following ~/.emacs.el sequence:\r
+\r
+\r
+--=-=-=\r
+Content-Type: application/emacs-lisp\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+(require 'notmuch) ;; Ends up loading notmuch-crypto.el and notmuch-show.el.\r
+;; notmuch-crypto.el has `notmuch-crypto-process-mime' default as `nil'.\r
+;; notmuch-show.el uses the value of `notmuch-crypto-process-mime' to\r
+;; set the default value of `notmuch-show-process-crypto', so it is now\r
+;; also `nil'.\r
+\r
+(custom-set-variables\r
+ '(notmuch-crypto-process-mime t))\r
+;; `notmuch-crypto-process-mime' is now `t', but\r
+;; `notmuch-show-process-crypto' remains `nil'.\r
+\r
+;; No crypto decoding takes place in `notmuch-show-mode'.\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+\r
+I'm sure that I can figure out either some `defcustom' goop or worse to\r
+sort it out so that the initialisation happens correctly.\r
+\r
+> > `notmuch-crypto-process-mime' is used only in notmuch-show.el, so the\r
+> > setting really belongs there with an appropriate name.\r
+>=20\r
+> I intentionally put this in a separate section in case there were\r
+> eventually other needs for this setting beyond just show mode.  I\r
+> personally think we should just leave it where it is, particularly\r
+> since it's been there for a while.\r
+\r
+Okay.\r
+\r
+--=-=-=--\r
+\r
+--==-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEUEARECAAYFAk8mZM0ACgkQaezQq/BJZRZhngCeKymY9EQoNYYWhJGqUWsfD+ep\r
+IdEAl09OD4hB2AfjX7HXuQH8YoQuNAE=\r
+=C2+K\r
+-----END PGP SIGNATURE-----\r
+--==-=-=--\r