Re: [PATCH v2] emacs: display tags in notmuch-show with links

diff --git a/13/85e2305923560f8b9d1d0a397f27f3b1fba7a6 b/13/85e2305923560f8b9d1d0a397f27f3b1fba7a6
new file mode 100644 (file)
index 0000000..a622d4d
--- /dev/null
+++ b/13/85e2305923560f8b9d1d0a397f27f3b1fba7a6
@@ -0,0 +1,114 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 60229431FBD\r
+       for <notmuch@notmuchmail.org>; Sun, 18 Nov 2012 15:00:06 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.7\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.7 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id SY03khlxczFR for <notmuch@notmuchmail.org>;\r
+       Sun, 18 Nov 2012 15:00:05 -0800 (PST)\r
+Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com\r
+       [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id C4A5A431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 18 Nov 2012 15:00:05 -0800 (PST)\r
+Received: by mail-qc0-f181.google.com with SMTP id x40so3185640qcp.26\r
+       for <notmuch@notmuchmail.org>; Sun, 18 Nov 2012 15:00:05 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=2iuaq6ZGivbAjHj5/Qtapp3pwZe/gm77MPCyAH89V6A=;\r
+       b=s3ijgm4kw0k731WVArLcdPcsyZPdRivr/VzCDFVqahCYYRZ1QlbwtOCwCuC/WONqU8\r
+       sdnoRU82BsOCjC9ByzOougiMQ43vEjBa+apMS/IRxLDZponpD/b094i+EkFkTQx+88Xe\r
+       myWnKV9tJxDI54i3ypc0n4SQXHD9tvAy6QNi/j5AyuiqG4ov46w4yvMs3h2uFpLTWgxH\r
+       vw0aF4OI1jDn++pVOR9i3SVi1nqloQ2MlrqkyTLwWD1bXqFE2FP4uMJMeH6618gohsZc\r
+       8ZM6JvaDrYYSX9/29i88zULqfQyjZiRq3kxL8zYV7/3N27XzIUstUUviqgXIi0z2Muzi\r
+       nNOQ==\r
+Received: by 10.224.33.135 with SMTP id h7mr9992221qad.26.1353279605199;\r
+       Sun, 18 Nov 2012 15:00:05 -0800 (PST)\r
+Received: from smtp.gmail.com ([66.114.71.21])\r
+       by mx.google.com with ESMTPS id r13sm5186843qaa.20.2012.11.18.14.59.55\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sun, 18 Nov 2012 15:00:03 -0800 (PST)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Damien Cassou <damien.cassou@gmail.com>,\r
+       notmuch mailing list <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v2] emacs: display tags in notmuch-show with links\r
+In-Reply-To: <1353266322-20318-1-git-send-email-damien.cassou@gmail.com>\r
+References: <1353266322-20318-1-git-send-email-damien.cassou@gmail.com>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/24.1.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 18 Nov 2012 17:59:53 -0500\r
+Message-ID: <87ip921pqu.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 18 Nov 2012 23:00:06 -0000\r
+\r
+Damien Cassou <damien.cassou@gmail.com> writes:\r
+\r
+> This patch obsoletes\r
+> id:1352565719-12397-1-git-send-email-damien.cassou@gmail.com\r
+>\r
+> [PATCH 1/4] emacs: Add a thread's tags to emacs header-line\r
+> [PATCH 2/4] emacs: Make tags in header-line clickable\r
+> [PATCH 3/4] emacs: Make tags that appear in `notmuch-show' clickable\r
+> [PATCH 4/4] emacs: Add unit-tests for clickable tags in notmuch-show\r
+>\r
+> This patch makes clickable all tags that appear in notmuch-show\r
+> buffers. Each tag is a link to open a new notmuch-search buffer for\r
+> this tag. Additionally, the buffer's header-line now shows the\r
+> thread's tags (clickable only if the `header-button' library is loaded\r
+> or loadable).\r
+\r
+Looks fine to me. Let me just get the notes from my bikeshed, in case\r
+you get asked to roll another version :)\r
+\r
+- You might want to use #' on lambdas.\r
+\r
+- It bothers me how similar notmuch-tagger-{body,header}-button-action\r
+  are. I thought it might be better to unify them by seeing what type\r
+  the button argument was. Here's my (untested) approach which you might\r
+  find prettier or uglier.\r
+\r
+(notmuch-tagger-all-button-get (button attrib)\r
+  "Utility function to do button-get on different kinds of buttons."\r
+  (cond\r
+    ((integer-or-marker-p button)\r
+      (button-get button attrib))\r
+    ((and (featurep 'header-button)\r
+          (listp button))\r
+      (header-button-get button attrib))\r
+    (t (error "unknown type of button %s" button))\r
+\r
+- The comment for notmuch-tagger-make-body-link reads that it will work\r
+  "everywhere except in the header-line". Does this mean mode-line, menu\r
+  bar, or what? How about just "won't work in the header-line"?\r
+\r
+- In patch 3:\r
+\r
+ +If tags the result of this function is to be used within the\r
+\r
+I think this should just read "If the result".\r
+\r
+Ethan\r