Re: [PATCH] emacs: notmuch-search: fix faces
authorMichal Nazarewicz <mpn@google.com>
Mon, 27 Aug 2012 23:11:05 +0000 (01:11 +0200)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:49:13 +0000 (09:49 -0800)
35/2e93c9e09f7aaef410b58af07bdcc6ad4c0d73 [new file with mode: 0644]

diff --git a/35/2e93c9e09f7aaef410b58af07bdcc6ad4c0d73 b/35/2e93c9e09f7aaef410b58af07bdcc6ad4c0d73
new file mode 100644 (file)
index 0000000..2da368b
--- /dev/null
@@ -0,0 +1,154 @@
+Return-Path: <mpn@google.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0882A431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 27 Aug 2012 16:11:16 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.8\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.8 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id rXkzqbjgyWLL for <notmuch@notmuchmail.org>;\r
+       Mon, 27 Aug 2012 16:11:15 -0700 (PDT)\r
+Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com\r
+ [74.125.83.53])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 2E53A431FAE   for <notmuch@notmuchmail.org>; Mon, 27 Aug 2012 16:11:15 -0700\r
+ (PDT)\r
+Received: by eekb47 with SMTP id b47so1360458eek.26\r
+       for <notmuch@notmuchmail.org>; Mon, 27 Aug 2012 16:11:13 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\r
+ s=20120113;   h=from:to:subject:in-reply-to:organization:references:user-agent\r
+       :x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version        :content-type;\r
+ bh=Ik/J2ID7GdU9IRmafYP+07DA21IUugVYKa+pPyfZ5cY=;\r
+       b=gPYdEjC1rrbFBabZndKeYYk5xuduXoRDxKKDiCnLXbvEc7jswBDJuLECPNKf59y3Kp\r
+       aIceErCFh9BaFJf3w+aGTiPWP/WSfqWwOic4IxBJQAIOiWVId4Xb40PMWG94NRXHPmgQ\r
+       mdUnTMO3uklBF/Fs/hOdPfrXyI86xQotjJ+/5U9HbiiENMgbSWb4/e17G9nV4YnzTy/B\r
+       KcY2F+75KQI2CgdRQx/589OI5Eyy2vhOdtXVYmIYMsgyiIJo25thwZDS4Nog4NKjjhXw\r
+       ehhXnQ4c3ZAdn8ySgzjtswP8dXIRnfpTdRm82/tdgu5ieAC2pFlAw7u7biyG+Iu0I3C/    eqUQ==\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:organization:references:user-agent\r
+       :x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version\r
+       :content-type:x-gm-message-state;\r
+       bh=Ik/J2ID7GdU9IRmafYP+07DA21IUugVYKa+pPyfZ5cY=;\r
+       b=EctxjKnRsEqhzQYrzw/WuQNu6SUBa/t6eRddnkwfxd9OIpbpeOyuAKt9LJY8ZhALws\r
+       sS5+mz4ewEHG6rJ5Jgrfg1+SoiGZQFvM4sUqxxDfZi3Vte50GOXgZr1H3Lyd+cxdAiVi\r
+       B9zp03xYg2SxIpYiu1VqtkhLs928k68/CnMjrmFhtRSI9+w4SvJXl9n+y0F0Rrj4d1Wj\r
+       45/mvvNrfCODqqWcCtKNFb2rDrLVAQtdgoUQwBmWcqDkm0+03/MCzbZ00gKgvkWlUNWa\r
+       edo5OuH0o5MFzj5tWwgTSSwNIYuDT8OuIo2k7WwD/Ccw2AXw5gGEfI1AbkkfjuWV1rMO\r
+       OAuw==\r
+Received: by 10.14.203.69 with SMTP id e45mr3363469eeo.23.1346109073918;\r
+       Mon, 27 Aug 2012 16:11:13 -0700 (PDT)\r
+Received: by 10.14.203.69 with SMTP id e45mr3363457eeo.23.1346109073753;\r
+       Mon, 27 Aug 2012 16:11:13 -0700 (PDT)\r
+Received: from mpn-glaptop ([2620:0:105f:5:f2de:f1ff:fe35:1a72])\r
+       by mx.google.com with ESMTPS id v3sm56095064eep.10.2012.08.27.16.11.10\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Mon, 27 Aug 2012 16:11:12 -0700 (PDT)\r
+From: Michal Nazarewicz <mpn@google.com>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: notmuch-search: fix faces\r
+In-Reply-To: <87ipc4jcfv.fsf@servo.finestructure.net>\r
+Organization: Google Inc\r
+References:\r
+ <83882f4c8de5317e0184dc091a197b2341e5f015.1345725028.git.mina86@mina86.com>\r
+       <87ipc4jcfv.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.14+2~g416b120 (http://notmuchmail.org) Emacs/24.2.50.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;       KFrfMCylc}gc??'U2j,!8%xdD\r
+Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC\r
+X-PGP: 50751FF4\r
+X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4\r
+Date: Tue, 28 Aug 2012 01:11:05 +0200\r
+Message-ID: <xa1t3938ue0m.fsf@mina86.com>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/mixed; boundary="=-=-="\r
+X-Gm-Message-State: ALoCoQmzDF4KkvfdPFFFhX5REkahG/bX9c7mC8ZD+WnG3PTvpfeKUbt37xVGHbKsEPhoPGnimwz09v/1rpEHqRukkybXYQDdw+LFPEfJjks6tPyp7//xJQvu/APB8X6w2Ac/FubtSSMDMC1jC0Jr9HWK2L0vxBdOjWVaDTvCpaQm4Aoi0PbPKlMLiUtwxMHzHUml7AtCb09ukyTPXfSZb4I8eMQ7JqKDRA==\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 27 Aug 2012 23:11:16 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+> On Thu, Aug 23 2012, Michal Nazarewicz <mpn@google.com> wrote:\r
+>> For some reason the faces do not get applied when 'face property is\r
+>> used, but they work correctly with 'font-lock-face property.  This\r
+>> commit changes notmuch-search to use the latter.\r
+\r
+Jameson Graef Rollins <jrollins@finestructure.net> writes:\r
+> Hi, Michal.  Can you say a bit more about what's motivating this?  This\r
+> feature seems to work fine for me, so I would like to understand what's\r
+> not working for you.  I'm certainly no expert on emacs font handling,\r
+> though, so maybe this is the proper thing to do.  Thanks.\r
+\r
+I'm not an expert either, but with this patch applied I see colours,\r
+without this patch, I don't see colours, ie. everything is rendered\r
+using the default face.\r
+\r
+I'm also not entirely sure if that's the correct way of doing things\r
+since 'face seems to be working in other modes (most notably\r
+notmuch-show).  By posting, I'm also hoping that someone more\r
+experienced will maybe take a look to see what's going on here... ;)\r
+\r
+For some more info, in notmuch-show mode, I get-text-property of nil for\r
+both 'face and 'font-lock-face, but in message-mode or in *scratch*\r
+buffer I'm getting nil for 'font-lock-face but non-nil for 'face.  With\r
+the patch, I'm getting the same non-nil for both 'face and\r
+'font-lock-face; without the patch, I'm getting nil for both.\r
+\r
+--=20\r
+Best regards,                                         _     _\r
+.o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o\r
+..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =\r
+ (o o)\r
+ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--\r
+--=-=-=\r
+Content-Type: multipart/signed; boundary="==-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+\r
+--==-=-=\r
+Content-Type: text/plain\r
+\r
+\r
+--==-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iQIcBAEBAgAGBQJQO/6JAAoJECBgQBJQdR/0akcQAIHv7HM1dpg8CdL91ZgHus10\r
+k+QwrXnTyr3GoRsJrD3sPZEnXc1FxXFJbMNq+b+nBfsU6Ihjv8WpuqMP/K3amo5f\r
+x3lEjsvnsUB8Is8/lvp3OuGW9l8+AhWphX6dB2n3uqUTy0w6xzurwB5JHEUG0Z+C\r
+IHs45QfvVhkw7BEpV3o8FCDcP0letSbFg2ff2AnASFoHh8nykeVo1e/hjWp0qJao\r
+t1nYwxjw2g000O81aNN6xxbbksfxlNWvquypnCmUIHbhBROLgaJKCKs6/MskEA30\r
+BNuXsDB81TwVBcoyO83ttl1zU9CdCrq6cUkEYvQy8aZxn5Isn0jeg5vGnzh7mm3J\r
+g5jIb3eohBX2MngafLqVGrCrzGolZjXqF+GekllDNuVUcfqXychhpiBRNE+XZ+2T\r
+i8Hj/PTRCvTKRg/vIqCQma4cSo2qtJ0hMW0or7McNZ8XWne1tFPKqJ3It4qBFrqf\r
+SKRZPD6V41X3U44sRQ+SQ6hTfyNHkOIVwGNVQ6ZPs84/x9J2JuUJ0FxQq26s9Ne2\r
+7QLQaEdswBzvsdKS1+2AMvIXirq+mIFTIcrpjzaUWEgKcWTSO4o5t3l8s8VJ+wz2\r
+iav9EAxIlxdXma6rnd2n3/ER+3RzUL361FI31v1/a2bEU1z1xRi/ihOzYHRpojz5\r
+0yRaBPwWAwPQMXvyMjBz\r
+=C4xR\r
+-----END PGP SIGNATURE-----\r
+--==-=-=--\r
+\r
+--=-=-=--\r