kde5-functions: die if too many arguments are passed to add_*_dep

This avoids bugs where too many arguments are passed by mistake, causing the
last one to be ignored.

For example, the subslot operator added in d1bc5ac3f0e42df0f0255c8b39d7df16c5d4176b
was never applied because too many '' were passed.

diff --git a/eclass/kde5-functions.eclass b/eclass/kde5-functions.eclass
index b20d406721dd40fab2d4fe9461eeaf7911dcf478..a8cc1a34432752a3148d780e33099c09f70a4630 100644 (file)
--- a/eclass/kde5-functions.eclass
+++ b/eclass/kde5-functions.eclass
@@ -141,6 +141,10 @@ _add_category_dep() {
 add_frameworks_dep() {
        debug-print-function ${FUNCNAME} "$@"
 
+       if [[ $# -gt 4 ]]; then
+               die "${FUNCNAME} was called with too many arguments"
+       fi
+
        local version
 
        if [[ -n ${3} ]]; then
@@ -169,6 +173,10 @@ add_frameworks_dep() {
 add_plasma_dep() {
        debug-print-function ${FUNCNAME} "$@"
 
+       if [[ $# -gt 4 ]]; then
+               die "${FUNCNAME} was called with too many arguments"
+       fi
+
        local version
 
        if [[ -n ${3} ]]; then
@@ -197,6 +205,10 @@ add_plasma_dep() {
 add_kdeapps_dep() {
        debug-print-function ${FUNCNAME} "$@"
 
+       if [[ $# -gt 4 ]]; then
+               die "${FUNCNAME} was called with too many arguments"
+       fi
+
        local version
 
        if [[ -n ${3} ]]; then
@@ -230,6 +242,10 @@ add_kdeapps_dep() {
 add_qt_dep() {
        debug-print-function ${FUNCNAME} "$@"
 
+       if [[ $# -gt 4 ]]; then
+               die "${FUNCNAME} was called with too many arguments"
+       fi
+
        local version
 
        if [[ -n ${3} ]]; then