Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected

diff --git a/62/10f4157dec07a7c04852d623a18c01d1bdc663 b/62/10f4157dec07a7c04852d623a18c01d1bdc663
new file mode 100644 (file)
index 0000000..383154e
--- /dev/null
+++ b/62/10f4157dec07a7c04852d623a18c01d1bdc663
@@ -0,0 +1,82 @@
+Return-Path: <adrien@bustany.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9A3BE431FC0\r
+       for <notmuch@notmuchmail.org>; Thu, 25 Oct 2012 11:41:37 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id xAD6SFFjUq1j for <notmuch@notmuchmail.org>;\r
+       Thu, 25 Oct 2012 11:41:37 -0700 (PDT)\r
+Received: from mail.bustany.org (bustany.org [176.31.244.208])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2885F431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 25 Oct 2012 11:41:37 -0700 (PDT)\r
+Received: from [192.168.1.147] (91-158-5-86.elisa-laajakaista.fi\r
+ [91.158.5.86])        by mail.bustany.org (Postfix) with ESMTPSA id 3DCAE140230;\r
+       Thu, 25 Oct 2012 20:45:31 +0200 (CEST)\r
+Message-ID: <508987DD.9010405@bustany.org>\r
+Date: Thu, 25 Oct 2012 21:41:33 +0300\r
+From: Adrien Bustany <adrien@bustany.org>\r
+User-Agent: Mozilla/5.0 (X11; Linux x86_64;\r
+       rv:16.0) Gecko/20121009 Thunderbird/16.0\r
+MIME-Version: 1.0\r
+To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+Subject: Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected\r
+References: <1342636475-16057-1-git-send-email-adrien@bustany.org>\r
+       <1342636475-16057-4-git-send-email-adrien@bustany.org>\r
+       <87wqyn6rpf.fsf@betacantrips.com>\r
+In-Reply-To: <87wqyn6rpf.fsf@betacantrips.com>\r
+Content-Type: text/plain; charset=ISO-8859-1; format=flowed\r
+Content-Transfer-Encoding: 8bit\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 25 Oct 2012 18:41:37 -0000\r
+\r
+Le 19/10/2012 06:55, Ethan Glasser-Camp a écrit :\r
+> Adrien Bustany <adrien@bustany.org> writes:\r
+>\r
+>> This makes notmuch appropriately free the underlying notmuch C objects\r
+>> when garbage collecting their Go wrappers. To make sure we don't break\r
+>> the underlying links between objects (for example, a notmuch_messages_t\r
+>> being GC'ed before a notmuch_message_t belonging to it), we add for each\r
+>> wraper struct a pointer to the owner object (Go objects with a reference\r
+>> pointing to them don't get garbage collected).\r
+>\r
+> Hi Adrien! This whole series is marked moreinfo, but I don't think\r
+> that's just. It looks like there were some unresolved issues about\r
+> reference tracking and garbage collection, and some suggestions to use\r
+> the C values of enums instead of regenerating them with iota, but\r
+> there's definitely valid code that I assume would be useful if anyone\r
+> ever wanted to write in Go ;). Are you figuring to clean this series up?\r
+>\r
+> This comment should s/wraper/wrapper/.\r
+>\r
+> Ethan\r
+>\r
+\r
+Hello Ethan,\r
+\r
+thanks for the heads up, I still have this on my table, and yes there is \r
+additional work to do for the patches to be really clean. I can't give \r
+an estimate for now, let's hope sooner than later :/\r
+\r
+Cheers\r
+\r
+Adrien\r