Re: [PATCH v4 03/12] cli: add insert command

diff --git a/56/e67c0721550e5971dccb4ed726ac0f9526bd59 b/56/e67c0721550e5971dccb4ed726ac0f9526bd59
new file mode 100644 (file)
index 0000000..7447ebe
--- /dev/null
+++ b/56/e67c0721550e5971dccb4ed726ac0f9526bd59
@@ -0,0 +1,73 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8B545431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  5 Mar 2013 17:13:35 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id fUvYqreExhQ4 for <notmuch@notmuchmail.org>;\r
+       Tue,  5 Mar 2013 17:13:35 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 189BF431FAE\r
+       for <notmuch@notmuchmail.org>; Tue,  5 Mar 2013 17:13:35 -0800 (PST)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UD2vB-0007oN-Fd; Tue, 05 Mar 2013 21:13:31 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UD2v5-0001Wo-PT; Tue, 05 Mar 2013 21:13:23 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4 03/12] cli: add insert command\r
+In-Reply-To: <1359029288-12132-4-git-send-email-novalazy@gmail.com>\r
+References: <1359029288-12132-1-git-send-email-novalazy@gmail.com>\r
+       <1359029288-12132-4-git-send-email-novalazy@gmail.com>\r
+User-Agent: Notmuch/0.15.2+32~g16aa65b (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 05 Mar 2013 21:13:23 -0400\r
+Message-ID: <87ppzdxrd8.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 06 Mar 2013 01:13:35 -0000\r
+\r
+Peter Wang <novalazy@gmail.com> writes:\r
+\r
+> The notmuch insert command reads a message from standard input,\r
+> writes it to a Maildir folder, and then incorporates the message into\r
+> the notmuch database.  Essentially it moves the functionality of\r
+> notmuch-deliver into notmuch.\r
+\r
+The first three patches in this series look OK to me so far.\r
+\r
+There is some conflict with Jani's --config command line argument patches,\r
+but that should be easy/generic to fix.\r
+\r
+I'll try to review the next 3 patches in this series this week; this\r
+message should serve as a heads up for people interested in this series\r
+that its next on my agenda after Jani's config file patches.\r
+\r