Re: [PATCH v2 2/3] reply: add message-id header

diff --git a/17/dcb96800bf4edf91804d560e6fb17d847db72d b/17/dcb96800bf4edf91804d560e6fb17d847db72d
new file mode 100644 (file)
index 0000000..4ba4696
--- /dev/null
+++ b/17/dcb96800bf4edf91804d560e6fb17d847db72d
@@ -0,0 +1,92 @@
+Return-Path: <awg@xvx.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5D3F7431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 10:27:56 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id y-JIuGqOXiO3 for <notmuch@notmuchmail.org>;\r
+       Wed, 18 Apr 2012 10:27:52 -0700 (PDT)\r
+Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com\r
+       [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 222A5431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 10:27:51 -0700 (PDT)\r
+Received: by lahc1 with SMTP id c1so6030630lah.26\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 10:27:50 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=mime-version:sender:x-originating-ip:in-reply-to:references:date\r
+       :x-google-sender-auth:message-id:subject:from:to:cc:content-type\r
+       :x-gm-message-state;\r
+       bh=5UKZTVFxrA5JUexhY/ghtSxumeXXKwCqhtfZkbPyl9Q=;\r
+       b=Empld8ZbuHnGCa+O2O6CoDuRjSuEo0UjbM5MNZzNrBj/H4bIgXRaj0xIVu7CT9RMhQ\r
+       cqBXeKRiC5go3ViSmvwvhhHnZY5xnax/09X03GjspjKIG2ZYoXdwsmmLn6011Vomk1NJ\r
+       TeBJCuBAJbEBs4VZrcPjYm46sY7mMoGvFRUkvxxGMoe77ngIJscbaFOUnW5mxOUUStUf\r
+       Wm58StNpfIInSWZybLIPR9NU8uoQHvT3ylcJApNmWJcwH46lv59JhlNuedXss76RdgSK\r
+       Oo6/8aTbZtLerCm8yo6sqhpp27O3xc7kvWWfzZxv/4YIZFd08o2eClep83wxWVgSQuJe\r
+       9t/g==\r
+MIME-Version: 1.0\r
+Received: by 10.152.129.137 with SMTP id nw9mr2891547lab.48.1334770070514;\r
+       Wed, 18 Apr 2012 10:27:50 -0700 (PDT)\r
+Sender: awg@xvx.ca\r
+Received: by 10.112.23.39 with HTTP; Wed, 18 Apr 2012 10:27:50 -0700 (PDT)\r
+X-Originating-IP: [128.221.197.57]\r
+In-Reply-To: <87zka9b2zl.fsf@nikula.org>\r
+References: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com>\r
+       <1334752753-23970-3-git-send-email-felipe.contreras@gmail.com>\r
+       <87zka9b2zl.fsf@nikula.org>\r
+Date: Wed, 18 Apr 2012 11:27:50 -0600\r
+X-Google-Sender-Auth: HOAc3JhsmjFtQXXv_GnbGVBVbrM\r
+Message-ID:\r
+ <CAMoJFUvcd+-b6VR7Mg3qfccZ1TUy3puMb12gAyaqJ0fyVV4uMg@mail.gmail.com>\r
+Subject: Re: [PATCH v2 2/3] reply: add message-id header\r
+From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>\r
+To: Jani Nikula <jani@nikula.org>\r
+Content-Type: text/plain; charset=ISO-8859-1\r
+X-Gm-Message-State:\r
+ ALoCoQk70iM5wlrLmilJo38gh3siahojd62Q1lMZ7cmPIL2BmH4Xlu99qLTu5eQiG/kPd0he9LYV\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Apr 2012 17:27:56 -0000\r
+\r
+On Wed, Apr 18, 2012 at 07:09, Jani Nikula <jani@nikula.org> wrote:\r
+> I do wonder whether the emacs ui / message mode will add a duplicate\r
+> message-id rather than override this.\r
+\r
+I think the emacs reply code will replace Message-ID and User-Agent\r
+headers correctly, as it does with the From header when selecting a\r
+different identity within emacs. But, this should be tested.\r
+\r
+Ideally, the emacs tests should catch any problems here. As things are\r
+right now, I think we would catch problems with the User-Agent header\r
+in the reply tests: the tests replace the emacs and notmuch versions\r
+with XXX but otherwise leave the header intact, so it should differ\r
+from the one generated by notmuch compose.\r
+\r
+The Message-ID is trickier, since in emacs it's generated when the\r
+message is sent, not when the message is created, and thus the reply\r
+tests don't see it at all. The "Sending a message via (fake) SMTP"\r
+test could potentially catch problems, but currently the tests don't\r
+try to predict the Message-ID emacs will give the message, so they\r
+replace it with XXX.\r
+\r
+-- Adam\r